CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Ronnie Sahlberg <[email protected]> TO: "linux-cifs" <[email protected]> CC: Steve French <[email protected]>
Hi Ronnie, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.14-rc2] [also build test WARNING on next-20210720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ronnie-Sahlberg/cifs-only-write-64kb-at-a-time-when-fallocating-a-small-region-of-a-file/20210721-085112 base: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago config: i386-randconfig-m021-20210720 (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: fs/cifs/smb2ops.c:3646 smb3_simple_fallocate_write_range() error: uninitialized symbol 'rc'. vim +/rc +3646 fs/cifs/smb2ops.c 31742c5a331766 Steve French 2014-08-17 3612 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3613 static int smb3_simple_fallocate_write_range(unsigned int xid, 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3614 struct cifs_tcon *tcon, 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3615 struct cifsFileInfo *cfile, 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3616 loff_t off, loff_t len, 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3617 char *buf) 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3618 { 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3619 struct cifs_io_parms io_parms = {0}; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3620 int rc, nbytes; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3621 struct kvec iov[2]; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3622 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3623 io_parms.netfid = cfile->fid.netfid; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3624 io_parms.pid = current->tgid; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3625 io_parms.tcon = tcon; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3626 io_parms.persistent_fid = cfile->fid.persistent_fid; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3627 io_parms.volatile_fid = cfile->fid.volatile_fid; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3628 f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3629 while (len) { 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3630 io_parms.offset = off; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3631 io_parms.length = len; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3632 if (io_parms.length > 65536) f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3633 io_parms.length = 65536; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3634 /* iov[0] is reserved for smb header */ 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3635 iov[1].iov_base = buf; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3636 iov[1].iov_len = io_parms.length; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3637 rc = SMB2_write(xid, &io_parms, &nbytes, iov, 1); f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3638 if (rc) f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3639 break; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3640 if (nbytes > len) f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3641 return -EINVAL; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3642 buf += nbytes; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3643 off += nbytes; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3644 len -= nbytes; f5db424b3e14aa Ronnie Sahlberg 2021-07-21 3645 } f5db424b3e14aa Ronnie Sahlberg 2021-07-21 @3646 return rc; 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3647 } 966a3cb7c7db78 Ronnie Sahlberg 2021-06-03 3648 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
