CC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Jeffle Xu <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi Jeffle, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on fuse/for-next] [also build test WARNING on v5.14-rc3 next-20210726] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/virtiofs-fuse-support-per-file-DAX/20210718-102250 base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next :::::: branch date: 10 days ago :::::: commit date: 10 days ago config: x86_64-randconfig-c001-20210727 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c658b472f3e61e1818e1909bf02f3d65470018a5) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/a6ac625f19c4c4de28ee8a466c1bab8824b7042e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jeffle-Xu/virtiofs-fuse-support-per-file-DAX/20210718-102250 git checkout a6ac625f19c4c4de28ee8a466c1bab8824b7042e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> clang-analyzer warnings: (new ones prefixed by >>) drivers/regulator/qcom_spmi-regulator.c:1155:2: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores] ret = spmi_vreg_update_bits(vreg, SPMI_COMMON_REG_ENABLE, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/regulator/qcom_spmi-regulator.c:1155:2: note: Value stored to 'ret' is never read ret = spmi_vreg_update_bits(vreg, SPMI_COMMON_REG_ENABLE, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 7 warnings generated. drivers/regulator/palmas-regulator.c:1598:36: warning: Value stored to 'pdata' during its initialization is never read [clang-analyzer-deadcode.DeadStores] struct palmas_pmic_platform_data *pdata = dev_get_platdata(&pdev->dev); ^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/regulator/palmas-regulator.c:1598:36: note: Value stored to 'pdata' during its initialization is never read struct palmas_pmic_platform_data *pdata = dev_get_platdata(&pdev->dev); ^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 5 warnings generated. Suppressed 5 warnings (5 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 5 warnings generated. Suppressed 5 warnings (5 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 7 warnings generated. drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:49:39: warning: Dereference of null pointer [clang-analyzer-core.NullDereference] const struct nvkm_vmm_desc *pair = page[-1].desc; ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1145:8: note: Assuming is non-null if (!(*pvmm = kzalloc(sizeof(**pvmm), GFP_KERNEL))) ^~~~~ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1145:2: note: Taking false branch if (!(*pvmm = kzalloc(sizeof(**pvmm), GFP_KERNEL))) ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1147:9: note: Calling 'nvkm_vmm_ctor' return nvkm_vmm_ctor(func, mmu, hdr, managed, addr, size, key, name, *pvmm); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1051:43: note: Assuming 'key' is null __mutex_init(&vmm->mutex, "&vmm->mutex", key ? key : &_key); ^~~ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1051:43: note: '?' condition is false drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1056:2: note: Loop condition is false. Execution continues on line 1063 while (page[1].shift) ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1063:2: note: Loop condition is false. Execution continues on line 1065 for (levels = 0, desc = page->desc; desc->bits; desc++, levels++) ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1068:6: note: Taking false branch if (WARN_ON(levels > NVKM_VMM_LEVELS_MAX)) ^ include/asm-generic/bug.h:120:2: note: expanded from macro 'WARN_ON' if (unlikely(__ret_warn_on)) \ ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1068:2: note: Taking false branch if (WARN_ON(levels > NVKM_VMM_LEVELS_MAX)) ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1072:41: note: Passing null pointer value via 3rd parameter 'page' vmm->pd = nvkm_vmm_pt_new(desc, false, NULL); ^ include/linux/stddef.h:8:14: note: expanded from macro 'NULL' #define NULL ((void *)0) ^~~~~~~~~~~ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:1072:12: note: Calling 'nvkm_vmm_pt_new' vmm->pd = nvkm_vmm_pt_new(desc, false, NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:47:6: note: Assuming field 'type' is > PGT if (desc->type > PGT) { ^~~~~~~~~~~~~~~~ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:47:2: note: Taking true branch if (desc->type > PGT) { ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:48:7: note: Assuming field 'type' is equal to SPT if (desc->type == SPT) { ^~~~~~~~~~~~~~~~~ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:48:3: note: Taking true branch if (desc->type == SPT) { ^ drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:49:39: note: Dereference of null pointer const struct nvkm_vmm_desc *pair = page[-1].desc; ^~~~~~~~~~~~~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 8 warnings generated. >> fs/fuse/ioctl.c:471:3: warning: Value stored to 'newdax' is never read >> [clang-analyzer-deadcode.DeadStores] newdax = flags & FS_DAX_FL; ^ ~~~~~~~~~~~~~~~~~ fs/fuse/ioctl.c:471:3: note: Value stored to 'newdax' is never read newdax = flags & FS_DAX_FL; ^ ~~~~~~~~~~~~~~~~~ fs/fuse/ioctl.c:482:3: warning: Value stored to 'newdax' is never read [clang-analyzer-deadcode.DeadStores] newdax = fa->fsx_xflags & FS_XFLAG_DAX; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/fuse/ioctl.c:482:3: note: Value stored to 'newdax' is never read newdax = fa->fsx_xflags & FS_XFLAG_DAX; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 8 warnings generated. fs/fuse/cuse.c:359:2: warning: Value stored to 'rc' is never read [clang-analyzer-deadcode.DeadStores] rc = -ENOMEM; ^ ~~~~~~~ fs/fuse/cuse.c:359:2: note: Value stored to 'rc' is never read rc = -ENOMEM; ^ ~~~~~~~ fs/fuse/cuse.c:386:2: warning: Value stored to 'rc' is never read [clang-analyzer-deadcode.DeadStores] rc = -ENOMEM; ^ ~~~~~~~ fs/fuse/cuse.c:386:2: note: Value stored to 'rc' is never read rc = -ENOMEM; ^ ~~~~~~~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 8 warnings generated. fs/fuse/virtio_fs.c:912:2: warning: Attempt to free released memory [clang-analyzer-unix.Malloc] kfree(fs->vqs); ^~~~~~~~~~~~~~ fs/fuse/virtio_fs.c:879:6: note: Assuming 'fs' is non-null if (!fs) ^~~ fs/fuse/virtio_fs.c:879:2: note: Taking false branch if (!fs) ^ fs/fuse/virtio_fs.c:885:6: note: 'ret' is >= 0 if (ret < 0) ^~~ fs/fuse/virtio_fs.c:885:2: note: Taking false branch if (ret < 0) ^ fs/fuse/virtio_fs.c:888:8: note: Calling 'virtio_fs_setup_vqs' ret = virtio_fs_setup_vqs(vdev, fs); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/fuse/virtio_fs.c:691:2: note: Loop condition is false. Exiting loop virtio_cread_le(vdev, struct virtio_fs_config, num_request_queues, ^ include/linux/virtio_config.h:396:3: note: expanded from macro 'virtio_cread_le' might_sleep(); \ ^ include/linux/kernel.h:119:2: note: expanded from macro 'might_sleep' do { __might_sleep(__FILE__, __LINE__, 0); might_resched(); } while (0) ^ fs/fuse/virtio_fs.c:691:2: note: Control jumps to 'case 4:' at line 691 virtio_cread_le(vdev, struct virtio_fs_config, num_request_queues, ^ include/linux/virtio_config.h:400:3: note: expanded from macro 'virtio_cread_le' switch (sizeof(virtio_cread_v)) { \ ^ fs/fuse/virtio_fs.c:691:2: note: Execution continues on line 691 virtio_cread_le(vdev, struct virtio_fs_config, num_request_queues, ^ include/linux/virtio_config.h:408:4: note: expanded from macro 'virtio_cread_le' break; \ ^ fs/fuse/virtio_fs.c:691:2: note: Loop condition is false. Exiting loop virtio_cread_le(vdev, struct virtio_fs_config, num_request_queues, ^ include/linux/virtio_config.h:393:2: note: expanded from macro 'virtio_cread_le' do { \ ^ fs/fuse/virtio_fs.c:693:6: note: Assuming field 'num_request_queues' is not equal to 0 if (fs->num_request_queues == 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/fuse/virtio_fs.c:693:2: note: Taking false branch if (fs->num_request_queues == 0) ^ fs/fuse/virtio_fs.c:698:6: note: Assuming field 'vqs' is non-null if (!fs->vqs) ^~~~~~~~ fs/fuse/virtio_fs.c:698:2: note: Taking false branch if (!fs->vqs) ^ fs/fuse/virtio_fs.c:705:6: note: Assuming 'vqs' is non-null if (!vqs || !callbacks || !names) { ^~~~ fs/fuse/virtio_fs.c:705:6: note: Left side of '||' is false fs/fuse/virtio_fs.c:705:14: note: Assuming 'callbacks' is non-null if (!vqs || !callbacks || !names) { ^~~~~~~~~~ fs/fuse/virtio_fs.c:705:6: note: Left side of '||' is false if (!vqs || !callbacks || !names) { ^ fs/fuse/virtio_fs.c:705:28: note: Assuming 'names' is non-null if (!vqs || !callbacks || !names) { ^~~~~~ fs/fuse/virtio_fs.c:705:2: note: Taking false branch vim +/newdax +471 fs/fuse/ioctl.c 72227eac177dd1 Miklos Szeredi 2021-04-08 455 72227eac177dd1 Miklos Szeredi 2021-04-08 456 int fuse_fileattr_set(struct user_namespace *mnt_userns, 72227eac177dd1 Miklos Szeredi 2021-04-08 457 struct dentry *dentry, struct fileattr *fa) 72227eac177dd1 Miklos Szeredi 2021-04-08 458 { 72227eac177dd1 Miklos Szeredi 2021-04-08 459 struct inode *inode = d_inode(dentry); 72227eac177dd1 Miklos Szeredi 2021-04-08 460 struct fuse_file *ff; 72227eac177dd1 Miklos Szeredi 2021-04-08 461 unsigned int flags = fa->flags; 72227eac177dd1 Miklos Szeredi 2021-04-08 462 struct fsxattr xfa; a6ac625f19c4c4 Jeffle Xu 2021-07-16 463 bool newdax; 72227eac177dd1 Miklos Szeredi 2021-04-08 464 int err; 72227eac177dd1 Miklos Szeredi 2021-04-08 465 72227eac177dd1 Miklos Szeredi 2021-04-08 466 ff = fuse_priv_ioctl_prepare(inode); 72227eac177dd1 Miklos Szeredi 2021-04-08 467 if (IS_ERR(ff)) 72227eac177dd1 Miklos Szeredi 2021-04-08 468 return PTR_ERR(ff); 72227eac177dd1 Miklos Szeredi 2021-04-08 469 72227eac177dd1 Miklos Szeredi 2021-04-08 470 if (fa->flags_valid) { a6ac625f19c4c4 Jeffle Xu 2021-07-16 @471 newdax = flags & FS_DAX_FL; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
