CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Amir Goldstein <[email protected]>

Hi Amir,

I love your patch! Perhaps something to improve:

[auto build test WARNING on ext3/fsnotify]
[also build test WARNING on linus/master v5.14-rc4 next-20210803]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Amir-Goldstein/Performance-optimization-for-no-fsnotify-marks/20210804-020522
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git 
fsnotify
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: x86_64-randconfig-m001-20210803 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
fs/notify/mark.c:201 fsnotify_get_sb_connectors() error: uninitialized symbol 
'sb'.

vim +/sb +201 fs/notify/mark.c

945579ec988af6 Amir Goldstein 2021-08-03  186  
945579ec988af6 Amir Goldstein 2021-08-03  187  static void 
fsnotify_get_sb_connectors(struct fsnotify_mark_connector *conn)
945579ec988af6 Amir Goldstein 2021-08-03  188  {
945579ec988af6 Amir Goldstein 2021-08-03  189   struct super_block *sb;
945579ec988af6 Amir Goldstein 2021-08-03  190  
945579ec988af6 Amir Goldstein 2021-08-03  191   if (conn->type == 
FSNOTIFY_OBJ_TYPE_DETACHED)
945579ec988af6 Amir Goldstein 2021-08-03  192           return;
945579ec988af6 Amir Goldstein 2021-08-03  193  
945579ec988af6 Amir Goldstein 2021-08-03  194   if (conn->type == 
FSNOTIFY_OBJ_TYPE_INODE)
945579ec988af6 Amir Goldstein 2021-08-03  195           sb = 
fsnotify_conn_inode(conn)->i_sb;
945579ec988af6 Amir Goldstein 2021-08-03  196   else if (conn->type == 
FSNOTIFY_OBJ_TYPE_VFSMOUNT)
945579ec988af6 Amir Goldstein 2021-08-03  197           sb = 
fsnotify_conn_mount(conn)->mnt.mnt_sb;
945579ec988af6 Amir Goldstein 2021-08-03  198   else if (conn->type == 
FSNOTIFY_OBJ_TYPE_SB)
945579ec988af6 Amir Goldstein 2021-08-03  199           sb = 
fsnotify_conn_sb(conn);
945579ec988af6 Amir Goldstein 2021-08-03  200  
945579ec988af6 Amir Goldstein 2021-08-03 @201   
atomic_long_inc(&sb->s_fsnotify_connectors);
945579ec988af6 Amir Goldstein 2021-08-03  202  }
945579ec988af6 Amir Goldstein 2021-08-03  203  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to