CC: [email protected] CC: [email protected] TO: Peter Zijlstra <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/wip-freezer head: cdba87e1faac40e0a5c8c8a8e9ef0ae37a2903df commit: cdba87e1faac40e0a5c8c8a8e9ef0ae37a2903df [5/5] freezer,sched: Rewrite core freezer logic :::::: branch date: 7 hours ago :::::: commit date: 7 hours ago compiler: microblaze-linux-gcc (GCC) 10.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> kernel/freezer.c:110:7: warning: Local variable frozen shadows outer >> function [shadowFunction] bool frozen = false; ^ kernel/freezer.c:57:6: note: Shadowed declaration bool frozen(struct task_struct *p) ^ kernel/freezer.c:110:7: note: Shadow variable bool frozen = false; ^ vim +110 kernel/freezer.c 8174f1503f4bf7 Matt Helsley 2008-10-18 104 cdba87e1faac40 Peter Zijlstra 2021-06-01 105 /* See set_special_state(); serializes against ttwu() */ cdba87e1faac40 Peter Zijlstra 2021-06-01 106 static bool __freeze_task(struct task_struct *p) cdba87e1faac40 Peter Zijlstra 2021-06-01 107 { cdba87e1faac40 Peter Zijlstra 2021-06-01 108 unsigned long flags; cdba87e1faac40 Peter Zijlstra 2021-06-01 109 unsigned int state; cdba87e1faac40 Peter Zijlstra 2021-06-01 @110 bool frozen = false; cdba87e1faac40 Peter Zijlstra 2021-06-01 111 cdba87e1faac40 Peter Zijlstra 2021-06-01 112 raw_spin_lock_irqsave(&p->pi_lock, flags); cdba87e1faac40 Peter Zijlstra 2021-06-01 113 state = READ_ONCE(p->__state); cdba87e1faac40 Peter Zijlstra 2021-06-01 114 if (state & (TASK_FREEZABLE|__TASK_STOPPED|__TASK_TRACED)) { cdba87e1faac40 Peter Zijlstra 2021-06-01 115 /* cdba87e1faac40 Peter Zijlstra 2021-06-01 116 * Only TASK_NORMAL can be augmented with TASK_FREEZABLE, cdba87e1faac40 Peter Zijlstra 2021-06-01 117 * since they can suffer spurious wakeups. cdba87e1faac40 Peter Zijlstra 2021-06-01 118 */ cdba87e1faac40 Peter Zijlstra 2021-06-01 119 if (state & TASK_FREEZABLE) cdba87e1faac40 Peter Zijlstra 2021-06-01 120 WARN_ON_ONCE(!(state & TASK_NORMAL)); cdba87e1faac40 Peter Zijlstra 2021-06-01 121 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
