CC: [email protected] In-Reply-To: <59c069e3890f3cbc7fa425cdcf756d241a8bfc92.1628690222.git.naohiro.a...@wdc.com> References: <59c069e3890f3cbc7fa425cdcf756d241a8bfc92.1628690222.git.naohiro.a...@wdc.com> TO: Naohiro Aota <[email protected]> TO: Josef Bacik <[email protected]> TO: David Sterba <[email protected]> CC: [email protected] CC: Naohiro Aota <[email protected]>
Hi Naohiro, I love your patch! Perhaps something to improve: [auto build test WARNING on kdave/for-next] [cannot apply to v5.14-rc5 next-20210811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Naohiro-Aota/ZNS-Support-for-Btrfs/20210811-222302 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next :::::: branch date: 8 hours ago :::::: commit date: 8 hours ago config: i386-randconfig-m021-20210810 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: fs/btrfs/zoned.c:1956 btrfs_zone_finish_endio() error: uninitialized symbol 'ret'. Old smatch warnings: fs/btrfs/zoned.c:165 sb_zone_number() error: uninitialized symbol 'zone'. fs/btrfs/zoned.c:1406 btrfs_load_block_group_zone_info() error: uninitialized symbol 'ret'. vim +/ret +1956 fs/btrfs/zoned.c ccecd271dc2436 Naohiro Aota 2021-08-11 1900 ccecd271dc2436 Naohiro Aota 2021-08-11 1901 int btrfs_zone_finish_endio(struct btrfs_fs_info *fs_info, u64 logical, ccecd271dc2436 Naohiro Aota 2021-08-11 1902 u64 length) ccecd271dc2436 Naohiro Aota 2021-08-11 1903 { ccecd271dc2436 Naohiro Aota 2021-08-11 1904 struct btrfs_block_group *block_group; ccecd271dc2436 Naohiro Aota 2021-08-11 1905 struct map_lookup *map; ccecd271dc2436 Naohiro Aota 2021-08-11 1906 struct btrfs_device *device; ccecd271dc2436 Naohiro Aota 2021-08-11 1907 u64 physical; ccecd271dc2436 Naohiro Aota 2021-08-11 1908 int ret; ccecd271dc2436 Naohiro Aota 2021-08-11 1909 ccecd271dc2436 Naohiro Aota 2021-08-11 1910 if (!btrfs_is_zoned(fs_info)) ccecd271dc2436 Naohiro Aota 2021-08-11 1911 return 0; ccecd271dc2436 Naohiro Aota 2021-08-11 1912 ccecd271dc2436 Naohiro Aota 2021-08-11 1913 block_group = btrfs_lookup_block_group(fs_info, logical); ccecd271dc2436 Naohiro Aota 2021-08-11 1914 ASSERT(block_group); ccecd271dc2436 Naohiro Aota 2021-08-11 1915 ccecd271dc2436 Naohiro Aota 2021-08-11 1916 if (logical + length < block_group->start + block_group->zone_capacity) { ccecd271dc2436 Naohiro Aota 2021-08-11 1917 ret = 0; ccecd271dc2436 Naohiro Aota 2021-08-11 1918 goto out; ccecd271dc2436 Naohiro Aota 2021-08-11 1919 } ccecd271dc2436 Naohiro Aota 2021-08-11 1920 ccecd271dc2436 Naohiro Aota 2021-08-11 1921 spin_lock(&block_group->lock); ccecd271dc2436 Naohiro Aota 2021-08-11 1922 ccecd271dc2436 Naohiro Aota 2021-08-11 1923 if (!block_group->zone_is_active) { ccecd271dc2436 Naohiro Aota 2021-08-11 1924 spin_unlock(&block_group->lock); ccecd271dc2436 Naohiro Aota 2021-08-11 1925 ret = 0; ccecd271dc2436 Naohiro Aota 2021-08-11 1926 goto out; ccecd271dc2436 Naohiro Aota 2021-08-11 1927 } ccecd271dc2436 Naohiro Aota 2021-08-11 1928 ccecd271dc2436 Naohiro Aota 2021-08-11 1929 block_group->zone_is_active = 0; ccecd271dc2436 Naohiro Aota 2021-08-11 1930 /* We should have consumed all the free space */ ccecd271dc2436 Naohiro Aota 2021-08-11 1931 ASSERT(block_group->alloc_offset == block_group->zone_capacity); ccecd271dc2436 Naohiro Aota 2021-08-11 1932 ASSERT(block_group->free_space_ctl->free_space == 0); ccecd271dc2436 Naohiro Aota 2021-08-11 1933 btrfs_clear_treelog_bg(block_group); ccecd271dc2436 Naohiro Aota 2021-08-11 1934 spin_unlock(&block_group->lock); ccecd271dc2436 Naohiro Aota 2021-08-11 1935 ccecd271dc2436 Naohiro Aota 2021-08-11 1936 map = block_group->physical_map; ccecd271dc2436 Naohiro Aota 2021-08-11 1937 device = map->stripes[0].dev; ccecd271dc2436 Naohiro Aota 2021-08-11 1938 physical = map->stripes[0].physical; ccecd271dc2436 Naohiro Aota 2021-08-11 1939 ccecd271dc2436 Naohiro Aota 2021-08-11 1940 if (!device->zone_info->max_active_zones) { ccecd271dc2436 Naohiro Aota 2021-08-11 1941 ret = 0; ccecd271dc2436 Naohiro Aota 2021-08-11 1942 goto out; ccecd271dc2436 Naohiro Aota 2021-08-11 1943 } ccecd271dc2436 Naohiro Aota 2021-08-11 1944 ccecd271dc2436 Naohiro Aota 2021-08-11 1945 btrfs_dev_clear_active_zone(device, physical); ccecd271dc2436 Naohiro Aota 2021-08-11 1946 ccecd271dc2436 Naohiro Aota 2021-08-11 1947 spin_lock(&fs_info->zone_active_bgs_lock); ccecd271dc2436 Naohiro Aota 2021-08-11 1948 ASSERT(!list_empty(&block_group->active_bg_list)); ccecd271dc2436 Naohiro Aota 2021-08-11 1949 list_del_init(&block_group->active_bg_list); ccecd271dc2436 Naohiro Aota 2021-08-11 1950 spin_unlock(&fs_info->zone_active_bgs_lock); ccecd271dc2436 Naohiro Aota 2021-08-11 1951 ccecd271dc2436 Naohiro Aota 2021-08-11 1952 btrfs_put_block_group(block_group); ccecd271dc2436 Naohiro Aota 2021-08-11 1953 ccecd271dc2436 Naohiro Aota 2021-08-11 1954 out: ccecd271dc2436 Naohiro Aota 2021-08-11 1955 btrfs_put_block_group(block_group); ccecd271dc2436 Naohiro Aota 2021-08-11 @1956 return ret; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
