CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Gilad Naaman <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected]
Hi Gilad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on net/master linus/master sparc-next/master v5.14-rc6 next-20210817] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Gilad-Naaman/net-Improve-perf-of-bond-vlans-modification/20210817-191254 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e3faa49bcecdfcc80e94dd75709d6acb1a5d89f6 :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago config: x86_64-randconfig-m001-20210816 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: net/core/dev_addr_lists.c:57 tree_address_lookup() error: uninitialized symbol '_parent'. vim +/_parent +57 net/core/dev_addr_lists.c a748ee2426817a Jiri Pirko 2010-04-01 14 2ef1ec54140b77 Gilad Naaman 2021-08-17 15 /* Lookup for an address in the list using the rbtree. 2ef1ec54140b77 Gilad Naaman 2021-08-17 16 * The return value is always a valid pointer. 2ef1ec54140b77 Gilad Naaman 2021-08-17 17 * If the address exists, `*ret` is non-null and the address can be retrieved using 2ef1ec54140b77 Gilad Naaman 2021-08-17 18 * 2ef1ec54140b77 Gilad Naaman 2021-08-17 19 * container_of(*ret, struct netdev_hw_addr, node) 2ef1ec54140b77 Gilad Naaman 2021-08-17 20 * 2ef1ec54140b77 Gilad Naaman 2021-08-17 21 * Otherwise, `ret` can be used with `parent` as an insertion point 2ef1ec54140b77 Gilad Naaman 2021-08-17 22 * when calling `insert_address_to_tree`. 2ef1ec54140b77 Gilad Naaman 2021-08-17 23 * 2ef1ec54140b77 Gilad Naaman 2021-08-17 24 * Must only be called when holding the netdevice's spinlock. 2ef1ec54140b77 Gilad Naaman 2021-08-17 25 * 2ef1ec54140b77 Gilad Naaman 2021-08-17 26 * @ignore_zero_addr_type if true and `addr_type` is zero, 2ef1ec54140b77 Gilad Naaman 2021-08-17 27 * disregard addr_type when matching; 2ef1ec54140b77 Gilad Naaman 2021-08-17 28 */ 2ef1ec54140b77 Gilad Naaman 2021-08-17 29 static struct rb_node **tree_address_lookup(struct netdev_hw_addr_list *list, 2ef1ec54140b77 Gilad Naaman 2021-08-17 30 const unsigned char *addr, 2ef1ec54140b77 Gilad Naaman 2021-08-17 31 int addr_len, 2ef1ec54140b77 Gilad Naaman 2021-08-17 32 unsigned char addr_type, 2ef1ec54140b77 Gilad Naaman 2021-08-17 33 bool ignore_zero_addr_type, 2ef1ec54140b77 Gilad Naaman 2021-08-17 34 struct rb_node **parent) 2ef1ec54140b77 Gilad Naaman 2021-08-17 35 { 2ef1ec54140b77 Gilad Naaman 2021-08-17 36 struct rb_node **node = &list->tree_root.rb_node, *_parent; 2ef1ec54140b77 Gilad Naaman 2021-08-17 37 2ef1ec54140b77 Gilad Naaman 2021-08-17 38 while (*node) 2ef1ec54140b77 Gilad Naaman 2021-08-17 39 { 2ef1ec54140b77 Gilad Naaman 2021-08-17 40 struct netdev_hw_addr *data = container_of(*node, struct netdev_hw_addr, node); 2ef1ec54140b77 Gilad Naaman 2021-08-17 41 int result; 2ef1ec54140b77 Gilad Naaman 2021-08-17 42 2ef1ec54140b77 Gilad Naaman 2021-08-17 43 result = memcmp(addr, data->addr, addr_len); 2ef1ec54140b77 Gilad Naaman 2021-08-17 44 if (!result && (ignore_zero_addr_type && !addr_type)) 2ef1ec54140b77 Gilad Naaman 2021-08-17 45 result = memcmp(&addr_type, &data->type, sizeof(addr_type)); 2ef1ec54140b77 Gilad Naaman 2021-08-17 46 2ef1ec54140b77 Gilad Naaman 2021-08-17 47 _parent = *node; 2ef1ec54140b77 Gilad Naaman 2021-08-17 48 if (result < 0) 2ef1ec54140b77 Gilad Naaman 2021-08-17 49 node = &(*node)->rb_left; 2ef1ec54140b77 Gilad Naaman 2021-08-17 50 else if (result > 0) 2ef1ec54140b77 Gilad Naaman 2021-08-17 51 node = &(*node)->rb_right; 2ef1ec54140b77 Gilad Naaman 2021-08-17 52 else 2ef1ec54140b77 Gilad Naaman 2021-08-17 53 break; 2ef1ec54140b77 Gilad Naaman 2021-08-17 54 } 2ef1ec54140b77 Gilad Naaman 2021-08-17 55 2ef1ec54140b77 Gilad Naaman 2021-08-17 56 if (parent) 2ef1ec54140b77 Gilad Naaman 2021-08-17 @57 *parent = _parent; 2ef1ec54140b77 Gilad Naaman 2021-08-17 58 return node; 2ef1ec54140b77 Gilad Naaman 2021-08-17 59 } 2ef1ec54140b77 Gilad Naaman 2021-08-17 60 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
