CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Chris Morgan <[email protected]> TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: Chris Morgan <[email protected]>
Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on lee-mfd/for-mfd-next] [also build test WARNING on rockchip/for-next power-supply/for-next v5.14-rc7 next-20210824] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chris-Morgan/power-supply-Add-Support-for-RK817-Charger/20210824-121243 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next :::::: branch date: 11 hours ago :::::: commit date: 11 hours ago config: h8300-randconfig-m031-20210824 (attached as .config) compiler: h8300-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/power/supply/rk817_charger.c:121 rk817_chg_cur_to_reg() warn: signedness bug returning '(-22)' vim +121 drivers/power/supply/rk817_charger.c e56667b68e1bb8 Chris Morgan 2021-08-23 85 e56667b68e1bb8 Chris Morgan 2021-08-23 86 /* ADC coefficients extracted from BSP kernel */ e56667b68e1bb8 Chris Morgan 2021-08-23 87 #define ADC_TO_CURRENT(adc_value, res_div) \ e56667b68e1bb8 Chris Morgan 2021-08-23 88 (adc_value * 172 / res_div) e56667b68e1bb8 Chris Morgan 2021-08-23 89 e56667b68e1bb8 Chris Morgan 2021-08-23 90 #define CURRENT_TO_ADC(current, samp_res) \ e56667b68e1bb8 Chris Morgan 2021-08-23 91 (current * samp_res / 172) e56667b68e1bb8 Chris Morgan 2021-08-23 92 e56667b68e1bb8 Chris Morgan 2021-08-23 93 #define CHARGE_TO_ADC(capacity, res_div) \ e56667b68e1bb8 Chris Morgan 2021-08-23 94 (capacity * res_div * 3600 / 172 * 1000) e56667b68e1bb8 Chris Morgan 2021-08-23 95 e56667b68e1bb8 Chris Morgan 2021-08-23 96 #define ADC_TO_CHARGE_UAH(adc_value, res_div) \ e56667b68e1bb8 Chris Morgan 2021-08-23 97 (adc_value / 3600 * 172 / res_div) e56667b68e1bb8 Chris Morgan 2021-08-23 98 e56667b68e1bb8 Chris Morgan 2021-08-23 99 #define ADC_TO_CAPACITY(adc_value, res_div) \ e56667b68e1bb8 Chris Morgan 2021-08-23 100 (adc_value / 1000 * 172 / 3600 / res_div) e56667b68e1bb8 Chris Morgan 2021-08-23 101 e56667b68e1bb8 Chris Morgan 2021-08-23 102 static u8 rk817_chg_cur_to_reg(u32 chg_cur_ma) e56667b68e1bb8 Chris Morgan 2021-08-23 103 { e56667b68e1bb8 Chris Morgan 2021-08-23 104 if (chg_cur_ma > 3500) e56667b68e1bb8 Chris Morgan 2021-08-23 105 return CHG_3_5A; e56667b68e1bb8 Chris Morgan 2021-08-23 106 else if (chg_cur_ma > 3000) e56667b68e1bb8 Chris Morgan 2021-08-23 107 return CHG_3A; e56667b68e1bb8 Chris Morgan 2021-08-23 108 else if (chg_cur_ma > 2750) e56667b68e1bb8 Chris Morgan 2021-08-23 109 return CHG_2_75A; e56667b68e1bb8 Chris Morgan 2021-08-23 110 else if (chg_cur_ma > 2500) e56667b68e1bb8 Chris Morgan 2021-08-23 111 return CHG_2_5A; e56667b68e1bb8 Chris Morgan 2021-08-23 112 else if (chg_cur_ma > 2000) e56667b68e1bb8 Chris Morgan 2021-08-23 113 return CHG_2A; e56667b68e1bb8 Chris Morgan 2021-08-23 114 else if (chg_cur_ma > 1500) e56667b68e1bb8 Chris Morgan 2021-08-23 115 return CHG_1_5A; e56667b68e1bb8 Chris Morgan 2021-08-23 116 else if (chg_cur_ma > 1000) e56667b68e1bb8 Chris Morgan 2021-08-23 117 return CHG_1A; e56667b68e1bb8 Chris Morgan 2021-08-23 118 else if (chg_cur_ma > 500) e56667b68e1bb8 Chris Morgan 2021-08-23 119 return CHG_0_5A; e56667b68e1bb8 Chris Morgan 2021-08-23 120 else e56667b68e1bb8 Chris Morgan 2021-08-23 @121 return -EINVAL; e56667b68e1bb8 Chris Morgan 2021-08-23 122 } e56667b68e1bb8 Chris Morgan 2021-08-23 123 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
