CC: [email protected] In-Reply-To: <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adam...@nokia.com> References: <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adam...@nokia.com> TO: Krzysztof Adamski <[email protected]> TO: Guenter Roeck <[email protected]> TO: Jean Delvare <[email protected]> CC: Rob Herring <[email protected]> CC: [email protected] CC: [email protected]
Hi Krzysztof, I love your patch! Perhaps something to improve: [auto build test WARNING on groeck-staging/hwmon-next] [also build test WARNING on next-20211012] [cannot apply to robh/for-next v5.15-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next :::::: branch date: 13 hours ago :::::: commit date: 13 hours ago config: i386-randconfig-m031-20211012 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/hwmon/tmp421.c:178 tmp421_enable_channels() error: uninitialized symbol 'err'. vim +/err +178 drivers/hwmon/tmp421.c 9410700b881f86 Andre Prendel 2009-09-15 167 4a0f8262fe071b Krzysztof Adamski 2021-10-12 168 static int tmp421_enable_channels(struct tmp421_data *data) 4a0f8262fe071b Krzysztof Adamski 2021-10-12 169 { 4a0f8262fe071b Krzysztof Adamski 2021-10-12 170 int err; 4a0f8262fe071b Krzysztof Adamski 2021-10-12 171 struct i2c_client *client = data->client; 4a0f8262fe071b Krzysztof Adamski 2021-10-12 172 struct device *dev = &client->dev; 4a0f8262fe071b Krzysztof Adamski 2021-10-12 173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2); 4a0f8262fe071b Krzysztof Adamski 2021-10-12 174 int i; 4a0f8262fe071b Krzysztof Adamski 2021-10-12 175 4a0f8262fe071b Krzysztof Adamski 2021-10-12 176 if (cfg < 0) { 4a0f8262fe071b Krzysztof Adamski 2021-10-12 177 dev_err(dev, "error reading register, can't disable channels\n"); 4a0f8262fe071b Krzysztof Adamski 2021-10-12 @178 return err; 4a0f8262fe071b Krzysztof Adamski 2021-10-12 179 } 4a0f8262fe071b Krzysztof Adamski 2021-10-12 180 4a0f8262fe071b Krzysztof Adamski 2021-10-12 181 cfg &= ~TMP421_CONFIG_REG_REN_MASK; 4a0f8262fe071b Krzysztof Adamski 2021-10-12 182 for (i = 0; i < data->channels; i++) 4a0f8262fe071b Krzysztof Adamski 2021-10-12 183 if (data->channel[i].enabled) 4a0f8262fe071b Krzysztof Adamski 2021-10-12 184 cfg |= TMP421_CONFIG_REG_REN(i); 4a0f8262fe071b Krzysztof Adamski 2021-10-12 185 4a0f8262fe071b Krzysztof Adamski 2021-10-12 186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg); 4a0f8262fe071b Krzysztof Adamski 2021-10-12 187 if (err < 0) 4a0f8262fe071b Krzysztof Adamski 2021-10-12 188 dev_err(dev, "error writing register, can't disable channels\n"); 4a0f8262fe071b Krzysztof Adamski 2021-10-12 189 4a0f8262fe071b Krzysztof Adamski 2021-10-12 190 return err; 4a0f8262fe071b Krzysztof Adamski 2021-10-12 191 } 4a0f8262fe071b Krzysztof Adamski 2021-10-12 192 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
