CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Peter Oskolkov <[email protected]>
TO: Peter Zijlstra <[email protected]>
TO: Ingo Molnar <[email protected]>
TO: Thomas Gleixner <[email protected]>
TO: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>
TO: Dave Hansen <[email protected]>
TO: Andy Lutomirski <[email protected]>
TO: [email protected]
TO: [email protected]
CC: Paul Turner <[email protected]>

Hi Peter,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on hnaz-mm/master]
[cannot apply to tip/master tip/x86/core arnd-asm-generic/master linus/master 
tip/x86/asm tip/core/entry v5.15-rc5 next-20211013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Peter-Oskolkov/sched-mm-x86-uaccess-implement-User-Managed-Concurrency-Groups/20211013-072710
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 
b2d5b9cec60fecc72a13191c2c6c05acf60975a5
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago
config: x86_64-randconfig-m001-20211013 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
kernel/sched/core.c:6294 sched_update_worker() warn: bitwise AND condition is 
false here
kernel/sched/core.c:6272 sched_submit_work() warn: bitwise AND condition is 
false here

vim +6294 kernel/sched/core.c

9af6528ee9b682 kernel/sched/core.c Peter Zijlstra            2016-09-13  6256  
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6257  
static inline void sched_submit_work(struct task_struct *tsk)
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6258  {
c1cecf884ad748 kernel/sched/core.c Sebastian Andrzej Siewior 2020-08-19  6259   
unsigned int task_flags;
c1cecf884ad748 kernel/sched/core.c Sebastian Andrzej Siewior 2020-08-19  6260  
b03fbd4ff24c5f kernel/sched/core.c Peter Zijlstra            2021-06-11  6261   
if (task_is_running(tsk))
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6262   
        return;
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6263  
c1cecf884ad748 kernel/sched/core.c Sebastian Andrzej Siewior 2020-08-19  6264   
task_flags = tsk->flags;
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6265   
/*
b945efcdd07d86 kernel/sched/core.c Thomas Gleixner           2021-09-29  6266   
 * If a worker goes to sleep, notify and ask workqueue whether it
b945efcdd07d86 kernel/sched/core.c Thomas Gleixner           2021-09-29  6267   
 * wants to wake up a task to maintain concurrency.
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6268   
 */
0dcffc800cf354 kernel/sched/core.c Peter Oskolkov            2021-10-12  6269   
if (task_flags & (PF_WQ_WORKER | PF_IO_WORKER | PF_UMCG_WORKER)) {
c1cecf884ad748 kernel/sched/core.c Sebastian Andrzej Siewior 2020-08-19  6270   
        if (task_flags & PF_WQ_WORKER)
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6271   
                wq_worker_sleeping(tsk);
0dcffc800cf354 kernel/sched/core.c Peter Oskolkov            2021-10-12 @6272   
        else if (task_flags & PF_UMCG_WORKER)
0dcffc800cf354 kernel/sched/core.c Peter Oskolkov            2021-10-12  6273   
                umcg_wq_worker_sleeping(tsk);
771b53d033e866 kernel/sched/core.c Jens Axboe                2019-10-22  6274   
        else
771b53d033e866 kernel/sched/core.c Jens Axboe                2019-10-22  6275   
                io_wq_worker_sleeping(tsk);
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6276   
}
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6277  
b0fdc01354f45d kernel/sched/core.c Sebastian Andrzej Siewior 2019-08-16  6278   
if (tsk_is_pi_blocked(tsk))
b0fdc01354f45d kernel/sched/core.c Sebastian Andrzej Siewior 2019-08-16  6279   
        return;
b0fdc01354f45d kernel/sched/core.c Sebastian Andrzej Siewior 2019-08-16  6280  
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6281   
/*
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6282   
 * If we are going to sleep and we have plugged IO queued,
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6283   
 * make sure to submit it to avoid deadlocks.
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6284   
 */
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6285   
if (blk_needs_flush_plug(tsk))
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6286   
        blk_schedule_flush_plug(tsk);
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6287  }
9c40cef2b799f9 kernel/sched.c      Thomas Gleixner           2011-06-22  6288  
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6289  
static void sched_update_worker(struct task_struct *tsk)
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6290  {
0dcffc800cf354 kernel/sched/core.c Peter Oskolkov            2021-10-12  6291   
if (tsk->flags & (PF_WQ_WORKER | PF_IO_WORKER | PF_UMCG_WORKER)) {
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6292   
        if (tsk->flags & PF_WQ_WORKER)
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6293   
                wq_worker_running(tsk);
0dcffc800cf354 kernel/sched/core.c Peter Oskolkov            2021-10-12 @6294   
        else if (tsk->flags & PF_UMCG_WORKER)
0dcffc800cf354 kernel/sched/core.c Peter Oskolkov            2021-10-12  6295   
                umcg_wq_worker_running(tsk);
771b53d033e866 kernel/sched/core.c Jens Axboe                2019-10-22  6296   
        else
771b53d033e866 kernel/sched/core.c Jens Axboe                2019-10-22  6297   
                io_wq_worker_running(tsk);
771b53d033e866 kernel/sched/core.c Jens Axboe                2019-10-22  6298   
}
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6299  }
6d25be5782e482 kernel/sched/core.c Thomas Gleixner           2019-03-13  6300  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to