CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Sergey Senozhatsky <[email protected]>
TO: Paolo Bonzini <[email protected]>
TO: David Matlack <[email protected]>
CC: Sean Christopherson <[email protected]>
CC: Vitaly Kuznetsov <[email protected]>
CC: Wanpeng Li <[email protected]>
CC: Jim Mattson <[email protected]>
CC: Joerg Roedel <[email protected]>
CC: Suleiman Souhlal <[email protected]>
CC: [email protected]
CC: [email protected]

Hi Sergey,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20211019]
[cannot apply to kvm/queue v5.15-rc6 v5.15-rc5 v5.15-rc4 v5.15-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Sergey-Senozhatsky/kvm-x86-make-PTE_PREFETCH_NUM-tunable/20211019-233356
base:    5b27c149257d83558d9a7fae927be822673be230
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: x86_64-randconfig-m031-20211019 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
arch/x86/kvm/x86.c:5851 kvm_arch_mmu_pte_prefetch() error: uninitialized symbol 
'ret'.

vim +/ret +5851 arch/x86/kvm/x86.c

7d62874f69d7e5 Sergey Senozhatsky 2021-06-06  5834  
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5835  static int 
kvm_arch_mmu_pte_prefetch(struct kvm *kvm, unsigned int num_pages)
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5836  {
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5837      struct kvm_vcpu *vcpu;
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5838      int i, ret;
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5839  
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5840      mutex_lock(&kvm->lock);
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5841      kvm_for_each_vcpu(i, 
vcpu, kvm) {
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5842              ret = 
kvm_set_pte_prefetch(vcpu, num_pages);
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5843              if (ret) {
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5844                      
kvm_err("Failed to set PTE prefetch on VCPU%d: %d\n",
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5845                              
vcpu->vcpu_id, ret);
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5846                      break;
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5847              }
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5848      }
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5849      
mutex_unlock(&kvm->lock);
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5850  
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20 @5851      return ret;
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5852  }
f13d2ba39ce3e5 Sergey Senozhatsky 2021-10-20  5853  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to