CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Andy Shevchenko <[email protected]>
TO: Andy Shevchenko <[email protected]>
TO: [email protected]
TO: [email protected]
CC: "Greg Kroah-Hartman" <[email protected]>
CC: Jiri Slaby <[email protected]>

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-testing]
[cannot apply to v5.15-rc7 next-20211026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/serial-8250_pci-Replace-custom-pci_match_id-implementation/20211025-204752
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git 
tty-testing
:::::: branch date: 26 hours ago
:::::: commit date: 26 hours ago
config: i386-randconfig-m021-20211025 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/tty/serial/8250/8250_pci.c:1273 pci_quatech_init() error: uninitialized 
symbol 'amcc'.

vim +/amcc +1273 drivers/tty/serial/8250/8250_pci.c

55c7c0fdc5aae4 Alan Cox        2012-11-29  1261  
55c7c0fdc5aae4 Alan Cox        2012-11-29  1262  static int 
pci_quatech_init(struct pci_dev *dev)
55c7c0fdc5aae4 Alan Cox        2012-11-29  1263  {
24a32531ba63f4 Andy Shevchenko 2021-10-25  1264         const struct 
pci_device_id *match;
24a32531ba63f4 Andy Shevchenko 2021-10-25  1265         bool amcc;
24a32531ba63f4 Andy Shevchenko 2021-10-25  1266  
24a32531ba63f4 Andy Shevchenko 2021-10-25  1267         match = 
pci_match_id(quatech_cards, dev);
24a32531ba63f4 Andy Shevchenko 2021-10-25  1268         if (match)
24a32531ba63f4 Andy Shevchenko 2021-10-25  1269                 amcc = 
match->driver_data;
24a32531ba63f4 Andy Shevchenko 2021-10-25  1270         else
24a32531ba63f4 Andy Shevchenko 2021-10-25  1271                 pci_err(dev, 
"unknown port type '0x%04X'.\n", dev->device);
24a32531ba63f4 Andy Shevchenko 2021-10-25  1272  
24a32531ba63f4 Andy Shevchenko 2021-10-25 @1273         if (amcc) {
55c7c0fdc5aae4 Alan Cox        2012-11-29  1274                 unsigned long 
base = pci_resource_start(dev, 0);
55c7c0fdc5aae4 Alan Cox        2012-11-29  1275                 if (base) {
55c7c0fdc5aae4 Alan Cox        2012-11-29  1276                         u32 tmp;
1a33e342cf35e5 Anton Wuerfel   2016-01-14  1277  
9c5320f8d7d9a2 Jonathan Woithe 2013-12-09  1278                         
outl(inl(base + 0x38) | 0x00002000, base + 0x38);
55c7c0fdc5aae4 Alan Cox        2012-11-29  1279                         tmp = 
inl(base + 0x3c);
55c7c0fdc5aae4 Alan Cox        2012-11-29  1280                         
outl(tmp | 0x01000000, base + 0x3c);
9c5320f8d7d9a2 Jonathan Woithe 2013-12-09  1281                         
outl(tmp &= ~0x01000000, base + 0x3c);
55c7c0fdc5aae4 Alan Cox        2012-11-29  1282                 }
55c7c0fdc5aae4 Alan Cox        2012-11-29  1283         }
55c7c0fdc5aae4 Alan Cox        2012-11-29  1284         return 0;
55c7c0fdc5aae4 Alan Cox        2012-11-29  1285  }
55c7c0fdc5aae4 Alan Cox        2012-11-29  1286  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to