CC: [email protected] In-Reply-To: <5515956.DvuYhMxLoT@kreacher> References: <5515956.DvuYhMxLoT@kreacher> TO: "Rafael J. Wysocki" <[email protected]>
Hi "Rafael, I love your patch! Perhaps something to improve: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on v5.15] [cannot apply to next-20211110] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Rafael-J-Wysocki/ACPICA-Avoid-evaluating-methods-too-early-during-system-resume/20210929-094420 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next :::::: branch date: 6 weeks ago :::::: commit date: 6 weeks ago config: i386-randconfig-m021-20210928 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/acpi/acpica/hwsleep.c:228 acpi_hw_legacy_wake_prep() error: uninitialized symbol 'status'. vim +/status +228 drivers/acpi/acpica/hwsleep.c ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 165 44f6c01242da4e1 drivers/acpi/hardware/hwsleep.c Robert Moore 2005-04-18 166 /******************************************************************************* ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 167 * 2feec47d4c5f80b drivers/acpi/acpica/hwsleep.c Bob Moore 2012-02-14 168 * FUNCTION: acpi_hw_legacy_wake_prep ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 169 * 2feec47d4c5f80b drivers/acpi/acpica/hwsleep.c Bob Moore 2012-02-14 170 * PARAMETERS: sleep_state - Which sleep state we just exited ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 171 * ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 172 * RETURN: Status ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 173 * c95d47a868f35cd drivers/acpi/hardware/hwsleep.c Rafael J. Wysocki 2008-01-08 174 * DESCRIPTION: Perform the first state of OS-independent ACPI cleanup after a c95d47a868f35cd drivers/acpi/hardware/hwsleep.c Rafael J. Wysocki 2008-01-08 175 * sleep. 2feec47d4c5f80b drivers/acpi/acpica/hwsleep.c Bob Moore 2012-02-14 176 * Called with interrupts ENABLED. ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 177 * ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 178 ******************************************************************************/ 2feec47d4c5f80b drivers/acpi/acpica/hwsleep.c Bob Moore 2012-02-14 179 3f6f49c7854c929 drivers/acpi/acpica/hwsleep.c Len Brown 2012-07-26 180 acpi_status acpi_hw_legacy_wake_prep(u8 sleep_state) ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 181 { ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 182 acpi_status status; ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 183 struct acpi_bit_register_info *sleep_type_reg_info; ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 184 struct acpi_bit_register_info *sleep_enable_reg_info; 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 185 u32 pm1a_control; 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 186 u32 pm1b_control; ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 187 2feec47d4c5f80b drivers/acpi/acpica/hwsleep.c Bob Moore 2012-02-14 188 ACPI_FUNCTION_TRACE(hw_legacy_wake_prep); ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 189 ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 190 /* ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 191 * Set SLP_TYPE and SLP_EN to state S0. ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 192 * This is unclear from the ACPI Spec, but it is required ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 193 * by some machines. ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 194 */ 5fe36d7853aa294 drivers/acpi/acpica/hwsleep.c Rafael J. Wysocki 2021-09-28 195 if (acpi_gbl_sleep_type_a_s0 != ACPI_SLEEP_TYPE_INVALID) { 4be44fcd3bf648b drivers/acpi/hardware/hwsleep.c Len Brown 2005-08-05 196 sleep_type_reg_info = 82d79b86646504a drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 197 acpi_hw_get_bit_register_info(ACPI_BITREG_SLEEP_TYPE); 4be44fcd3bf648b drivers/acpi/hardware/hwsleep.c Len Brown 2005-08-05 198 sleep_enable_reg_info = 4be44fcd3bf648b drivers/acpi/hardware/hwsleep.c Len Brown 2005-08-05 199 acpi_hw_get_bit_register_info(ACPI_BITREG_SLEEP_ENABLE); ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 200 ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 201 /* Get current value of PM1A control */ ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 202 d30dc9abb4aacfd drivers/acpi/hardware/hwsleep.c Alexey Starikovskiy 2007-09-30 203 status = acpi_hw_register_read(ACPI_REGISTER_PM1_CONTROL, 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 204 &pm1a_control); ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 205 if (ACPI_SUCCESS(status)) { 52fc0b026e99b5d drivers/acpi/hardware/hwsleep.c Bob Moore 2006-10-02 206 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 207 /* Clear the SLP_EN and SLP_TYP fields */ ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 208 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 209 pm1a_control &= ~(sleep_type_reg_info->access_bit_mask | 4be44fcd3bf648b drivers/acpi/hardware/hwsleep.c Len Brown 2005-08-05 210 sleep_enable_reg_info-> 4be44fcd3bf648b drivers/acpi/hardware/hwsleep.c Len Brown 2005-08-05 211 access_bit_mask); 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 212 pm1b_control = pm1a_control; ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 213 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 214 /* Insert the SLP_TYP bits */ ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 215 5fe36d7853aa294 drivers/acpi/acpica/hwsleep.c Rafael J. Wysocki 2021-09-28 216 pm1a_control |= (acpi_gbl_sleep_type_a_s0 << d4913dc6d0c680a drivers/acpi/acpica/hwsleep.c Bob Moore 2009-03-06 217 sleep_type_reg_info->bit_position); 5fe36d7853aa294 drivers/acpi/acpica/hwsleep.c Rafael J. Wysocki 2021-09-28 218 pm1b_control |= (acpi_gbl_sleep_type_b_s0 << d4913dc6d0c680a drivers/acpi/acpica/hwsleep.c Bob Moore 2009-03-06 219 sleep_type_reg_info->bit_position); ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 220 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 221 /* Write the control registers and ignore any errors */ ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 222 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 223 (void)acpi_hw_write_pm1_control(pm1a_control, 32c9ef994d91352 drivers/acpi/acpica/hwsleep.c Bob Moore 2009-02-18 224 pm1b_control); ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 225 } ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 226 } ^1da177e4c3f415 drivers/acpi/hardware/hwsleep.c Linus Torvalds 2005-04-16 227 c95d47a868f35cd drivers/acpi/hardware/hwsleep.c Rafael J. Wysocki 2008-01-08 @228 return_ACPI_STATUS(status); c95d47a868f35cd drivers/acpi/hardware/hwsleep.c Rafael J. Wysocki 2008-01-08 229 } c95d47a868f35cd drivers/acpi/hardware/hwsleep.c Rafael J. Wysocki 2008-01-08 230 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
