CC: [email protected]
CC: [email protected]
TO: Melissa Wen <[email protected]>
CC: Iago Toral Quiroga <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   debe436e77c72fcee804fb867f275e6d31aa999c
commit: 07c2a41658c454c8f148c7fd6b0cbcecb78e9829 drm/v3d: alloc and init job in 
one shot
date:   5 weeks ago
:::::: branch date: 4 hours ago
:::::: commit date: 5 weeks ago
config: nios2-randconfig-m031-20211009 (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
drivers/gpu/drm/v3d/v3d_gem.c:470 v3d_job_init() warn: is '*container' large 
enough for 'struct v3d_job'? 1

Old smatch warnings:
arch/nios2/include/asm/thread_info.h:71 current_thread_info() error: 
uninitialized symbol 'sp'.

vim +470 drivers/gpu/drm/v3d/v3d_gem.c

223583dd00a70a Melissa Wen   2021-09-30  453  
a783a09ee76d62 Eric Anholt   2019-04-16  454  static int
a783a09ee76d62 Eric Anholt   2019-04-16  455  v3d_job_init(struct v3d_dev *v3d, 
struct drm_file *file_priv,
07c2a41658c454 Melissa Wen   2021-09-30  456         void **container, size_t 
size, void (*free)(struct kref *ref),
916044fac86232 Daniel Vetter 2021-08-05  457         u32 in_sync, enum 
v3d_queue queue)
a783a09ee76d62 Eric Anholt   2019-04-16  458  {
916044fac86232 Daniel Vetter 2021-08-05  459    struct v3d_file_priv *v3d_priv 
= file_priv->driver_priv;
07c2a41658c454 Melissa Wen   2021-09-30  460    struct v3d_job *job;
a783a09ee76d62 Eric Anholt   2019-04-16  461    int ret;
a783a09ee76d62 Eric Anholt   2019-04-16  462  
07c2a41658c454 Melissa Wen   2021-09-30  463    *container = kcalloc(1, size, 
GFP_KERNEL);
07c2a41658c454 Melissa Wen   2021-09-30  464    if (!*container) {
07c2a41658c454 Melissa Wen   2021-09-30  465            DRM_ERROR("Cannot 
allocate memory for v3d job.");
07c2a41658c454 Melissa Wen   2021-09-30  466            return -ENOMEM;
07c2a41658c454 Melissa Wen   2021-09-30  467    }
07c2a41658c454 Melissa Wen   2021-09-30  468  
07c2a41658c454 Melissa Wen   2021-09-30  469    job = *container;
a783a09ee76d62 Eric Anholt   2019-04-16 @470    job->v3d = v3d;
a783a09ee76d62 Eric Anholt   2019-04-16  471    job->free = free;
a783a09ee76d62 Eric Anholt   2019-04-16  472  
bc662528e29ae7 Daniel Vetter 2020-04-15  473    ret = 
pm_runtime_get_sync(v3d->drm.dev);
a783a09ee76d62 Eric Anholt   2019-04-16  474    if (ret < 0)
07c2a41658c454 Melissa Wen   2021-09-30  475            goto fail;
a783a09ee76d62 Eric Anholt   2019-04-16  476  
916044fac86232 Daniel Vetter 2021-08-05  477    ret = 
drm_sched_job_init(&job->base, &v3d_priv->sched_entity[queue],
916044fac86232 Daniel Vetter 2021-08-05  478                             
v3d_priv);
916044fac86232 Daniel Vetter 2021-08-05  479    if (ret)
07c2a41658c454 Melissa Wen   2021-09-30  480            goto fail_job;
dffa9b7a78c436 Eric Anholt   2019-04-16  481  
223583dd00a70a Melissa Wen   2021-09-30  482    ret = 
v3d_job_add_deps(file_priv, job, in_sync, 0);
dffa9b7a78c436 Eric Anholt   2019-04-16  483    if (ret)
07c2a41658c454 Melissa Wen   2021-09-30  484            goto fail_deps;
a783a09ee76d62 Eric Anholt   2019-04-16  485  
a783a09ee76d62 Eric Anholt   2019-04-16  486    kref_init(&job->refcount);
a783a09ee76d62 Eric Anholt   2019-04-16  487  
a783a09ee76d62 Eric Anholt   2019-04-16  488    return 0;
07c2a41658c454 Melissa Wen   2021-09-30  489  
07c2a41658c454 Melissa Wen   2021-09-30  490  fail_deps:
916044fac86232 Daniel Vetter 2021-08-05  491    
drm_sched_job_cleanup(&job->base);
07c2a41658c454 Melissa Wen   2021-09-30  492  fail_job:
bc662528e29ae7 Daniel Vetter 2020-04-15  493    
pm_runtime_put_autosuspend(v3d->drm.dev);
07c2a41658c454 Melissa Wen   2021-09-30  494  fail:
07c2a41658c454 Melissa Wen   2021-09-30  495    kfree(*container);
07c2a41658c454 Melissa Wen   2021-09-30  496    *container = NULL;
07c2a41658c454 Melissa Wen   2021-09-30  497  
dffa9b7a78c436 Eric Anholt   2019-04-16  498    return ret;
a783a09ee76d62 Eric Anholt   2019-04-16  499  }
a783a09ee76d62 Eric Anholt   2019-04-16  500  

:::::: The code at line 470 was first introduced by commit
:::::: a783a09ee76d6259296dc6aeea2b6884fa526980 drm/v3d: Refactor job 
management.

:::::: TO: Eric Anholt <[email protected]>
:::::: CC: Eric Anholt <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to