CC: [email protected] In-Reply-To: <163466195619.4493.18063027404688028587.st...@klimt.1015granger.net> References: <163466195619.4493.18063027404688028587.st...@klimt.1015granger.net> TO: Chuck Lever <[email protected]>
Hi Chuck, I love your patch! Perhaps something to improve: [auto build test WARNING on trondmy-nfs/linux-next] [also build test WARNING on tip/perf/core v5.15] [cannot apply to linus/master next-20211111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chuck-Lever/NFS-Move-generic-FS-show-macros-to-global-header/20211020-004721 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next :::::: branch date: 3 weeks ago :::::: commit date: 3 weeks ago config: i386-randconfig-s001-20211019 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/274dee65138d9112c72dd8692a9c59228d3fcbd1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chuck-Lever/NFS-Move-generic-FS-show-macros-to-global-header/20211020-004721 git checkout 274dee65138d9112c72dd8692a9c59228d3fcbd1 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash fs/nfs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> sparse warnings: (new ones prefixed by >>) fs/nfs/nfs4trace.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, fs/nfs/nfs4trace.h): >> fs/nfs/./nfs4trace.h:774:1: sparse: sparse: too long token expansion vim +774 fs/nfs/./nfs4trace.h 2bb50aabb6f32c Chuck Lever 2019-12-23 773 42113a75399353 Trond Myklebust 2013-08-12 @774 DECLARE_EVENT_CLASS(nfs4_open_event, 42113a75399353 Trond Myklebust 2013-08-12 775 TP_PROTO( 42113a75399353 Trond Myklebust 2013-08-12 776 const struct nfs_open_context *ctx, 42113a75399353 Trond Myklebust 2013-08-12 777 int flags, 42113a75399353 Trond Myklebust 2013-08-12 778 int error 42113a75399353 Trond Myklebust 2013-08-12 779 ), 42113a75399353 Trond Myklebust 2013-08-12 780 42113a75399353 Trond Myklebust 2013-08-12 781 TP_ARGS(ctx, flags, error), 42113a75399353 Trond Myklebust 2013-08-12 782 42113a75399353 Trond Myklebust 2013-08-12 783 TP_STRUCT__entry( 96650e2effa2db Chuck Lever 2019-06-19 784 __field(unsigned long, error) 274dee65138d91 Chuck Lever 2021-10-19 785 __field(unsigned long, flags) 274dee65138d91 Chuck Lever 2021-10-19 786 __field(unsigned long, fmode) 42113a75399353 Trond Myklebust 2013-08-12 787 __field(dev_t, dev) 42113a75399353 Trond Myklebust 2013-08-12 788 __field(u32, fhandle) 42113a75399353 Trond Myklebust 2013-08-12 789 __field(u64, fileid) 42113a75399353 Trond Myklebust 2013-08-12 790 __field(u64, dir) 42113a75399353 Trond Myklebust 2013-08-12 791 __string(name, ctx->dentry->d_name.name) 48c9579a1afe43 Olga Kornievskaia 2015-11-24 792 __field(int, stateid_seq) 48c9579a1afe43 Olga Kornievskaia 2015-11-24 793 __field(u32, stateid_hash) 48c9579a1afe43 Olga Kornievskaia 2015-11-24 794 __field(int, openstateid_seq) 48c9579a1afe43 Olga Kornievskaia 2015-11-24 795 __field(u32, openstateid_hash) 42113a75399353 Trond Myklebust 2013-08-12 796 ), 42113a75399353 Trond Myklebust 2013-08-12 797 42113a75399353 Trond Myklebust 2013-08-12 798 TP_fast_assign( 42113a75399353 Trond Myklebust 2013-08-12 799 const struct nfs4_state *state = ctx->state; 42113a75399353 Trond Myklebust 2013-08-12 800 const struct inode *inode = NULL; 42113a75399353 Trond Myklebust 2013-08-12 801 96650e2effa2db Chuck Lever 2019-06-19 802 __entry->error = -error; 42113a75399353 Trond Myklebust 2013-08-12 803 __entry->flags = flags; 274dee65138d91 Chuck Lever 2021-10-19 804 __entry->fmode = (__force unsigned long)ctx->mode; 42113a75399353 Trond Myklebust 2013-08-12 805 __entry->dev = ctx->dentry->d_sb->s_dev; 48c9579a1afe43 Olga Kornievskaia 2015-11-24 806 if (!IS_ERR_OR_NULL(state)) { 42113a75399353 Trond Myklebust 2013-08-12 807 inode = state->inode; 48c9579a1afe43 Olga Kornievskaia 2015-11-24 808 __entry->stateid_seq = 48c9579a1afe43 Olga Kornievskaia 2015-11-24 809 be32_to_cpu(state->stateid.seqid); 48c9579a1afe43 Olga Kornievskaia 2015-11-24 810 __entry->stateid_hash = 48c9579a1afe43 Olga Kornievskaia 2015-11-24 811 nfs_stateid_hash(&state->stateid); 48c9579a1afe43 Olga Kornievskaia 2015-11-24 812 __entry->openstateid_seq = 48c9579a1afe43 Olga Kornievskaia 2015-11-24 813 be32_to_cpu(state->open_stateid.seqid); 48c9579a1afe43 Olga Kornievskaia 2015-11-24 814 __entry->openstateid_hash = 48c9579a1afe43 Olga Kornievskaia 2015-11-24 815 nfs_stateid_hash(&state->open_stateid); 48c9579a1afe43 Olga Kornievskaia 2015-11-24 816 } else { 48c9579a1afe43 Olga Kornievskaia 2015-11-24 817 __entry->stateid_seq = 0; 48c9579a1afe43 Olga Kornievskaia 2015-11-24 818 __entry->stateid_hash = 0; 48c9579a1afe43 Olga Kornievskaia 2015-11-24 819 __entry->openstateid_seq = 0; 48c9579a1afe43 Olga Kornievskaia 2015-11-24 820 __entry->openstateid_hash = 0; 48c9579a1afe43 Olga Kornievskaia 2015-11-24 821 } 42113a75399353 Trond Myklebust 2013-08-12 822 if (inode != NULL) { 42113a75399353 Trond Myklebust 2013-08-12 823 __entry->fileid = NFS_FILEID(inode); 42113a75399353 Trond Myklebust 2013-08-12 824 __entry->fhandle = nfs_fhandle_hash(NFS_FH(inode)); 42113a75399353 Trond Myklebust 2013-08-12 825 } else { 42113a75399353 Trond Myklebust 2013-08-12 826 __entry->fileid = 0; 42113a75399353 Trond Myklebust 2013-08-12 827 __entry->fhandle = 0; 42113a75399353 Trond Myklebust 2013-08-12 828 } 2b0143b5c986be David Howells 2015-03-17 829 __entry->dir = NFS_FILEID(d_inode(ctx->dentry->d_parent)); 42113a75399353 Trond Myklebust 2013-08-12 830 __assign_str(name, ctx->dentry->d_name.name); 42113a75399353 Trond Myklebust 2013-08-12 831 ), 42113a75399353 Trond Myklebust 2013-08-12 832 42113a75399353 Trond Myklebust 2013-08-12 833 TP_printk( 274dee65138d91 Chuck Lever 2021-10-19 834 "error=%ld (%s) flags=%lu (%s) fmode=%s " 42113a75399353 Trond Myklebust 2013-08-12 835 "fileid=%02x:%02x:%llu fhandle=0x%08x " 48c9579a1afe43 Olga Kornievskaia 2015-11-24 836 "name=%02x:%02x:%llu/%s stateid=%d:0x%08x " 48c9579a1afe43 Olga Kornievskaia 2015-11-24 837 "openstateid=%d:0x%08x", 96650e2effa2db Chuck Lever 2019-06-19 838 -__entry->error, 42113a75399353 Trond Myklebust 2013-08-12 839 show_nfsv4_errors(__entry->error), 42113a75399353 Trond Myklebust 2013-08-12 840 __entry->flags, 274dee65138d91 Chuck Lever 2021-10-19 841 show_fs_fcntl_open_flags(__entry->flags), 274dee65138d91 Chuck Lever 2021-10-19 842 show_fs_fmode_flags(__entry->fmode), 42113a75399353 Trond Myklebust 2013-08-12 843 MAJOR(__entry->dev), MINOR(__entry->dev), 42113a75399353 Trond Myklebust 2013-08-12 844 (unsigned long long)__entry->fileid, 42113a75399353 Trond Myklebust 2013-08-12 845 __entry->fhandle, 42113a75399353 Trond Myklebust 2013-08-12 846 MAJOR(__entry->dev), MINOR(__entry->dev), 42113a75399353 Trond Myklebust 2013-08-12 847 (unsigned long long)__entry->dir, 48c9579a1afe43 Olga Kornievskaia 2015-11-24 848 __get_str(name), 48c9579a1afe43 Olga Kornievskaia 2015-11-24 849 __entry->stateid_seq, __entry->stateid_hash, 48c9579a1afe43 Olga Kornievskaia 2015-11-24 850 __entry->openstateid_seq, __entry->openstateid_hash 42113a75399353 Trond Myklebust 2013-08-12 851 ) 42113a75399353 Trond Myklebust 2013-08-12 852 ); 42113a75399353 Trond Myklebust 2013-08-12 853 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
