CC: [email protected] CC: [email protected] TO: Allison Henderson <[email protected]> CC: Mark Tinguely <[email protected]> CC: Dave Chinner <[email protected]> CC: "Darrick J. Wong" <[email protected]>
tree: https://github.com/allisonhenderson/xfs_work.git refs/heads/pptrs_restart130 head: 81b586ed999042613d6e120407086764e8ebf095 commit: b867e03dc38883e100333f7bf7a9619810458acd [27/32] xfs: Add the parent pointer support to the superblock version 5. :::::: branch date: 8 days ago :::::: commit date: 8 days ago config: riscv-randconfig-m031-20211103 (attached as .config) compiler: riscv64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: fs/xfs/xfs_inode.c:3578 xfs_rename() error: uninitialized symbol 'new_diroffset'. fs/xfs/xfs_inode.c:3586 xfs_rename() error: uninitialized symbol 'old_diroffset'. vim +/new_diroffset +3578 fs/xfs/xfs_inode.c 7dcf5c3e4527cf Dave Chinner 2015-03-25 3207 f6bba2017afb3b Dave Chinner 2013-08-12 3208 /* f6bba2017afb3b Dave Chinner 2013-08-12 3209 * xfs_rename f6bba2017afb3b Dave Chinner 2013-08-12 3210 */ f6bba2017afb3b Dave Chinner 2013-08-12 3211 int f6bba2017afb3b Dave Chinner 2013-08-12 3212 xfs_rename( f736d93d76d3e9 Christoph Hellwig 2021-01-21 3213 struct user_namespace *mnt_userns, 7dcf5c3e4527cf Dave Chinner 2015-03-25 3214 struct xfs_inode *src_dp, f6bba2017afb3b Dave Chinner 2013-08-12 3215 struct xfs_name *src_name, 7dcf5c3e4527cf Dave Chinner 2015-03-25 3216 struct xfs_inode *src_ip, 7dcf5c3e4527cf Dave Chinner 2015-03-25 3217 struct xfs_inode *target_dp, f6bba2017afb3b Dave Chinner 2013-08-12 3218 struct xfs_name *target_name, 7dcf5c3e4527cf Dave Chinner 2015-03-25 3219 struct xfs_inode *target_ip, d31a1825450062 Carlos Maiolino 2014-12-24 3220 unsigned int flags) f6bba2017afb3b Dave Chinner 2013-08-12 3221 { 7dcf5c3e4527cf Dave Chinner 2015-03-25 3222 struct xfs_mount *mp = src_dp->i_mount; 7dcf5c3e4527cf Dave Chinner 2015-03-25 3223 struct xfs_trans *tp; 7dcf5c3e4527cf Dave Chinner 2015-03-25 3224 struct xfs_inode *wip = NULL; /* whiteout inode */ 7dcf5c3e4527cf Dave Chinner 2015-03-25 3225 struct xfs_inode *inodes[__XFS_SORT_INODES]; 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3226 int i; 95afcf5c7bca93 Dave Chinner 2015-03-25 3227 int num_inodes = __XFS_SORT_INODES; 2b93681f593577 Dave Chinner 2015-03-25 3228 bool new_parent = (src_dp != target_dp); c19b3b05ae440d Dave Chinner 2016-02-09 3229 bool src_is_directory = S_ISDIR(VFS_I(src_ip)->i_mode); f6bba2017afb3b Dave Chinner 2013-08-12 3230 int spaceres; 7dcf5c3e4527cf Dave Chinner 2015-03-25 3231 int error; 26259f90cd074a Allison Henderson 2021-03-24 3232 struct xfs_parent_name_rec new_rec; 26259f90cd074a Allison Henderson 2021-03-24 3233 struct xfs_parent_name_rec old_rec; 26259f90cd074a Allison Henderson 2021-03-24 3234 xfs_dir2_dataptr_t new_diroffset; 26259f90cd074a Allison Henderson 2021-03-24 3235 xfs_dir2_dataptr_t old_diroffset; 26259f90cd074a Allison Henderson 2021-03-24 3236 struct xfs_da_args new_args = { 26259f90cd074a Allison Henderson 2021-03-24 3237 .dp = src_ip, 26259f90cd074a Allison Henderson 2021-03-24 3238 .geo = mp->m_attr_geo, 26259f90cd074a Allison Henderson 2021-03-24 3239 .whichfork = XFS_ATTR_FORK, 26259f90cd074a Allison Henderson 2021-03-24 3240 .attr_filter = XFS_ATTR_PARENT, 26259f90cd074a Allison Henderson 2021-03-24 3241 .op_flags = XFS_DA_OP_OKNOENT, 26259f90cd074a Allison Henderson 2021-03-24 3242 .name = (const uint8_t *)&new_rec, 26259f90cd074a Allison Henderson 2021-03-24 3243 .namelen = sizeof(new_rec), 26259f90cd074a Allison Henderson 2021-03-24 3244 .value = (void *)target_name->name, 26259f90cd074a Allison Henderson 2021-03-24 3245 .valuelen = target_name->len, 26259f90cd074a Allison Henderson 2021-03-24 3246 }; 26259f90cd074a Allison Henderson 2021-03-24 3247 struct xfs_da_args old_args = { 26259f90cd074a Allison Henderson 2021-03-24 3248 .dp = src_ip, 26259f90cd074a Allison Henderson 2021-03-24 3249 .geo = mp->m_attr_geo, 26259f90cd074a Allison Henderson 2021-03-24 3250 .whichfork = XFS_ATTR_FORK, 26259f90cd074a Allison Henderson 2021-03-24 3251 .attr_filter = XFS_ATTR_PARENT, 26259f90cd074a Allison Henderson 2021-03-24 3252 .op_flags = XFS_DA_OP_OKNOENT, 26259f90cd074a Allison Henderson 2021-03-24 3253 .name = (const uint8_t *)&old_rec, 26259f90cd074a Allison Henderson 2021-03-24 3254 .namelen = sizeof(old_rec), 26259f90cd074a Allison Henderson 2021-03-24 3255 .value = NULL, 26259f90cd074a Allison Henderson 2021-03-24 3256 .valuelen = 0, 26259f90cd074a Allison Henderson 2021-03-24 3257 }; f6bba2017afb3b Dave Chinner 2013-08-12 3258 f6bba2017afb3b Dave Chinner 2013-08-12 3259 trace_xfs_rename(src_dp, target_dp, src_name, target_name); f6bba2017afb3b Dave Chinner 2013-08-12 3260 eeacd3217b8fa8 Dave Chinner 2015-03-25 3261 if ((flags & RENAME_EXCHANGE) && !target_ip) eeacd3217b8fa8 Dave Chinner 2015-03-25 3262 return -EINVAL; eeacd3217b8fa8 Dave Chinner 2015-03-25 3263 7dcf5c3e4527cf Dave Chinner 2015-03-25 3264 /* 7dcf5c3e4527cf Dave Chinner 2015-03-25 3265 * If we are doing a whiteout operation, allocate the whiteout inode 7dcf5c3e4527cf Dave Chinner 2015-03-25 3266 * we will be placing at the target and ensure the type is set 7dcf5c3e4527cf Dave Chinner 2015-03-25 3267 * appropriately. 7dcf5c3e4527cf Dave Chinner 2015-03-25 3268 */ 7dcf5c3e4527cf Dave Chinner 2015-03-25 3269 if (flags & RENAME_WHITEOUT) { 7dcf5c3e4527cf Dave Chinner 2015-03-25 3270 ASSERT(!(flags & (RENAME_NOREPLACE | RENAME_EXCHANGE))); f736d93d76d3e9 Christoph Hellwig 2021-01-21 3271 error = xfs_rename_alloc_whiteout(mnt_userns, target_dp, &wip); 7dcf5c3e4527cf Dave Chinner 2015-03-25 3272 if (error) 7dcf5c3e4527cf Dave Chinner 2015-03-25 3273 return error; f6bba2017afb3b Dave Chinner 2013-08-12 3274 7dcf5c3e4527cf Dave Chinner 2015-03-25 3275 /* setup target dirent info as whiteout */ 7dcf5c3e4527cf Dave Chinner 2015-03-25 3276 src_name->type = XFS_DIR3_FT_CHRDEV; 7dcf5c3e4527cf Dave Chinner 2015-03-25 3277 } f6bba2017afb3b Dave Chinner 2013-08-12 3278 7dcf5c3e4527cf Dave Chinner 2015-03-25 3279 xfs_sort_for_rename(src_dp, target_dp, src_ip, target_ip, wip, f6bba2017afb3b Dave Chinner 2013-08-12 3280 inodes, &num_inodes); 26259f90cd074a Allison Henderson 2021-03-24 3281 if (xfs_has_larp(mp)) { 26259f90cd074a Allison Henderson 2021-03-24 3282 error = xfs_attr_use_log_assist(mp); 26259f90cd074a Allison Henderson 2021-03-24 3283 if (error) 26259f90cd074a Allison Henderson 2021-03-24 3284 goto out_release_wip; 26259f90cd074a Allison Henderson 2021-03-24 3285 } f6bba2017afb3b Dave Chinner 2013-08-12 3286 f6bba2017afb3b Dave Chinner 2013-08-12 3287 spaceres = XFS_RENAME_SPACE_RES(mp, target_name->len); 253f4911f297b8 Christoph Hellwig 2016-04-06 3288 error = xfs_trans_alloc(mp, &M_RES(mp)->tr_rename, spaceres, 0, 0, &tp); 2451337dd04390 Dave Chinner 2014-06-25 3289 if (error == -ENOSPC) { f6bba2017afb3b Dave Chinner 2013-08-12 3290 spaceres = 0; 253f4911f297b8 Christoph Hellwig 2016-04-06 3291 error = xfs_trans_alloc(mp, &M_RES(mp)->tr_rename, 0, 0, 0, 253f4911f297b8 Christoph Hellwig 2016-04-06 3292 &tp); f6bba2017afb3b Dave Chinner 2013-08-12 3293 } 445883e8133975 Dave Chinner 2015-03-25 3294 if (error) 26259f90cd074a Allison Henderson 2021-03-24 3295 goto drop_incompat; f6bba2017afb3b Dave Chinner 2013-08-12 3296 f6bba2017afb3b Dave Chinner 2013-08-12 3297 /* f6bba2017afb3b Dave Chinner 2013-08-12 3298 * Attach the dquots to the inodes f6bba2017afb3b Dave Chinner 2013-08-12 3299 */ f6bba2017afb3b Dave Chinner 2013-08-12 3300 error = xfs_qm_vop_rename_dqattach(inodes); 445883e8133975 Dave Chinner 2015-03-25 3301 if (error) 445883e8133975 Dave Chinner 2015-03-25 3302 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3303 f6bba2017afb3b Dave Chinner 2013-08-12 3304 /* f6bba2017afb3b Dave Chinner 2013-08-12 3305 * Lock all the participating inodes. Depending upon whether f6bba2017afb3b Dave Chinner 2013-08-12 3306 * the target_name exists in the target directory, and f6bba2017afb3b Dave Chinner 2013-08-12 3307 * whether the target directory is the same as the source f6bba2017afb3b Dave Chinner 2013-08-12 3308 * directory, we can lock from 2 to 4 inodes. f6bba2017afb3b Dave Chinner 2013-08-12 3309 */ f6bba2017afb3b Dave Chinner 2013-08-12 3310 xfs_lock_inodes(inodes, num_inodes, XFS_ILOCK_EXCL); f6bba2017afb3b Dave Chinner 2013-08-12 3311 f6bba2017afb3b Dave Chinner 2013-08-12 3312 /* f6bba2017afb3b Dave Chinner 2013-08-12 3313 * Join all the inodes to the transaction. From this point on, f6bba2017afb3b Dave Chinner 2013-08-12 3314 * we can rely on either trans_commit or trans_cancel to unlock f6bba2017afb3b Dave Chinner 2013-08-12 3315 * them. f6bba2017afb3b Dave Chinner 2013-08-12 3316 */ 26259f90cd074a Allison Henderson 2021-03-24 3317 xfs_trans_ijoin(tp, src_dp, 0); f6bba2017afb3b Dave Chinner 2013-08-12 3318 if (new_parent) 26259f90cd074a Allison Henderson 2021-03-24 3319 xfs_trans_ijoin(tp, target_dp, 0); 26259f90cd074a Allison Henderson 2021-03-24 3320 xfs_trans_ijoin(tp, src_ip, 0); f6bba2017afb3b Dave Chinner 2013-08-12 3321 if (target_ip) 26259f90cd074a Allison Henderson 2021-03-24 3322 xfs_trans_ijoin(tp, target_ip, 0); 7dcf5c3e4527cf Dave Chinner 2015-03-25 3323 if (wip) 26259f90cd074a Allison Henderson 2021-03-24 3324 xfs_trans_ijoin(tp, wip, 0); f6bba2017afb3b Dave Chinner 2013-08-12 3325 f6bba2017afb3b Dave Chinner 2013-08-12 3326 /* f6bba2017afb3b Dave Chinner 2013-08-12 3327 * If we are using project inheritance, we only allow renames f6bba2017afb3b Dave Chinner 2013-08-12 3328 * into our tree when the project IDs are the same; else the f6bba2017afb3b Dave Chinner 2013-08-12 3329 * tree quota mechanism would be circumvented. f6bba2017afb3b Dave Chinner 2013-08-12 3330 */ db07349da2f564 Christoph Hellwig 2021-03-29 3331 if (unlikely((target_dp->i_diflags & XFS_DIFLAG_PROJINHERIT) && ceaf603c7024d3 Christoph Hellwig 2021-03-29 3332 target_dp->i_projid != src_ip->i_projid)) { 2451337dd04390 Dave Chinner 2014-06-25 3333 error = -EXDEV; 26259f90cd074a Allison Henderson 2021-03-24 3334 goto out_unlock; f6bba2017afb3b Dave Chinner 2013-08-12 3335 } f6bba2017afb3b Dave Chinner 2013-08-12 3336 eeacd3217b8fa8 Dave Chinner 2015-03-25 3337 /* RENAME_EXCHANGE is unique from here on. */ 26259f90cd074a Allison Henderson 2021-03-24 3338 if (flags & RENAME_EXCHANGE) { 26259f90cd074a Allison Henderson 2021-03-24 3339 error = xfs_cross_rename(tp, src_dp, src_name, src_ip, d31a1825450062 Carlos Maiolino 2014-12-24 3340 target_dp, target_name, target_ip, f16dea54b789aa Brian Foster 2018-07-11 3341 spaceres); 26259f90cd074a Allison Henderson 2021-03-24 3342 goto out_pptr; 26259f90cd074a Allison Henderson 2021-03-24 3343 } f6bba2017afb3b Dave Chinner 2013-08-12 3344 /* bc56ad8c74b858 kaixuxia 2019-09-03 3345 * Check for expected errors before we dirty the transaction bc56ad8c74b858 kaixuxia 2019-09-03 3346 * so we can return an error without a transaction abort. 02092a2f034fde Chandan Babu R 2021-01-22 3347 * 02092a2f034fde Chandan Babu R 2021-01-22 3348 * Extent count overflow check: 02092a2f034fde Chandan Babu R 2021-01-22 3349 * 02092a2f034fde Chandan Babu R 2021-01-22 3350 * From the perspective of src_dp, a rename operation is essentially a 02092a2f034fde Chandan Babu R 2021-01-22 3351 * directory entry remove operation. Hence the only place where we check 02092a2f034fde Chandan Babu R 2021-01-22 3352 * for extent count overflow for src_dp is in 02092a2f034fde Chandan Babu R 2021-01-22 3353 * xfs_bmap_del_extent_real(). xfs_bmap_del_extent_real() returns 02092a2f034fde Chandan Babu R 2021-01-22 3354 * -ENOSPC when it detects a possible extent count overflow and in 02092a2f034fde Chandan Babu R 2021-01-22 3355 * response, the higher layers of directory handling code do the 02092a2f034fde Chandan Babu R 2021-01-22 3356 * following: 02092a2f034fde Chandan Babu R 2021-01-22 3357 * 1. Data/Free blocks: XFS lets these blocks linger until a 02092a2f034fde Chandan Babu R 2021-01-22 3358 * future remove operation removes them. 02092a2f034fde Chandan Babu R 2021-01-22 3359 * 2. Dabtree blocks: XFS swaps the blocks with the last block in the 02092a2f034fde Chandan Babu R 2021-01-22 3360 * Leaf space and unmaps the last block. 02092a2f034fde Chandan Babu R 2021-01-22 3361 * 02092a2f034fde Chandan Babu R 2021-01-22 3362 * For target_dp, there are two cases depending on whether the 02092a2f034fde Chandan Babu R 2021-01-22 3363 * destination directory entry exists or not. 02092a2f034fde Chandan Babu R 2021-01-22 3364 * 02092a2f034fde Chandan Babu R 2021-01-22 3365 * When destination directory entry does not exist (i.e. target_ip == 02092a2f034fde Chandan Babu R 2021-01-22 3366 * NULL), extent count overflow check is performed only when transaction 02092a2f034fde Chandan Babu R 2021-01-22 3367 * has a non-zero sized space reservation associated with it. With a 02092a2f034fde Chandan Babu R 2021-01-22 3368 * zero-sized space reservation, XFS allows a rename operation to 02092a2f034fde Chandan Babu R 2021-01-22 3369 * continue only when the directory has sufficient free space in its 02092a2f034fde Chandan Babu R 2021-01-22 3370 * data/leaf/free space blocks to hold the new entry. 02092a2f034fde Chandan Babu R 2021-01-22 3371 * 02092a2f034fde Chandan Babu R 2021-01-22 3372 * When destination directory entry exists (i.e. target_ip != NULL), all 02092a2f034fde Chandan Babu R 2021-01-22 3373 * we need to do is change the inode number associated with the already 02092a2f034fde Chandan Babu R 2021-01-22 3374 * existing entry. Hence there is no need to perform an extent count 02092a2f034fde Chandan Babu R 2021-01-22 3375 * overflow check. f6bba2017afb3b Dave Chinner 2013-08-12 3376 */ f6bba2017afb3b Dave Chinner 2013-08-12 3377 if (target_ip == NULL) { f6bba2017afb3b Dave Chinner 2013-08-12 3378 /* f6bba2017afb3b Dave Chinner 2013-08-12 3379 * If there's no space reservation, check the entry will f6bba2017afb3b Dave Chinner 2013-08-12 3380 * fit before actually inserting it. f6bba2017afb3b Dave Chinner 2013-08-12 3381 */ 94f3cad555d660 Eric Sandeen 2014-09-09 3382 if (!spaceres) { 94f3cad555d660 Eric Sandeen 2014-09-09 3383 error = xfs_dir_canenter(tp, target_dp, target_name); f6bba2017afb3b Dave Chinner 2013-08-12 3384 if (error) 26259f90cd074a Allison Henderson 2021-03-24 3385 goto out_unlock; 02092a2f034fde Chandan Babu R 2021-01-22 3386 } else { 02092a2f034fde Chandan Babu R 2021-01-22 3387 error = xfs_iext_count_may_overflow(target_dp, 02092a2f034fde Chandan Babu R 2021-01-22 3388 XFS_DATA_FORK, 02092a2f034fde Chandan Babu R 2021-01-22 3389 XFS_IEXT_DIR_MANIP_CNT(mp)); 02092a2f034fde Chandan Babu R 2021-01-22 3390 if (error) 02092a2f034fde Chandan Babu R 2021-01-22 3391 goto out_trans_cancel; 94f3cad555d660 Eric Sandeen 2014-09-09 3392 } bc56ad8c74b858 kaixuxia 2019-09-03 3393 } else { bc56ad8c74b858 kaixuxia 2019-09-03 3394 /* bc56ad8c74b858 kaixuxia 2019-09-03 3395 * If target exists and it's a directory, check that whether bc56ad8c74b858 kaixuxia 2019-09-03 3396 * it can be destroyed. bc56ad8c74b858 kaixuxia 2019-09-03 3397 */ bc56ad8c74b858 kaixuxia 2019-09-03 3398 if (S_ISDIR(VFS_I(target_ip)->i_mode) && bc56ad8c74b858 kaixuxia 2019-09-03 3399 (!xfs_dir_isempty(target_ip) || bc56ad8c74b858 kaixuxia 2019-09-03 3400 (VFS_I(target_ip)->i_nlink > 2))) { bc56ad8c74b858 kaixuxia 2019-09-03 3401 error = -EEXIST; bc56ad8c74b858 kaixuxia 2019-09-03 3402 goto out_trans_cancel; bc56ad8c74b858 kaixuxia 2019-09-03 3403 } bc56ad8c74b858 kaixuxia 2019-09-03 3404 } bc56ad8c74b858 kaixuxia 2019-09-03 3405 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3406 /* 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3407 * Lock the AGI buffers we need to handle bumping the nlink of the 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3408 * whiteout inode off the unlinked list and to handle dropping the 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3409 * nlink of the target inode. Per locking order rules, do this in 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3410 * increasing AG order and before directory block allocation tries to 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3411 * grab AGFs because we grab AGIs before AGFs. 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3412 * 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3413 * The (vfs) caller must ensure that if src is a directory then 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3414 * target_ip is either null or an empty directory. 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3415 */ 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3416 for (i = 0; i < num_inodes && inodes[i] != NULL; i++) { 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3417 if (inodes[i] == wip || 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3418 (inodes[i] == target_ip && 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3419 (VFS_I(target_ip)->i_nlink == 1 || src_is_directory))) { 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3420 struct xfs_buf *bp; 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3421 xfs_agnumber_t agno; 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3422 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3423 agno = XFS_INO_TO_AGNO(mp, inodes[i]->i_ino); 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3424 error = xfs_read_agi(mp, tp, agno, &bp); 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3425 if (error) 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3426 goto out_trans_cancel; 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3427 } 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3428 } 6da1b4b1ab36d8 Darrick J. Wong 2021-01-22 3429 bc56ad8c74b858 kaixuxia 2019-09-03 3430 /* bc56ad8c74b858 kaixuxia 2019-09-03 3431 * Directory entry creation below may acquire the AGF. Remove bc56ad8c74b858 kaixuxia 2019-09-03 3432 * the whiteout from the unlinked list first to preserve correct bc56ad8c74b858 kaixuxia 2019-09-03 3433 * AGI/AGF locking order. This dirties the transaction so failures bc56ad8c74b858 kaixuxia 2019-09-03 3434 * after this point will abort and log recovery will clean up the bc56ad8c74b858 kaixuxia 2019-09-03 3435 * mess. bc56ad8c74b858 kaixuxia 2019-09-03 3436 * bc56ad8c74b858 kaixuxia 2019-09-03 3437 * For whiteouts, we need to bump the link count on the whiteout bc56ad8c74b858 kaixuxia 2019-09-03 3438 * inode. After this point, we have a real link, clear the tmpfile bc56ad8c74b858 kaixuxia 2019-09-03 3439 * state flag from the inode so it doesn't accidentally get misused bc56ad8c74b858 kaixuxia 2019-09-03 3440 * in future. bc56ad8c74b858 kaixuxia 2019-09-03 3441 */ bc56ad8c74b858 kaixuxia 2019-09-03 3442 if (wip) { f40aadb2bb64fe Dave Chinner 2021-06-02 3443 struct xfs_perag *pag; f40aadb2bb64fe Dave Chinner 2021-06-02 3444 bc56ad8c74b858 kaixuxia 2019-09-03 3445 ASSERT(VFS_I(wip)->i_nlink == 0); f40aadb2bb64fe Dave Chinner 2021-06-02 3446 f40aadb2bb64fe Dave Chinner 2021-06-02 3447 pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, wip->i_ino)); f40aadb2bb64fe Dave Chinner 2021-06-02 3448 error = xfs_iunlink_remove(tp, pag, wip); f40aadb2bb64fe Dave Chinner 2021-06-02 3449 xfs_perag_put(pag); bc56ad8c74b858 kaixuxia 2019-09-03 3450 if (error) bc56ad8c74b858 kaixuxia 2019-09-03 3451 goto out_trans_cancel; bc56ad8c74b858 kaixuxia 2019-09-03 3452 bc56ad8c74b858 kaixuxia 2019-09-03 3453 xfs_bumplink(tp, wip); bc56ad8c74b858 kaixuxia 2019-09-03 3454 VFS_I(wip)->i_state &= ~I_LINKABLE; bc56ad8c74b858 kaixuxia 2019-09-03 3455 } bc56ad8c74b858 kaixuxia 2019-09-03 3456 bc56ad8c74b858 kaixuxia 2019-09-03 3457 /* bc56ad8c74b858 kaixuxia 2019-09-03 3458 * Set up the target. bc56ad8c74b858 kaixuxia 2019-09-03 3459 */ bc56ad8c74b858 kaixuxia 2019-09-03 3460 if (target_ip == NULL) { f6bba2017afb3b Dave Chinner 2013-08-12 3461 /* f6bba2017afb3b Dave Chinner 2013-08-12 3462 * If target does not exist and the rename crosses f6bba2017afb3b Dave Chinner 2013-08-12 3463 * directories, adjust the target directory link count f6bba2017afb3b Dave Chinner 2013-08-12 3464 * to account for the ".." reference from the new entry. f6bba2017afb3b Dave Chinner 2013-08-12 3465 */ f6bba2017afb3b Dave Chinner 2013-08-12 3466 error = xfs_dir_createname(tp, target_dp, target_name, 26259f90cd074a Allison Henderson 2021-03-24 3467 src_ip->i_ino, spaceres, &new_diroffset); f6bba2017afb3b Dave Chinner 2013-08-12 3468 if (error) c8eac49ef798a7 Brian Foster 2018-07-24 3469 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3470 f6bba2017afb3b Dave Chinner 2013-08-12 3471 xfs_trans_ichgtime(tp, target_dp, f6bba2017afb3b Dave Chinner 2013-08-12 3472 XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG); f6bba2017afb3b Dave Chinner 2013-08-12 3473 f6bba2017afb3b Dave Chinner 2013-08-12 3474 if (new_parent && src_is_directory) { 910832697cf855 Eric Sandeen 2019-05-01 3475 xfs_bumplink(tp, target_dp); f6bba2017afb3b Dave Chinner 2013-08-12 3476 } f6bba2017afb3b Dave Chinner 2013-08-12 3477 } else { /* target_ip != NULL */ f6bba2017afb3b Dave Chinner 2013-08-12 3478 /* f6bba2017afb3b Dave Chinner 2013-08-12 3479 * Link the source inode under the target name. f6bba2017afb3b Dave Chinner 2013-08-12 3480 * If the source inode is a directory and we are moving f6bba2017afb3b Dave Chinner 2013-08-12 3481 * it across directories, its ".." entry will be f6bba2017afb3b Dave Chinner 2013-08-12 3482 * inconsistent until we replace that down below. f6bba2017afb3b Dave Chinner 2013-08-12 3483 * f6bba2017afb3b Dave Chinner 2013-08-12 3484 * In case there is already an entry with the same f6bba2017afb3b Dave Chinner 2013-08-12 3485 * name at the destination directory, remove it first. f6bba2017afb3b Dave Chinner 2013-08-12 3486 */ f6bba2017afb3b Dave Chinner 2013-08-12 3487 error = xfs_dir_replace(tp, target_dp, target_name, 26259f90cd074a Allison Henderson 2021-03-24 3488 src_ip->i_ino, spaceres, &new_diroffset); f6bba2017afb3b Dave Chinner 2013-08-12 3489 if (error) c8eac49ef798a7 Brian Foster 2018-07-24 3490 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3491 f6bba2017afb3b Dave Chinner 2013-08-12 3492 xfs_trans_ichgtime(tp, target_dp, f6bba2017afb3b Dave Chinner 2013-08-12 3493 XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG); f6bba2017afb3b Dave Chinner 2013-08-12 3494 f6bba2017afb3b Dave Chinner 2013-08-12 3495 /* f6bba2017afb3b Dave Chinner 2013-08-12 3496 * Decrement the link count on the target since the target f6bba2017afb3b Dave Chinner 2013-08-12 3497 * dir no longer points to it. f6bba2017afb3b Dave Chinner 2013-08-12 3498 */ f6bba2017afb3b Dave Chinner 2013-08-12 3499 error = xfs_droplink(tp, target_ip); f6bba2017afb3b Dave Chinner 2013-08-12 3500 if (error) c8eac49ef798a7 Brian Foster 2018-07-24 3501 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3502 f6bba2017afb3b Dave Chinner 2013-08-12 3503 if (src_is_directory) { f6bba2017afb3b Dave Chinner 2013-08-12 3504 /* f6bba2017afb3b Dave Chinner 2013-08-12 3505 * Drop the link from the old "." entry. f6bba2017afb3b Dave Chinner 2013-08-12 3506 */ f6bba2017afb3b Dave Chinner 2013-08-12 3507 error = xfs_droplink(tp, target_ip); f6bba2017afb3b Dave Chinner 2013-08-12 3508 if (error) c8eac49ef798a7 Brian Foster 2018-07-24 3509 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3510 } f6bba2017afb3b Dave Chinner 2013-08-12 3511 } /* target_ip != NULL */ f6bba2017afb3b Dave Chinner 2013-08-12 3512 f6bba2017afb3b Dave Chinner 2013-08-12 3513 /* f6bba2017afb3b Dave Chinner 2013-08-12 3514 * Remove the source. f6bba2017afb3b Dave Chinner 2013-08-12 3515 */ f6bba2017afb3b Dave Chinner 2013-08-12 3516 if (new_parent && src_is_directory) { f6bba2017afb3b Dave Chinner 2013-08-12 3517 /* f6bba2017afb3b Dave Chinner 2013-08-12 3518 * Rewrite the ".." entry to point to the new f6bba2017afb3b Dave Chinner 2013-08-12 3519 * directory. f6bba2017afb3b Dave Chinner 2013-08-12 3520 */ f6bba2017afb3b Dave Chinner 2013-08-12 3521 error = xfs_dir_replace(tp, src_ip, &xfs_name_dotdot, 26259f90cd074a Allison Henderson 2021-03-24 3522 target_dp->i_ino, spaceres, &new_diroffset); 2451337dd04390 Dave Chinner 2014-06-25 3523 ASSERT(error != -EEXIST); f6bba2017afb3b Dave Chinner 2013-08-12 3524 if (error) c8eac49ef798a7 Brian Foster 2018-07-24 3525 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3526 } f6bba2017afb3b Dave Chinner 2013-08-12 3527 f6bba2017afb3b Dave Chinner 2013-08-12 3528 /* f6bba2017afb3b Dave Chinner 2013-08-12 3529 * We always want to hit the ctime on the source inode. f6bba2017afb3b Dave Chinner 2013-08-12 3530 * f6bba2017afb3b Dave Chinner 2013-08-12 3531 * This isn't strictly required by the standards since the source f6bba2017afb3b Dave Chinner 2013-08-12 3532 * inode isn't really being changed, but old unix file systems did f6bba2017afb3b Dave Chinner 2013-08-12 3533 * it and some incremental backup programs won't work without it. f6bba2017afb3b Dave Chinner 2013-08-12 3534 */ f6bba2017afb3b Dave Chinner 2013-08-12 3535 xfs_trans_ichgtime(tp, src_ip, XFS_ICHGTIME_CHG); f6bba2017afb3b Dave Chinner 2013-08-12 3536 xfs_trans_log_inode(tp, src_ip, XFS_ILOG_CORE); f6bba2017afb3b Dave Chinner 2013-08-12 3537 f6bba2017afb3b Dave Chinner 2013-08-12 3538 /* f6bba2017afb3b Dave Chinner 2013-08-12 3539 * Adjust the link count on src_dp. This is necessary when f6bba2017afb3b Dave Chinner 2013-08-12 3540 * renaming a directory, either within one parent when f6bba2017afb3b Dave Chinner 2013-08-12 3541 * the target existed, or across two parent directories. f6bba2017afb3b Dave Chinner 2013-08-12 3542 */ f6bba2017afb3b Dave Chinner 2013-08-12 3543 if (src_is_directory && (new_parent || target_ip != NULL)) { f6bba2017afb3b Dave Chinner 2013-08-12 3544 f6bba2017afb3b Dave Chinner 2013-08-12 3545 /* f6bba2017afb3b Dave Chinner 2013-08-12 3546 * Decrement link count on src_directory since the f6bba2017afb3b Dave Chinner 2013-08-12 3547 * entry that's moved no longer points to it. f6bba2017afb3b Dave Chinner 2013-08-12 3548 */ f6bba2017afb3b Dave Chinner 2013-08-12 3549 error = xfs_droplink(tp, src_dp); f6bba2017afb3b Dave Chinner 2013-08-12 3550 if (error) c8eac49ef798a7 Brian Foster 2018-07-24 3551 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3552 } f6bba2017afb3b Dave Chinner 2013-08-12 3553 7dcf5c3e4527cf Dave Chinner 2015-03-25 3554 /* 7dcf5c3e4527cf Dave Chinner 2015-03-25 3555 * For whiteouts, we only need to update the source dirent with the 7dcf5c3e4527cf Dave Chinner 2015-03-25 3556 * inode number of the whiteout inode rather than removing it 7dcf5c3e4527cf Dave Chinner 2015-03-25 3557 * altogether. 7dcf5c3e4527cf Dave Chinner 2015-03-25 3558 */ 7dcf5c3e4527cf Dave Chinner 2015-03-25 3559 if (wip) { 7dcf5c3e4527cf Dave Chinner 2015-03-25 3560 error = xfs_dir_replace(tp, src_dp, src_name, wip->i_ino, 26259f90cd074a Allison Henderson 2021-03-24 3561 spaceres, &old_diroffset); 02092a2f034fde Chandan Babu R 2021-01-22 3562 } else { 02092a2f034fde Chandan Babu R 2021-01-22 3563 /* 02092a2f034fde Chandan Babu R 2021-01-22 3564 * NOTE: We don't need to check for extent count overflow here 02092a2f034fde Chandan Babu R 2021-01-22 3565 * because the dir remove name code will leave the dir block in 02092a2f034fde Chandan Babu R 2021-01-22 3566 * place if the extent count would overflow. 02092a2f034fde Chandan Babu R 2021-01-22 3567 */ f6bba2017afb3b Dave Chinner 2013-08-12 3568 error = xfs_dir_removename(tp, src_dp, src_name, src_ip->i_ino, 26259f90cd074a Allison Henderson 2021-03-24 3569 spaceres, &old_diroffset); 02092a2f034fde Chandan Babu R 2021-01-22 3570 } 02092a2f034fde Chandan Babu R 2021-01-22 3571 f6bba2017afb3b Dave Chinner 2013-08-12 3572 if (error) c8eac49ef798a7 Brian Foster 2018-07-24 3573 goto out_trans_cancel; f6bba2017afb3b Dave Chinner 2013-08-12 3574 26259f90cd074a Allison Henderson 2021-03-24 3575 out_pptr: 26259f90cd074a Allison Henderson 2021-03-24 3576 if (xfs_sb_version_hasparent(&mp->m_sb)) { 26259f90cd074a Allison Henderson 2021-03-24 3577 new_args.trans = tp; 26259f90cd074a Allison Henderson 2021-03-24 @3578 xfs_init_parent_name_rec(&new_rec, target_dp, new_diroffset); 26259f90cd074a Allison Henderson 2021-03-24 3579 new_args.hashval = xfs_da_hashname(new_args.name, 26259f90cd074a Allison Henderson 2021-03-24 3580 new_args.namelen); 26259f90cd074a Allison Henderson 2021-03-24 3581 error = xfs_attr_set_deferred(&new_args); 26259f90cd074a Allison Henderson 2021-03-24 3582 if (error) 26259f90cd074a Allison Henderson 2021-03-24 3583 goto out_trans_cancel; 26259f90cd074a Allison Henderson 2021-03-24 3584 26259f90cd074a Allison Henderson 2021-03-24 3585 old_args.trans = tp; 26259f90cd074a Allison Henderson 2021-03-24 @3586 xfs_init_parent_name_rec(&old_rec, src_dp, old_diroffset); 26259f90cd074a Allison Henderson 2021-03-24 3587 old_args.hashval = xfs_da_hashname(old_args.name, 26259f90cd074a Allison Henderson 2021-03-24 3588 old_args.namelen); 26259f90cd074a Allison Henderson 2021-03-24 3589 error = xfs_attr_remove_deferred(&old_args); 26259f90cd074a Allison Henderson 2021-03-24 3590 if (error) 26259f90cd074a Allison Henderson 2021-03-24 3591 goto out_trans_cancel; 26259f90cd074a Allison Henderson 2021-03-24 3592 } 26259f90cd074a Allison Henderson 2021-03-24 3593 f6bba2017afb3b Dave Chinner 2013-08-12 3594 xfs_trans_ichgtime(tp, src_dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG); f6bba2017afb3b Dave Chinner 2013-08-12 3595 xfs_trans_log_inode(tp, src_dp, XFS_ILOG_CORE); f6bba2017afb3b Dave Chinner 2013-08-12 3596 if (new_parent) f6bba2017afb3b Dave Chinner 2013-08-12 3597 xfs_trans_log_inode(tp, target_dp, XFS_ILOG_CORE); f6bba2017afb3b Dave Chinner 2013-08-12 3598 c9cfdb38117217 Brian Foster 2018-07-11 3599 error = xfs_finish_rename(tp); 26259f90cd074a Allison Henderson 2021-03-24 3600 26259f90cd074a Allison Henderson 2021-03-24 3601 out_unlock: 7dcf5c3e4527cf Dave Chinner 2015-03-25 3602 if (wip) 44a8736bd20a08 Darrick J. Wong 2018-07-25 3603 xfs_irele(wip); 26259f90cd074a Allison Henderson 2021-03-24 3604 if (wip) 26259f90cd074a Allison Henderson 2021-03-24 3605 xfs_iunlock(wip, XFS_ILOCK_EXCL); 26259f90cd074a Allison Henderson 2021-03-24 3606 if (target_ip) 26259f90cd074a Allison Henderson 2021-03-24 3607 xfs_iunlock(target_ip, XFS_ILOCK_EXCL); 26259f90cd074a Allison Henderson 2021-03-24 3608 xfs_iunlock(src_ip, XFS_ILOCK_EXCL); 26259f90cd074a Allison Henderson 2021-03-24 3609 if (new_parent) 26259f90cd074a Allison Henderson 2021-03-24 3610 xfs_iunlock(target_dp, XFS_ILOCK_EXCL); 26259f90cd074a Allison Henderson 2021-03-24 3611 xfs_iunlock(src_dp, XFS_ILOCK_EXCL); 26259f90cd074a Allison Henderson 2021-03-24 3612 7dcf5c3e4527cf Dave Chinner 2015-03-25 3613 return error; f6bba2017afb3b Dave Chinner 2013-08-12 3614 445883e8133975 Dave Chinner 2015-03-25 3615 out_trans_cancel: 4906e21545814e Christoph Hellwig 2015-06-04 3616 xfs_trans_cancel(tp); 26259f90cd074a Allison Henderson 2021-03-24 3617 drop_incompat: 26259f90cd074a Allison Henderson 2021-03-24 3618 if (xfs_has_larp(mp)) 26259f90cd074a Allison Henderson 2021-03-24 3619 xlog_drop_incompat_feat(mp->m_log); 253f4911f297b8 Christoph Hellwig 2016-04-06 3620 out_release_wip: 7dcf5c3e4527cf Dave Chinner 2015-03-25 3621 if (wip) 44a8736bd20a08 Darrick J. Wong 2018-07-25 3622 xfs_irele(wip); f6bba2017afb3b Dave Chinner 2013-08-12 3623 return error; f6bba2017afb3b Dave Chinner 2013-08-12 3624 } f6bba2017afb3b Dave Chinner 2013-08-12 3625 :::::: The code at line 3578 was first introduced by commit :::::: 26259f90cd074af2c19b40f43172166124b61948 xfs: Add parent pointers to rename :::::: TO: Allison Henderson <[email protected]> :::::: CC: Allison Henderson <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
