On Tue, Nov 16, 2021 at 02:30:59PM +0100, Ansuel Smith wrote: > > On Mon, Nov 15, 2021 at 07:08:30PM +0100, Ansuel Smith wrote: > > > > tree: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > > > master > > > > head: debe436e77c72fcee804fb867f275e6d31aa999c > > > > commit: 5654ec78dd7e64b1e04777b24007344329e6a63b net: dsa: qca8k: > > > > rework rgmii delay logic and scan for cpu port 6 > > > > config: i386-randconfig-m021-20211025 (attached as .config) > > > > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > Reported-by: kernel test robot <[email protected]> > > > > Reported-by: Dan Carpenter <[email protected]> > > > > > > > > > > This should already be fixed by 06dd34a628ae5b6a839b757e746de165d6789ca8 > > > Can you confirm this? > > > > > > > No, it doesn't fix the problem. The check is either useless and should > > be removed or there is an out of bounds bug. Checking for an out of > > bounds *after* you've already written to the memory is *never* useful. > > > > regards, > > dan carpenter > > > > Again sorry if I insist and I'm 99% missing something. > There was an out of bounds bug. > It was fixed by 06dd34a628ae5b6a839b757e746de165d6789ca8 by > starting the counter to -1. > The extra check is useless, yes.
Then just delete it. We don't want code which is illogical even if it has no effect on run time. regards, dan carpenter _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
