CC: [email protected] CC: [email protected] TO: Mauro Carvalho Chehab <[email protected]> CC: [email protected] CC: Bjorn Helgaas <[email protected]> CC: Lorenzo Pieralisi <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8ab774587903771821b59471cc723bba6d893942 commit: 61d37547436dce45e3590db72360df0e230ca969 PCI: kirin: Reorganize the PHY logic inside the driver date: 2 weeks ago :::::: branch date: 3 days ago :::::: commit date: 2 weeks ago config: arm64-randconfig-m031-20211116 (attached as .config) compiler: aarch64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/pci/controller/dwc/pcie-kirin.c:221 hi3660_pcie_phy_clk_ctrl() warn: missing error code 'ret' vim +/ret +221 drivers/pci/controller/dwc/pcie-kirin.c fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 215 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 216 static int hi3660_pcie_phy_clk_ctrl(struct hi3660_pcie_phy *phy, bool enable) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 217 { fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 218 int ret = 0; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 219 fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 220 if (!enable) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 @221 goto close_clk; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 222 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 223 ret = clk_set_rate(phy->phy_ref_clk, REF_CLK_FREQ); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 224 if (ret) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 225 return ret; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 226 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 227 ret = clk_prepare_enable(phy->phy_ref_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 228 if (ret) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 229 return ret; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 230 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 231 ret = clk_prepare_enable(phy->apb_sys_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 232 if (ret) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 233 goto apb_sys_fail; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 234 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 235 ret = clk_prepare_enable(phy->apb_phy_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 236 if (ret) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 237 goto apb_phy_fail; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 238 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 239 ret = clk_prepare_enable(phy->aclk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 240 if (ret) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 241 goto aclk_fail; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 242 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 243 ret = clk_prepare_enable(phy->aux_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 244 if (ret) fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 245 goto aux_clk_fail; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 246 fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 247 return 0; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 248 fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 249 close_clk: 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 250 clk_disable_unprepare(phy->aux_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 251 aux_clk_fail: 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 252 clk_disable_unprepare(phy->aclk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 253 aclk_fail: 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 254 clk_disable_unprepare(phy->apb_phy_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 255 apb_phy_fail: 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 256 clk_disable_unprepare(phy->apb_sys_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 257 apb_sys_fail: 61d37547436dce4 drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 258 clk_disable_unprepare(phy->phy_ref_clk); fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 259 fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 260 return ret; fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 261 } fc5165db245ac4b drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 262 :::::: The code at line 221 was first introduced by commit :::::: fc5165db245ac4b56c19e634592a144352817c6d PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver :::::: TO: Xiaowei Song <[email protected]> :::::: CC: Bjorn Helgaas <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
