CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Kuniyuki Iwashima <[email protected]> TO: "David S. Miller" <[email protected]> CC: [email protected] TO: Jakub Kicinski <[email protected]> CC: Al Viro <[email protected]> CC: Eric Dumazet <[email protected]> CC: Kuniyuki Iwashima <[email protected]> CC: Benjamin Herrenschmidt <[email protected]>
Hi Kuniyuki, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Kuniyuki-Iwashima/af_unix-Replace-unix_table_lock-with-per-hash-locks/20211124-102129 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2106efda785b55a8957efed9a52dfa28ee0d7280 :::::: branch date: 2 days ago :::::: commit date: 2 days ago config: i386-randconfig-c001-20211125 (https://download.01.org/0day-ci/archive/20211125/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> cocci warnings: (new ones prefixed by >>) >> net/unix/af_unix.c:3258:2-11: second lock on line 3258 vim +3258 net/unix/af_unix.c 7123aaa3a141652 Eric Dumazet 2012-06-08 3242 7123aaa3a141652 Eric Dumazet 2012-06-08 3243 static struct sock *unix_next_socket(struct seq_file *seq, 7123aaa3a141652 Eric Dumazet 2012-06-08 3244 struct sock *sk, 7123aaa3a141652 Eric Dumazet 2012-06-08 3245 loff_t *pos) 7123aaa3a141652 Eric Dumazet 2012-06-08 3246 { 657190b06338092 Kuniyuki Iwashima 2021-11-24 3247 unsigned long bucket = get_bucket(*pos); 7123aaa3a141652 Eric Dumazet 2012-06-08 3248 7123aaa3a141652 Eric Dumazet 2012-06-08 3249 while (sk > (struct sock *)SEQ_START_TOKEN) { 7123aaa3a141652 Eric Dumazet 2012-06-08 3250 sk = sk_next(sk); 7123aaa3a141652 Eric Dumazet 2012-06-08 3251 if (!sk) 7123aaa3a141652 Eric Dumazet 2012-06-08 3252 goto next_bucket; 7123aaa3a141652 Eric Dumazet 2012-06-08 3253 if (sock_net(sk) == seq_file_net(seq)) 7123aaa3a141652 Eric Dumazet 2012-06-08 3254 return sk; ^1da177e4c3f415 Linus Torvalds 2005-04-16 3255 } 7123aaa3a141652 Eric Dumazet 2012-06-08 3256 7123aaa3a141652 Eric Dumazet 2012-06-08 3257 do { 657190b06338092 Kuniyuki Iwashima 2021-11-24 @3258 spin_lock(&unix_table_locks[bucket]); 7123aaa3a141652 Eric Dumazet 2012-06-08 3259 sk = unix_from_bucket(seq, pos); 7123aaa3a141652 Eric Dumazet 2012-06-08 3260 if (sk) 7123aaa3a141652 Eric Dumazet 2012-06-08 3261 return sk; 7123aaa3a141652 Eric Dumazet 2012-06-08 3262 7123aaa3a141652 Eric Dumazet 2012-06-08 3263 next_bucket: 657190b06338092 Kuniyuki Iwashima 2021-11-24 3264 spin_unlock(&unix_table_locks[bucket++]); 7123aaa3a141652 Eric Dumazet 2012-06-08 3265 *pos = set_bucket_offset(bucket, 1); 7123aaa3a141652 Eric Dumazet 2012-06-08 3266 } while (bucket < ARRAY_SIZE(unix_socket_table)); 7123aaa3a141652 Eric Dumazet 2012-06-08 3267 ^1da177e4c3f415 Linus Torvalds 2005-04-16 3268 return NULL; ^1da177e4c3f415 Linus Torvalds 2005-04-16 3269 } ^1da177e4c3f415 Linus Torvalds 2005-04-16 3270 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
