CC: [email protected] CC: [email protected] TO: Maximilian Luz <[email protected]> CC: Hans de Goede <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5f53fa508db098c9d372423a6dac31c8a5679cdf commit: bd69bcce4aa089435e2891222236b1cb20395bec platform/surface: Add Surface Hot-Plug driver date: 10 months ago :::::: branch date: 25 hours ago :::::: commit date: 10 months ago config: i386-randconfig-m021-20211116 (https://download.01.org/0day-ci/archive/20211126/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type? vim +163 drivers/platform/surface/surface_hotplug.c bd69bcce4aa0894 Maximilian Luz 2021-02-05 147 bd69bcce4aa0894 Maximilian Luz 2021-02-05 148 static int shps_setup_irq(struct platform_device *pdev, enum shps_irq_type type) bd69bcce4aa0894 Maximilian Luz 2021-02-05 149 { bd69bcce4aa0894 Maximilian Luz 2021-02-05 150 unsigned long flags = IRQF_ONESHOT | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING; bd69bcce4aa0894 Maximilian Luz 2021-02-05 151 struct shps_device *sdev = platform_get_drvdata(pdev); bd69bcce4aa0894 Maximilian Luz 2021-02-05 152 struct gpio_desc *gpiod; bd69bcce4aa0894 Maximilian Luz 2021-02-05 153 acpi_handle handle = ACPI_HANDLE(&pdev->dev); bd69bcce4aa0894 Maximilian Luz 2021-02-05 154 const char *irq_name; bd69bcce4aa0894 Maximilian Luz 2021-02-05 155 const int dsm = shps_dsm_fn_for_irq(type); bd69bcce4aa0894 Maximilian Luz 2021-02-05 156 int status, irq; bd69bcce4aa0894 Maximilian Luz 2021-02-05 157 bd69bcce4aa0894 Maximilian Luz 2021-02-05 158 /* bd69bcce4aa0894 Maximilian Luz 2021-02-05 159 * Only set up interrupts that we actually need: The Surface Book 3 bd69bcce4aa0894 Maximilian Luz 2021-02-05 160 * does not have a DSM for base presence, so don't set up an interrupt bd69bcce4aa0894 Maximilian Luz 2021-02-05 161 * for that. bd69bcce4aa0894 Maximilian Luz 2021-02-05 162 */ bd69bcce4aa0894 Maximilian Luz 2021-02-05 @163 if (!acpi_check_dsm(handle, &shps_dsm_guid, SHPS_DSM_REVISION, BIT(dsm))) { bd69bcce4aa0894 Maximilian Luz 2021-02-05 164 dev_dbg(&pdev->dev, "IRQ notification via DSM not present (irq=%d)\n", type); bd69bcce4aa0894 Maximilian Luz 2021-02-05 165 return 0; bd69bcce4aa0894 Maximilian Luz 2021-02-05 166 } bd69bcce4aa0894 Maximilian Luz 2021-02-05 167 bd69bcce4aa0894 Maximilian Luz 2021-02-05 168 gpiod = devm_gpiod_get(&pdev->dev, shps_gpio_names[type], GPIOD_ASIS); bd69bcce4aa0894 Maximilian Luz 2021-02-05 169 if (IS_ERR(gpiod)) bd69bcce4aa0894 Maximilian Luz 2021-02-05 170 return PTR_ERR(gpiod); bd69bcce4aa0894 Maximilian Luz 2021-02-05 171 bd69bcce4aa0894 Maximilian Luz 2021-02-05 172 irq = gpiod_to_irq(gpiod); bd69bcce4aa0894 Maximilian Luz 2021-02-05 173 if (irq < 0) bd69bcce4aa0894 Maximilian Luz 2021-02-05 174 return irq; bd69bcce4aa0894 Maximilian Luz 2021-02-05 175 bd69bcce4aa0894 Maximilian Luz 2021-02-05 176 irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "shps-irq-%d", type); bd69bcce4aa0894 Maximilian Luz 2021-02-05 177 if (!irq_name) bd69bcce4aa0894 Maximilian Luz 2021-02-05 178 return -ENOMEM; bd69bcce4aa0894 Maximilian Luz 2021-02-05 179 bd69bcce4aa0894 Maximilian Luz 2021-02-05 180 status = devm_request_threaded_irq(&pdev->dev, irq, NULL, shps_handle_irq, bd69bcce4aa0894 Maximilian Luz 2021-02-05 181 flags, irq_name, pdev); bd69bcce4aa0894 Maximilian Luz 2021-02-05 182 if (status) bd69bcce4aa0894 Maximilian Luz 2021-02-05 183 return status; bd69bcce4aa0894 Maximilian Luz 2021-02-05 184 bd69bcce4aa0894 Maximilian Luz 2021-02-05 185 dev_dbg(&pdev->dev, "set up irq %d as type %d\n", irq, type); bd69bcce4aa0894 Maximilian Luz 2021-02-05 186 bd69bcce4aa0894 Maximilian Luz 2021-02-05 187 sdev->gpio[type] = gpiod; bd69bcce4aa0894 Maximilian Luz 2021-02-05 188 sdev->irq[type] = irq; bd69bcce4aa0894 Maximilian Luz 2021-02-05 189 bd69bcce4aa0894 Maximilian Luz 2021-02-05 190 return 0; bd69bcce4aa0894 Maximilian Luz 2021-02-05 191 } bd69bcce4aa0894 Maximilian Luz 2021-02-05 192 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
