CC: [email protected] CC: [email protected] CC: [email protected] CC: Mark Brown <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5 commit: 8db90aa36063f471bea1e65e23185913043852dc Merge tag 'v5.11-rc1' into spi-5.11 date: 11 months ago :::::: branch date: 18 hours ago :::::: commit date: 11 months ago config: riscv-randconfig-c006-20211124 (https://download.01.org/0day-ci/archive/20211127/[email protected]/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8db90aa36063f471bea1e65e23185913043852dc git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 8db90aa36063f471bea1e65e23185913043852dc # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> clang-analyzer warnings: (new ones prefixed by >>) ^~~~~~~~~~~~~~~~~~ drivers/usb/core/hub.c:482:2: note: Loop condition is false. Execution continues on line 529 for (i = 0; i < hdev->maxchild; i++) { ^ drivers/usb/core/hub.c:529:7: note: 'changed' is 0 if (!changed && blinkenlights) { ^ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ drivers/usb/core/hub.c:529:6: note: Left side of '&&' is true if (!changed && blinkenlights) { ^ drivers/usb/core/hub.c:529:2: note: Assuming the condition is false if (!changed && blinkenlights) { ^ include/linux/compiler.h:56:45: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ drivers/usb/core/hub.c:529:2: note: '?' condition is false if (!changed && blinkenlights) { ^ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ include/linux/compiler.h:58:31: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^ drivers/usb/core/hub.c:529:7: note: 'changed' is 0 if (!changed && blinkenlights) { ^ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value' (cond) ? \ ^~~~ drivers/usb/core/hub.c:529:6: note: Left side of '&&' is true if (!changed && blinkenlights) { ^ drivers/usb/core/hub.c:529:2: note: '?' condition is true if (!changed && blinkenlights) { ^ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ include/linux/compiler.h:58:69: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^ include/linux/compiler.h:69:2: note: expanded from macro '__trace_if_value' (cond) ? \ ^ drivers/usb/core/hub.c:529:2: note: Taking true branch if (!changed && blinkenlights) { ^ include/linux/compiler.h:56:23: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ drivers/usb/core/hub.c:531:10: note: Division by zero cursor %= hdev->maxchild; ~~~~~~~^~~~~~~~~~~~~~~~~ drivers/usb/core/hub.c:3067:19: warning: Value stored to 'port_dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] struct usb_port *port_dev = hub->ports[port1 - 1]; ^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~ drivers/usb/core/hub.c:3067:19: note: Value stored to 'port_dev' during its initialization is never read struct usb_port *port_dev = hub->ports[port1 - 1]; ^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~ drivers/usb/core/hub.c:3693:3: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores] ret = -ENODEV; ^ ~~~~~~~ drivers/usb/core/hub.c:3693:3: note: Value stored to 'ret' is never read ret = -ENODEV; ^ ~~~~~~~ drivers/usb/core/hub.c:4424:19: warning: Value stored to 'port_dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] struct usb_port *port_dev = hub->ports[port1 - 1]; ^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~ drivers/usb/core/hub.c:4424:19: note: Value stored to 'port_dev' during its initialization is never read struct usb_port *port_dev = hub->ports[port1 - 1]; ^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~ drivers/usb/core/hub.c:4810:4: warning: Value stored to 'retval' is never read [clang-analyzer-deadcode.DeadStores] retval = 0; ^ ~ drivers/usb/core/hub.c:4810:4: note: Value stored to 'retval' is never read retval = 0; ^ ~ Suppressed 9 warnings (2 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 10 warnings generated. Suppressed 10 warnings (3 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. >> drivers/spi/spi-geni-qcom.c:467:19: warning: Division by zero >> [clang-analyzer-core.DivideZero] for (i = 0; i < DIV_ROUND_UP(rx_bytes, bytes_per_fifo_word); i++) ^ include/linux/math.h:36:22: note: expanded from macro 'DIV_ROUND_UP' #define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP ^ include/uapi/linux/const.h:34:54: note: expanded from macro '__KERNEL_DIV_ROUND_UP' #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) ^ drivers/spi/spi-geni-qcom.c:589:10: note: Loop condition is false. Exiting loop m_irq = readl(se->base + SE_GENI_M_IRQ_STATUS); ^ arch/riscv/include/asm/mmio.h:140:30: note: expanded from macro 'readl' #define readl(c) ({ u32 __v; __io_br(); __v = readl_cpu(c); __io_ar(__v); __v; }) ^ arch/riscv/include/asm/mmio.h:133:19: note: expanded from macro '__io_br' #define __io_br() do {} while (0) ^ drivers/spi/spi-geni-qcom.c:590:6: note: Assuming 'm_irq' is not equal to 0 if (!m_irq) ^ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ drivers/spi/spi-geni-qcom.c:590:2: note: '?' condition is false if (!m_irq) ^ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ include/linux/compiler.h:58:31: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^ drivers/spi/spi-geni-qcom.c:590:7: note: 'm_irq' is not equal to 0 if (!m_irq) ^ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value' (cond) ? \ ^~~~ drivers/spi/spi-geni-qcom.c:590:2: note: '?' condition is false if (!m_irq) ^ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ include/linux/compiler.h:58:69: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^ include/linux/compiler.h:69:2: note: expanded from macro '__trace_if_value' (cond) ? \ ^ drivers/spi/spi-geni-qcom.c:590:2: note: Taking false branch if (!m_irq) ^ include/linux/compiler.h:56:23: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ drivers/spi/spi-geni-qcom.c:593:2: note: Assuming the condition is false if (m_irq & (M_CMD_OVERRUN_EN | M_ILLEGAL_CMD_EN | M_CMD_FAILURE_EN | ^ include/linux/compiler.h:56:45: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ drivers/spi/spi-geni-qcom.c:593:2: note: '?' condition is false if (m_irq & (M_CMD_OVERRUN_EN | M_ILLEGAL_CMD_EN | M_CMD_FAILURE_EN | ^ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ include/linux/compiler.h:58:31: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^ drivers/spi/spi-geni-qcom.c:593:2: note: '?' condition is true if (m_irq & (M_CMD_OVERRUN_EN | M_ILLEGAL_CMD_EN | M_CMD_FAILURE_EN | ^ include/linux/compiler.h:56:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ include/linux/compiler.h:58:69: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^ include/linux/compiler.h:69:2: note: expanded from macro '__trace_if_value' (cond) ? \ ^ drivers/spi/spi-geni-qcom.c:593:2: note: Taking true branch if (m_irq & (M_CMD_OVERRUN_EN | M_ILLEGAL_CMD_EN | M_CMD_FAILURE_EN | ^ include/linux/compiler.h:56:23: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) vim +467 drivers/spi/spi-geni-qcom.c 6d66507d9b5507 Douglas Anderson 2020-09-12 445 6d66507d9b5507 Douglas Anderson 2020-09-12 446 static void geni_spi_handle_rx(struct spi_geni_master *mas) 6d66507d9b5507 Douglas Anderson 2020-09-12 447 { 6d66507d9b5507 Douglas Anderson 2020-09-12 448 struct geni_se *se = &mas->se; 6d66507d9b5507 Douglas Anderson 2020-09-12 449 u32 rx_fifo_status; 6d66507d9b5507 Douglas Anderson 2020-09-12 450 unsigned int rx_bytes; 6d66507d9b5507 Douglas Anderson 2020-09-12 451 unsigned int rx_last_byte_valid; 6d66507d9b5507 Douglas Anderson 2020-09-12 452 u8 *rx_buf; 6d66507d9b5507 Douglas Anderson 2020-09-12 453 unsigned int bytes_per_fifo_word = geni_byte_per_fifo_word(mas); 6d66507d9b5507 Douglas Anderson 2020-09-12 454 unsigned int i = 0; 6d66507d9b5507 Douglas Anderson 2020-09-12 455 6d66507d9b5507 Douglas Anderson 2020-09-12 456 rx_fifo_status = readl(se->base + SE_GENI_RX_FIFO_STATUS); 6d66507d9b5507 Douglas Anderson 2020-09-12 457 rx_bytes = (rx_fifo_status & RX_FIFO_WC_MSK) * bytes_per_fifo_word; 6d66507d9b5507 Douglas Anderson 2020-09-12 458 if (rx_fifo_status & RX_LAST) { 6d66507d9b5507 Douglas Anderson 2020-09-12 459 rx_last_byte_valid = rx_fifo_status & RX_LAST_BYTE_VALID_MSK; 6d66507d9b5507 Douglas Anderson 2020-09-12 460 rx_last_byte_valid >>= RX_LAST_BYTE_VALID_SHFT; 6d66507d9b5507 Douglas Anderson 2020-09-12 461 if (rx_last_byte_valid && rx_last_byte_valid < 4) 6d66507d9b5507 Douglas Anderson 2020-09-12 462 rx_bytes -= bytes_per_fifo_word - rx_last_byte_valid; 6d66507d9b5507 Douglas Anderson 2020-09-12 463 } 4aa1464acbe369 Douglas Anderson 2020-12-17 464 4aa1464acbe369 Douglas Anderson 2020-12-17 465 /* Clear out the FIFO and bail if nowhere to put it */ 4aa1464acbe369 Douglas Anderson 2020-12-17 466 if (!mas->cur_xfer) { 4aa1464acbe369 Douglas Anderson 2020-12-17 @467 for (i = 0; i < DIV_ROUND_UP(rx_bytes, bytes_per_fifo_word); i++) 4aa1464acbe369 Douglas Anderson 2020-12-17 468 readl(se->base + SE_GENI_RX_FIFOn); 4aa1464acbe369 Douglas Anderson 2020-12-17 469 return; 4aa1464acbe369 Douglas Anderson 2020-12-17 470 } 4aa1464acbe369 Douglas Anderson 2020-12-17 471 6d66507d9b5507 Douglas Anderson 2020-09-12 472 if (mas->rx_rem_bytes < rx_bytes) 6d66507d9b5507 Douglas Anderson 2020-09-12 473 rx_bytes = mas->rx_rem_bytes; 6d66507d9b5507 Douglas Anderson 2020-09-12 474 6d66507d9b5507 Douglas Anderson 2020-09-12 475 rx_buf = mas->cur_xfer->rx_buf + mas->cur_xfer->len - mas->rx_rem_bytes; 6d66507d9b5507 Douglas Anderson 2020-09-12 476 while (i < rx_bytes) { 6d66507d9b5507 Douglas Anderson 2020-09-12 477 u32 fifo_word = 0; 6d66507d9b5507 Douglas Anderson 2020-09-12 478 u8 *fifo_byte = (u8 *)&fifo_word; 6d66507d9b5507 Douglas Anderson 2020-09-12 479 unsigned int bytes_to_read; 6d66507d9b5507 Douglas Anderson 2020-09-12 480 unsigned int j; 6d66507d9b5507 Douglas Anderson 2020-09-12 481 6d66507d9b5507 Douglas Anderson 2020-09-12 482 bytes_to_read = min(bytes_per_fifo_word, rx_bytes - i); 6d66507d9b5507 Douglas Anderson 2020-09-12 483 ioread32_rep(se->base + SE_GENI_RX_FIFOn, &fifo_word, 1); 6d66507d9b5507 Douglas Anderson 2020-09-12 484 for (j = 0; j < bytes_to_read; j++) 6d66507d9b5507 Douglas Anderson 2020-09-12 485 rx_buf[i++] = fifo_byte[j]; 6d66507d9b5507 Douglas Anderson 2020-09-12 486 } 6d66507d9b5507 Douglas Anderson 2020-09-12 487 mas->rx_rem_bytes -= rx_bytes; 6d66507d9b5507 Douglas Anderson 2020-09-12 488 } 6d66507d9b5507 Douglas Anderson 2020-09-12 489 :::::: The code at line 467 was first introduced by commit :::::: 4aa1464acbe3697710279a4bd65cb4801ed30425 spi: spi-geni-qcom: Fix geni_spi_isr() NULL dereference in timeout case :::::: TO: Douglas Anderson <[email protected]> :::::: CC: Mark Brown <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
