CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Maciej Machnikowski <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi Maciej, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Maciej-Machnikowski/Add-ethtool-interface-for-SyncE/20211202-021915 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 23ea630f86c70cbe6691f9f839e7b6742f0e9ad3 :::::: branch date: 18 hours ago :::::: commit date: 18 hours ago config: i386-randconfig-c001-20211202 (https://download.01.org/0day-ci/archive/20211202/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> cocci warnings: (new ones prefixed by >>) >> net/ethtool/synce.c:156:1-3: WARNING: possible condition with no effect (if >> == else) vim +156 net/ethtool/synce.c 1890b45913d75d Maciej Machnikowski 2021-12-01 150 1890b45913d75d Maciej Machnikowski 2021-12-01 151 static int rclk_reply_size(const struct ethnl_req_info *req_base, 1890b45913d75d Maciej Machnikowski 2021-12-01 152 const struct ethnl_reply_data *reply_base) 1890b45913d75d Maciej Machnikowski 2021-12-01 153 { 1890b45913d75d Maciej Machnikowski 2021-12-01 154 const struct rclk_request_data *request = RCLK_REQDATA(req_base); 1890b45913d75d Maciej Machnikowski 2021-12-01 155 1890b45913d75d Maciej Machnikowski 2021-12-01 @156 if (request->out_pin.valid) 1890b45913d75d Maciej Machnikowski 2021-12-01 157 return nla_total_size(sizeof(u32)) + /* ETHTOOL_A_RCLK_PIN_FLAGS */ 1890b45913d75d Maciej Machnikowski 2021-12-01 158 nla_total_size(sizeof(u32)); /* ETHTOOL_A_RCLK_OUT_PIN_IDX */ 1890b45913d75d Maciej Machnikowski 2021-12-01 159 else 1890b45913d75d Maciej Machnikowski 2021-12-01 160 return nla_total_size(sizeof(u32)) + /* ETHTOOL_A_RCLK_PIN_MIN */ 1890b45913d75d Maciej Machnikowski 2021-12-01 161 nla_total_size(sizeof(u32)); /* ETHTOOL_A_RCLK_PIN_MAX */ 1890b45913d75d Maciej Machnikowski 2021-12-01 162 } 1890b45913d75d Maciej Machnikowski 2021-12-01 163 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
