CC: [email protected] CC: [email protected] TO: Maarten Lankhorst <[email protected]> CC: 0day robot <[email protected]>
tree: https://github.com/0day-ci/linux/commits/UPDATE-20211130-172226/Maarten-Lankhorst/drm-i915-Remove-short-term-pins-from-execbuf/20211129-220021 head: 006b42c124c6625d90b1486a86ec53034166062d commit: c997bd02c543622b260cd09a63cc9f300870e8a0 drm/i915: Force ww lock for i915_gem_object_ggtt_pin_ww, v2. date: 4 days ago :::::: branch date: 4 days ago :::::: commit date: 4 days ago config: i386-randconfig-m021-20211203 (https://download.01.org/0day-ci/archive/20211205/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/gpu/drm/i915/i915_gem.c:981 i915_gem_object_ggtt_pin() error: uninitialized symbol 'ret'. Old smatch warnings: drivers/gpu/drm/i915/gem/i915_gem_object.h:194 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 183) vim +/ret +981 drivers/gpu/drm/i915/i915_gem.c 673a394b1e3b69 Eric Anholt 2008-07-30 960 c997bd02c54362 Maarten Lankhorst 2021-11-30 961 struct i915_vma * __must_check c997bd02c54362 Maarten Lankhorst 2021-11-30 962 i915_gem_object_ggtt_pin(struct drm_i915_gem_object *obj, c997bd02c54362 Maarten Lankhorst 2021-11-30 963 const struct i915_ggtt_view *view, c997bd02c54362 Maarten Lankhorst 2021-11-30 964 u64 size, u64 alignment, u64 flags) c997bd02c54362 Maarten Lankhorst 2021-11-30 965 { c997bd02c54362 Maarten Lankhorst 2021-11-30 966 struct i915_gem_ww_ctx ww; c997bd02c54362 Maarten Lankhorst 2021-11-30 967 struct i915_vma *ret; c997bd02c54362 Maarten Lankhorst 2021-11-30 968 int err; c997bd02c54362 Maarten Lankhorst 2021-11-30 969 c997bd02c54362 Maarten Lankhorst 2021-11-30 970 for_i915_gem_ww(&ww, err, true) { c997bd02c54362 Maarten Lankhorst 2021-11-30 971 err = i915_gem_object_lock(obj, &ww); c997bd02c54362 Maarten Lankhorst 2021-11-30 972 if (err) c997bd02c54362 Maarten Lankhorst 2021-11-30 973 continue; c997bd02c54362 Maarten Lankhorst 2021-11-30 974 c997bd02c54362 Maarten Lankhorst 2021-11-30 975 ret = i915_gem_object_ggtt_pin_ww(obj, &ww, view, size, c997bd02c54362 Maarten Lankhorst 2021-11-30 976 alignment, flags); c997bd02c54362 Maarten Lankhorst 2021-11-30 977 if (IS_ERR(ret)) c997bd02c54362 Maarten Lankhorst 2021-11-30 978 err = PTR_ERR(ret); c997bd02c54362 Maarten Lankhorst 2021-11-30 979 } c997bd02c54362 Maarten Lankhorst 2021-11-30 980 c997bd02c54362 Maarten Lankhorst 2021-11-30 @981 return err ? ERR_PTR(err) : ret; c997bd02c54362 Maarten Lankhorst 2021-11-30 982 } c997bd02c54362 Maarten Lankhorst 2021-11-30 983 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
