CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Nicolai Stange <[email protected]> TO: Herbert Xu <[email protected]> TO: "David S. Miller" <[email protected]> CC: [email protected] CC: "Stephan Müller" <[email protected]> CC: Hannes Reinecke <[email protected]> CC: Torsten Duwe <[email protected]> CC: Zaibo Xu <[email protected]> CC: Giovanni Cabiddu <[email protected]> CC: David Howells <[email protected]> CC: Jarkko Sakkinen <[email protected]>
Hi Nicolai, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on herbert-cryptodev-2.6/master] [also build test WARNING on herbert-crypto-2.6/master linus/master jmorris-security/next-testing v5.16-rc4 next-20211206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicolai-Stange/crypto-dh-infrastructure-for-NVM-in-band-auth-and-FIPS-conformance/20211201-085159 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master :::::: branch date: 6 days ago :::::: commit date: 6 days ago config: arm-randconfig-m031-20211128 (https://download.01.org/0day-ci/archive/20211207/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: crypto/dh_helper.c:493 lookup_group_id() warn: we never enter this loop Old smatch warnings: crypto/dh_helper.c:466 get_safe_prime_group() warn: we never enter this loop vim +493 crypto/dh_helper.c 802c7f1c84e4b5a Salvatore Benedetto 2016-06-22 473 2048fab14cfd860 Nicolai Stange 2021-12-01 474 static enum dh_group_id lookup_group_id(const char *g, size_t g_size, 2048fab14cfd860 Nicolai Stange 2021-12-01 475 const char *p, size_t p_size) 2048fab14cfd860 Nicolai Stange 2021-12-01 476 { 2048fab14cfd860 Nicolai Stange 2021-12-01 477 int i; 2048fab14cfd860 Nicolai Stange 2021-12-01 478 2048fab14cfd860 Nicolai Stange 2021-12-01 479 /* All safe-prime groups use a generator of g == 2. */ 2048fab14cfd860 Nicolai Stange 2021-12-01 480 while (g_size && !*g) { 2048fab14cfd860 Nicolai Stange 2021-12-01 481 ++g; 2048fab14cfd860 Nicolai Stange 2021-12-01 482 --g_size; 2048fab14cfd860 Nicolai Stange 2021-12-01 483 } 2048fab14cfd860 Nicolai Stange 2021-12-01 484 2048fab14cfd860 Nicolai Stange 2021-12-01 485 if (g_size != 1 || *g != 2) 2048fab14cfd860 Nicolai Stange 2021-12-01 486 return dh_group_id_unknown; 2048fab14cfd860 Nicolai Stange 2021-12-01 487 2048fab14cfd860 Nicolai Stange 2021-12-01 488 while (p_size && !*p) { 2048fab14cfd860 Nicolai Stange 2021-12-01 489 ++p; 2048fab14cfd860 Nicolai Stange 2021-12-01 490 --p_size; 2048fab14cfd860 Nicolai Stange 2021-12-01 491 } 2048fab14cfd860 Nicolai Stange 2021-12-01 492 2048fab14cfd860 Nicolai Stange 2021-12-01 @493 for (i = 0; i < ARRAY_SIZE(safe_prime_groups); ++i) { 2048fab14cfd860 Nicolai Stange 2021-12-01 494 if (safe_prime_groups[i].p_size != p_size) 2048fab14cfd860 Nicolai Stange 2021-12-01 495 continue; 2048fab14cfd860 Nicolai Stange 2021-12-01 496 2048fab14cfd860 Nicolai Stange 2021-12-01 497 if (!memcmp(safe_prime_groups[i].p, p, p_size)) 2048fab14cfd860 Nicolai Stange 2021-12-01 498 return safe_prime_groups[i].group_id; 2048fab14cfd860 Nicolai Stange 2021-12-01 499 } 2048fab14cfd860 Nicolai Stange 2021-12-01 500 2048fab14cfd860 Nicolai Stange 2021-12-01 501 return dh_group_id_unknown; 2048fab14cfd860 Nicolai Stange 2021-12-01 502 } 2048fab14cfd860 Nicolai Stange 2021-12-01 503 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
