CC: [email protected] CC: [email protected] TO: Andrea Arcangeli <[email protected]> CC: Andrew Morton <[email protected]> CC: Linux Memory Management List <[email protected]> CC: [email protected]
From: kernel test robot <[email protected]> mm/huge_memory.c:1987:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) Use BUG_ON instead of a if condition followed by BUG. Semantic patch information: This makes an effort to find cases where BUG() follows an if condition on an expression and replaces the if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. Generated by: scripts/coccinelle/misc/bugon.cocci Fixes: f656fca095ea ("userfaultfd: UFFDIO_REMAP uABI") Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git main head: e37fc15fcde08ff18027c1a1e34b2371ac2c449b commit: f656fca095eaa2bc257fee306e02c92f229031c9 [38/50] userfaultfd: UFFDIO_REMAP uABI :::::: branch date: 23 hours ago :::::: commit date: 23 hours ago Please take the patch only if it's a positive warning. Thanks! huge_memory.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1982,9 +1982,7 @@ int remap_pages_huge_pmd(struct mm_struc WRITE_ONCE(src_page->mapping, (struct address_space *) dst_anon_vma); WRITE_ONCE(src_page->index, linear_page_index(dst_vma, dst_addr)); - if (!pmd_same(pmdp_huge_clear_flush(src_vma, src_addr, src_pmd), - src_pmdval)) - BUG(); + BUG_ON(!pmd_same(pmdp_huge_clear_flush(src_vma, src_addr, src_pmd), src_pmdval)); _dst_pmd = mk_huge_pmd(src_page, dst_vma->vm_page_prot); _dst_pmd = maybe_pmd_mkwrite(pmd_mkdirty(_dst_pmd), dst_vma); set_pmd_at(dst_mm, dst_addr, dst_pmd, _dst_pmd); _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
