CC: [email protected] CC: [email protected] TO: Masahiro Yamada <[email protected]> CC: Andrew Morton <[email protected]> CC: Linux Memory Management List <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e2ae0d4a6b0ba461542f0fd0ba0b828658013e9f commit: ea29b20a828511de3348334e529a3d046a180416 init/Kconfig: make COMPILE_TEST depend on HAS_IOMEM date: 10 months ago :::::: branch date: 8 hours ago :::::: commit date: 10 months ago compiler: s390-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/mmc/host/renesas_sdhi_core.c:701:0: warning: Same expression used in >> consecutive assignments of 'new_tap' and 'error_tap'. >> [duplicateAssignExpression] unsigned int new_tap = priv->tap_set, error_tap = priv->tap_set; ^ drivers/mmc/host/renesas_sdhi_core.c:701:0: note: Same expression used in consecutive assignments of 'new_tap' and 'error_tap'. unsigned int new_tap = priv->tap_set, error_tap = priv->tap_set; ^ drivers/mmc/host/renesas_sdhi_core.c:701:0: note: Same expression used in consecutive assignments of 'new_tap' and 'error_tap'. unsigned int new_tap = priv->tap_set, error_tap = priv->tap_set; ^ vim +701 drivers/mmc/host/renesas_sdhi_core.c 0c482d829ac413 Wolfram Sang 2020-01-29 697 11a219606a9bc7 Takeshi Saito 2019-12-17 698 static bool renesas_sdhi_manual_correction(struct tmio_mmc_host *host, bool use_4tap) 11a219606a9bc7 Takeshi Saito 2019-12-17 699 { 11a219606a9bc7 Takeshi Saito 2019-12-17 700 struct renesas_sdhi *priv = host_to_priv(host); a38c078fea0b13 Takeshi Saito 2020-04-23 @701 unsigned int new_tap = priv->tap_set, error_tap = priv->tap_set; 11a219606a9bc7 Takeshi Saito 2019-12-17 702 u32 val; 11a219606a9bc7 Takeshi Saito 2019-12-17 703 11a219606a9bc7 Takeshi Saito 2019-12-17 704 val = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ); 11a219606a9bc7 Takeshi Saito 2019-12-17 705 if (!val) 11a219606a9bc7 Takeshi Saito 2019-12-17 706 return false; 11a219606a9bc7 Takeshi Saito 2019-12-17 707 11a219606a9bc7 Takeshi Saito 2019-12-17 708 sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ, 0); 11a219606a9bc7 Takeshi Saito 2019-12-17 709 11a219606a9bc7 Takeshi Saito 2019-12-17 710 /* Change TAP position according to correction status */ 71cfc92751ac7a Takeshi Saito 2019-12-17 711 if (sd_ctrl_read16(host, CTL_VERSION) == SDHI_VER_GEN3_SDMMC && 71cfc92751ac7a Takeshi Saito 2019-12-17 712 host->mmc->ios.timing == MMC_TIMING_MMC_HS400) { a38c078fea0b13 Takeshi Saito 2020-04-23 713 u32 bad_taps = priv->quirks ? priv->quirks->hs400_bad_taps : 0; 71cfc92751ac7a Takeshi Saito 2019-12-17 714 /* 71cfc92751ac7a Takeshi Saito 2019-12-17 715 * With HS400, the DAT signal is based on DS, not CLK. 71cfc92751ac7a Takeshi Saito 2019-12-17 716 * Therefore, use only CMD status. 71cfc92751ac7a Takeshi Saito 2019-12-17 717 */ 71cfc92751ac7a Takeshi Saito 2019-12-17 718 u32 smpcmp = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_SMPCMP) & 71cfc92751ac7a Takeshi Saito 2019-12-17 719 SH_MOBILE_SDHI_SCC_SMPCMP_CMD_ERR; a38c078fea0b13 Takeshi Saito 2020-04-23 720 if (!smpcmp) { 71cfc92751ac7a Takeshi Saito 2019-12-17 721 return false; /* no error in CMD signal */ a38c078fea0b13 Takeshi Saito 2020-04-23 722 } else if (smpcmp == SH_MOBILE_SDHI_SCC_SMPCMP_CMD_REQUP) { 71cfc92751ac7a Takeshi Saito 2019-12-17 723 new_tap++; a38c078fea0b13 Takeshi Saito 2020-04-23 724 error_tap--; a38c078fea0b13 Takeshi Saito 2020-04-23 725 } else if (smpcmp == SH_MOBILE_SDHI_SCC_SMPCMP_CMD_REQDOWN) { 71cfc92751ac7a Takeshi Saito 2019-12-17 726 new_tap--; a38c078fea0b13 Takeshi Saito 2020-04-23 727 error_tap++; a38c078fea0b13 Takeshi Saito 2020-04-23 728 } else { 71cfc92751ac7a Takeshi Saito 2019-12-17 729 return true; /* need retune */ a38c078fea0b13 Takeshi Saito 2020-04-23 730 } a38c078fea0b13 Takeshi Saito 2020-04-23 731 a38c078fea0b13 Takeshi Saito 2020-04-23 732 /* a38c078fea0b13 Takeshi Saito 2020-04-23 733 * When new_tap is a bad tap, we cannot change. Then, we compare a38c078fea0b13 Takeshi Saito 2020-04-23 734 * with the HS200 tuning result. When smpcmp[error_tap] is OK, a38c078fea0b13 Takeshi Saito 2020-04-23 735 * we can at least retune. a38c078fea0b13 Takeshi Saito 2020-04-23 736 */ a38c078fea0b13 Takeshi Saito 2020-04-23 737 if (bad_taps & BIT(new_tap % priv->tap_num)) a38c078fea0b13 Takeshi Saito 2020-04-23 738 return test_bit(error_tap % priv->tap_num, priv->smpcmp); 71cfc92751ac7a Takeshi Saito 2019-12-17 739 } else { 11a219606a9bc7 Takeshi Saito 2019-12-17 740 if (val & SH_MOBILE_SDHI_SCC_RVSREQ_RVSERR) 71cfc92751ac7a Takeshi Saito 2019-12-17 741 return true; /* need retune */ 11a219606a9bc7 Takeshi Saito 2019-12-17 742 else if (val & SH_MOBILE_SDHI_SCC_RVSREQ_REQTAPUP) 71cfc92751ac7a Takeshi Saito 2019-12-17 743 new_tap++; 11a219606a9bc7 Takeshi Saito 2019-12-17 744 else if (val & SH_MOBILE_SDHI_SCC_RVSREQ_REQTAPDOWN) 71cfc92751ac7a Takeshi Saito 2019-12-17 745 new_tap--; 11a219606a9bc7 Takeshi Saito 2019-12-17 746 else 11a219606a9bc7 Takeshi Saito 2019-12-17 747 return false; 71cfc92751ac7a Takeshi Saito 2019-12-17 748 } 11a219606a9bc7 Takeshi Saito 2019-12-17 749 b2dd9a1325e680 Wolfram Sang 2020-01-29 750 priv->tap_set = (new_tap % priv->tap_num); 11a219606a9bc7 Takeshi Saito 2019-12-17 751 sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_TAPSET, b2dd9a1325e680 Wolfram Sang 2020-01-29 752 priv->tap_set / (use_4tap ? 2 : 1)); 11a219606a9bc7 Takeshi Saito 2019-12-17 753 11a219606a9bc7 Takeshi Saito 2019-12-17 754 return false; 11a219606a9bc7 Takeshi Saito 2019-12-17 755 } 11a219606a9bc7 Takeshi Saito 2019-12-17 756 :::::: The code at line 701 was first introduced by commit :::::: a38c078fea0b1393fd2acb50e91057d7e429d9aa mmc: renesas_sdhi: Avoid bad TAP in HS400 :::::: TO: Takeshi Saito <[email protected]> :::::: CC: Ulf Hansson <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
