CC: [email protected] CC: [email protected] CC: [email protected] TO: Konstantin Komarov <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4634129ad9fdc89d10b597fc6f8f4336fb61e105 commit: 6e5be40d32fb1907285277c02e74493ed43d77fe fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile date: 5 months ago :::::: branch date: 12 hours ago :::::: commit date: 5 months ago config: mips-randconfig-c004-20220107 (https://download.01.org/0day-ci/archive/20220109/[email protected]/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 32167bfe64a4c5dd4eb3f7a58e24f4cba76f5ac2) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e5be40d32fb1907285277c02e74493ed43d77fe git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 6e5be40d32fb1907285277c02e74493ed43d77fe # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> clang-analyzer warnings: (new ones prefixed by >>) drivers/hwmon/max31730.c:201:3: note: Execution continues on line 219 break; ^ drivers/hwmon/max31730.c:219:8: note: Assuming '__UNIQUE_ID___x341' is <= '__UNIQUE_ID___y342' val = clamp_val(val, MAX31730_TEMP_MIN, MAX31730_TEMP_MAX); ^ include/linux/minmax.h:137:32: note: expanded from macro 'clamp_val' #define clamp_val(val, lo, hi) clamp_t(typeof(val), val, lo, hi) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:124:48: note: expanded from macro 'clamp_t' #define clamp_t(type, val, lo, hi) min_t(type, max_t(type, val, lo), hi) ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:112:27: note: expanded from macro 'max_t' #define max_t(type, x, y) __careful_cmp((type)(x), (type)(y), >) ^ note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all) include/linux/minmax.h:104:48: note: expanded from macro 'min_t' #define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <) ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ include/linux/minmax.h:38:14: note: expanded from macro '__careful_cmp' __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:31:25: note: expanded from macro '__cmp_once' typeof(x) unique_x = (x); \ ^ drivers/hwmon/max31730.c:219:8: note: '?' condition is false val = clamp_val(val, MAX31730_TEMP_MIN, MAX31730_TEMP_MAX); ^ include/linux/minmax.h:137:32: note: expanded from macro 'clamp_val' #define clamp_val(val, lo, hi) clamp_t(typeof(val), val, lo, hi) ^ include/linux/minmax.h:124:48: note: expanded from macro 'clamp_t' #define clamp_t(type, val, lo, hi) min_t(type, max_t(type, val, lo), hi) ^ include/linux/minmax.h:112:27: note: expanded from macro 'max_t' #define max_t(type, x, y) __careful_cmp((type)(x), (type)(y), >) ^ include/linux/minmax.h:38:3: note: expanded from macro '__careful_cmp' __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) ^ include/linux/minmax.h:33:3: note: expanded from macro '__cmp_once' __cmp(unique_x, unique_y, op); }) ^ include/linux/minmax.h:28:26: note: expanded from macro '__cmp' #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) ^ drivers/hwmon/max31730.c:219:8: note: '__UNIQUE_ID___x343' is < '__UNIQUE_ID___y344' val = clamp_val(val, MAX31730_TEMP_MIN, MAX31730_TEMP_MAX); ^ include/linux/minmax.h:137:32: note: expanded from macro 'clamp_val' #define clamp_val(val, lo, hi) clamp_t(typeof(val), val, lo, hi) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:124:36: note: expanded from macro 'clamp_t' #define clamp_t(type, val, lo, hi) min_t(type, max_t(type, val, lo), hi) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:104:27: note: expanded from macro 'min_t' #define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:38:3: note: expanded from macro '__careful_cmp' __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:33:3: note: expanded from macro '__cmp_once' __cmp(unique_x, unique_y, op); }) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:28:26: note: expanded from macro '__cmp' #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) ^~~ drivers/hwmon/max31730.c:219:8: note: '?' condition is true val = clamp_val(val, MAX31730_TEMP_MIN, MAX31730_TEMP_MAX); ^ include/linux/minmax.h:137:32: note: expanded from macro 'clamp_val' #define clamp_val(val, lo, hi) clamp_t(typeof(val), val, lo, hi) ^ include/linux/minmax.h:124:36: note: expanded from macro 'clamp_t' #define clamp_t(type, val, lo, hi) min_t(type, max_t(type, val, lo), hi) ^ include/linux/minmax.h:104:27: note: expanded from macro 'min_t' #define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <) ^ include/linux/minmax.h:38:3: note: expanded from macro '__careful_cmp' __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) ^ include/linux/minmax.h:33:3: note: expanded from macro '__cmp_once' __cmp(unique_x, unique_y, op); }) ^ include/linux/minmax.h:28:26: note: expanded from macro '__cmp' #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) ^ drivers/hwmon/max31730.c:219:2: note: The value -128000 is assigned to 'val' val = clamp_val(val, MAX31730_TEMP_MIN, MAX31730_TEMP_MAX); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hwmon/max31730.c:220:30: note: The result of the left shift is undefined because the left operand is negative val = DIV_ROUND_CLOSEST(val << 4, 1000) << 4; ^ include/linux/math.h:87:18: note: expanded from macro 'DIV_ROUND_CLOSEST' typeof(x) __x = x; \ ^ Suppressed 2 warnings (2 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 5 warnings generated. >> fs/ntfs3/file.c:37:17: warning: Assigned value is garbage or undefined >> [clang-analyzer-core.uninitialized.Assign] range.minlen = max_t(u32, range.minlen, q->limits.discard_granularity); ^ include/linux/minmax.h:112:27: note: expanded from macro 'max_t' #define max_t(type, x, y) __careful_cmp((type)(x), (type)(y), >) ^ include/linux/minmax.h:38:3: note: expanded from macro '__careful_cmp' __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) ^ include/linux/minmax.h:31:3: note: expanded from macro '__cmp_once' typeof(x) unique_x = (x); \ ^ fs/ntfs3/file.c:55:2: note: Control jumps to 'case 3222820985:' at line 62 switch (cmd) { ^ fs/ntfs3/file.c:63:10: note: Calling 'ntfs_ioctl_fitrim' return ntfs_ioctl_fitrim(sbi, arg); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/ntfs3/file.c:27:7: note: Calling 'capable' if (!capable(CAP_SYS_ADMIN)) ^~~~~~~~~~~~~~~~~~~~~~ include/linux/capability.h:235:2: note: Returning the value 1, which participates in a condition later return true; ^~~~~~~~~~~ fs/ntfs3/file.c:27:7: note: Returning from 'capable' if (!capable(CAP_SYS_ADMIN)) ^~~~~~~~~~~~~~~~~~~~~~ fs/ntfs3/file.c:27:2: note: Taking false branch if (!capable(CAP_SYS_ADMIN)) ^ fs/ntfs3/file.c:30:6: note: Assuming the condition is false if (!blk_queue_discard(q)) ^~~~~~~~~~~~~~~~~~~~~ fs/ntfs3/file.c:30:2: note: Taking false branch if (!blk_queue_discard(q)) ^ fs/ntfs3/file.c:34:6: note: Calling 'copy_from_user' if (copy_from_user(&range, user_range, sizeof(range))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/uaccess.h:191:2: note: Taking true branch if (likely(check_copy_size(to, n, false))) ^ include/linux/uaccess.h:192:7: note: Calling '_copy_from_user' n = _copy_from_user(to, from, n); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/uaccess.h:157:7: note: Calling 'should_fail_usercopy' if (!should_fail_usercopy() && likely(access_ok(from, n))) { ^~~~~~~~~~~~~~~~~~~~~~ include/linux/fault-inject-usercopy.h:18:49: note: Returning zero, which participates in a condition later static inline bool should_fail_usercopy(void) { return false; } ^~~~~~~~~~~~ include/linux/uaccess.h:157:7: note: Returning from 'should_fail_usercopy' if (!should_fail_usercopy() && likely(access_ok(from, n))) { ^~~~~~~~~~~~~~~~~~~~~~ include/linux/uaccess.h:157:6: note: Left side of '&&' is true if (!should_fail_usercopy() && likely(access_ok(from, n))) { ^ include/linux/uaccess.h:157:2: note: Taking true branch if (!should_fail_usercopy() && likely(access_ok(from, n))) { ^ include/linux/uaccess.h:159:9: note: Calling 'raw_copy_from_user' res = raw_copy_from_user(to, from, n); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/include/asm/uaccess.h:456:2: note: Returning without writing to 'to->minlen' return __cu_len_r; ^ include/linux/uaccess.h:159:9: note: Returning from 'raw_copy_from_user' res = raw_copy_from_user(to, from, n); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/uaccess.h:161:6: note: Assuming 'res' is 0, which participates in a condition later if (unlikely(res)) ^ include/linux/compiler.h:78:40: note: expanded from macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^~~~ include/linux/uaccess.h:161:2: note: Taking false branch if (unlikely(res)) ^ include/linux/uaccess.h:163:2: note: Returning without writing to 'to->minlen' return res; ^ include/linux/uaccess.h:163:2: note: Returning zero (loaded from 'res'), which participates in a condition later return res; ^~~~~~~~~~ include/linux/uaccess.h:192:7: note: Returning from '_copy_from_user' n = _copy_from_user(to, from, n); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/uaccess.h:193:2: note: Returning without writing to 'to->minlen' return n; ^ include/linux/uaccess.h:193:2: note: Returning zero (loaded from 'n'), which participates in a condition later return n; ^~~~~~~~ fs/ntfs3/file.c:34:6: note: Returning from 'copy_from_user' if (copy_from_user(&range, user_range, sizeof(range))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/ntfs3/file.c:34:2: note: Taking false branch if (copy_from_user(&range, user_range, sizeof(range))) ^ fs/ntfs3/file.c:37:17: note: Assigned value is garbage or undefined range.minlen = max_t(u32, range.minlen, q->limits.discard_granularity); vim +37 fs/ntfs3/file.c 4342306f0f0d5f Konstantin Komarov 2021-08-13 19 4342306f0f0d5f Konstantin Komarov 2021-08-13 20 static int ntfs_ioctl_fitrim(struct ntfs_sb_info *sbi, unsigned long arg) 4342306f0f0d5f Konstantin Komarov 2021-08-13 21 { 4342306f0f0d5f Konstantin Komarov 2021-08-13 22 struct fstrim_range __user *user_range; 4342306f0f0d5f Konstantin Komarov 2021-08-13 23 struct fstrim_range range; 4342306f0f0d5f Konstantin Komarov 2021-08-13 24 struct request_queue *q = bdev_get_queue(sbi->sb->s_bdev); 4342306f0f0d5f Konstantin Komarov 2021-08-13 25 int err; 4342306f0f0d5f Konstantin Komarov 2021-08-13 26 4342306f0f0d5f Konstantin Komarov 2021-08-13 27 if (!capable(CAP_SYS_ADMIN)) 4342306f0f0d5f Konstantin Komarov 2021-08-13 28 return -EPERM; 4342306f0f0d5f Konstantin Komarov 2021-08-13 29 4342306f0f0d5f Konstantin Komarov 2021-08-13 30 if (!blk_queue_discard(q)) 4342306f0f0d5f Konstantin Komarov 2021-08-13 31 return -EOPNOTSUPP; 4342306f0f0d5f Konstantin Komarov 2021-08-13 32 4342306f0f0d5f Konstantin Komarov 2021-08-13 33 user_range = (struct fstrim_range __user *)arg; 4342306f0f0d5f Konstantin Komarov 2021-08-13 34 if (copy_from_user(&range, user_range, sizeof(range))) 4342306f0f0d5f Konstantin Komarov 2021-08-13 35 return -EFAULT; 4342306f0f0d5f Konstantin Komarov 2021-08-13 36 4342306f0f0d5f Konstantin Komarov 2021-08-13 @37 range.minlen = max_t(u32, range.minlen, q->limits.discard_granularity); 4342306f0f0d5f Konstantin Komarov 2021-08-13 38 4342306f0f0d5f Konstantin Komarov 2021-08-13 39 err = ntfs_trim_fs(sbi, &range); 4342306f0f0d5f Konstantin Komarov 2021-08-13 40 if (err < 0) 4342306f0f0d5f Konstantin Komarov 2021-08-13 41 return err; 4342306f0f0d5f Konstantin Komarov 2021-08-13 42 4342306f0f0d5f Konstantin Komarov 2021-08-13 43 if (copy_to_user(user_range, &range, sizeof(range))) 4342306f0f0d5f Konstantin Komarov 2021-08-13 44 return -EFAULT; 4342306f0f0d5f Konstantin Komarov 2021-08-13 45 4342306f0f0d5f Konstantin Komarov 2021-08-13 46 return 0; 4342306f0f0d5f Konstantin Komarov 2021-08-13 47 } 4342306f0f0d5f Konstantin Komarov 2021-08-13 48 :::::: The code at line 37 was first introduced by commit :::::: 4342306f0f0d5ff4315a204d315c1b51b914fca5 fs/ntfs3: Add file operations and implementation :::::: TO: Konstantin Komarov <[email protected]> :::::: CC: Konstantin Komarov <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
