CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Josh Don <[email protected]>
TO: Tejun Heo <[email protected]>
TO: Zefan Li <[email protected]>
TO: Johannes Weiner <[email protected]>
TO: Ingo Molnar <[email protected]>
TO: Peter Zijlstra <[email protected]>
TO: Juri Lelli <[email protected]>
TO: Vincent Guittot <[email protected]>
CC: Dietmar Eggemann <[email protected]>
CC: Steven Rostedt <[email protected]>
CC: Ben Segall <[email protected]>

Hi Josh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tj-cgroup/for-next]
[also build test WARNING on tip/sched/core tip/master v5.16-rc8 next-20220107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Josh-Don/cgroup-add-cpu-stat_percpu/20220108-074316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
:::::: branch date: 35 hours ago
:::::: commit date: 35 hours ago
config: x86_64-randconfig-m001-20220107 
(https://download.01.org/0day-ci/archive/20220109/[email protected]/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
kernel/cgroup/rstat.c:531 cgroup_base_stat_percpu_cputime_show() warn: sleeping 
in atomic context

vim +531 kernel/cgroup/rstat.c

d70517c43ca623 Josh Don 2022-01-07  515  
d70517c43ca623 Josh Don 2022-01-07  516  void 
cgroup_base_stat_percpu_cputime_show(struct seq_file *seq)
d70517c43ca623 Josh Don 2022-01-07  517  {
d70517c43ca623 Josh Don 2022-01-07  518         static DEFINE_MUTEX(mutex);
d70517c43ca623 Josh Don 2022-01-07  519         static DEFINE_PER_CPU(struct 
cgroup_base_stat, cached_percpu_stats);
d70517c43ca623 Josh Don 2022-01-07  520         struct cgroup_base_stat 
*cached_bstat;
d70517c43ca623 Josh Don 2022-01-07  521         struct cgroup *cgrp = 
seq_css(seq)->cgroup;
d70517c43ca623 Josh Don 2022-01-07  522         u64 val;
d70517c43ca623 Josh Don 2022-01-07  523         int cpu;
d70517c43ca623 Josh Don 2022-01-07  524  
d70517c43ca623 Josh Don 2022-01-07  525         /* protects cached_percpu_stats 
*/
d70517c43ca623 Josh Don 2022-01-07  526         mutex_lock(&mutex);
d70517c43ca623 Josh Don 2022-01-07  527  
d70517c43ca623 Josh Don 2022-01-07  528         if (cgroup_parent(cgrp)) {
d70517c43ca623 Josh Don 2022-01-07  529                 struct cgroup_base_stat 
*bstat_cpu;
d70517c43ca623 Josh Don 2022-01-07  530  
d70517c43ca623 Josh Don 2022-01-07 @531                 
cgroup_rstat_flush_hold(cgrp);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to