CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Hao Xu <[email protected]> TO: [email protected] TO: [email protected] CC: Jens Axboe <[email protected]> CC: Pavel Begunkov <[email protected]> CC: Eric Dumazet <[email protected]> CC: "David S . Miller" <[email protected]> CC: Jakub Kicinski <[email protected]> CC: Hideaki YOSHIFUJI <[email protected]> CC: David Ahern <[email protected]> CC: Joseph Qi <[email protected]>
Hi Hao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.17-rc1 next-20220124] [cannot apply to horms-ipvs/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hao-Xu/io_uring-zerocopy-receive/20220124-174546 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0 :::::: branch date: 7 hours ago :::::: commit date: 7 hours ago config: x86_64-randconfig-m001-20220124 (https://download.01.org/0day-ci/archive/20220125/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: net/ipv4/tcp.c:3951 zc_receive_check() warn: check for integer overflow 'len' vim +/len +3951 net/ipv4/tcp.c 1c885808e45601 Francis Yan 2016-11-27 3938 8ed32d9a0fe79a Hao Xu 2022-01-24 3939 int zc_receive_check(struct tcp_zerocopy_receive *zc, int *lenp, 8ed32d9a0fe79a Hao Xu 2022-01-24 3940 char __user *optval, int __user *optlen) 8ed32d9a0fe79a Hao Xu 2022-01-24 3941 { 8ed32d9a0fe79a Hao Xu 2022-01-24 3942 int len = *lenp, err; 8ed32d9a0fe79a Hao Xu 2022-01-24 3943 8ed32d9a0fe79a Hao Xu 2022-01-24 3944 if (get_user(len, optlen)) 8ed32d9a0fe79a Hao Xu 2022-01-24 3945 return -EFAULT; 8ed32d9a0fe79a Hao Xu 2022-01-24 3946 if (len < 0 || 8ed32d9a0fe79a Hao Xu 2022-01-24 3947 len < offsetofend(struct tcp_zerocopy_receive, length)) 8ed32d9a0fe79a Hao Xu 2022-01-24 3948 return -EINVAL; 8ed32d9a0fe79a Hao Xu 2022-01-24 3949 if (unlikely(len > sizeof(*zc))) { 8ed32d9a0fe79a Hao Xu 2022-01-24 3950 err = check_zeroed_user(optval + sizeof(*zc), 8ed32d9a0fe79a Hao Xu 2022-01-24 @3951 len - sizeof(*zc)); 8ed32d9a0fe79a Hao Xu 2022-01-24 3952 if (err < 1) 8ed32d9a0fe79a Hao Xu 2022-01-24 3953 return err == 0 ? -EINVAL : err; 8ed32d9a0fe79a Hao Xu 2022-01-24 3954 len = sizeof(*zc); 8ed32d9a0fe79a Hao Xu 2022-01-24 3955 if (put_user(len, optlen)) 8ed32d9a0fe79a Hao Xu 2022-01-24 3956 return -EFAULT; 8ed32d9a0fe79a Hao Xu 2022-01-24 3957 } 8ed32d9a0fe79a Hao Xu 2022-01-24 3958 if (copy_from_user(zc, optval, len)) 8ed32d9a0fe79a Hao Xu 2022-01-24 3959 return -EFAULT; 8ed32d9a0fe79a Hao Xu 2022-01-24 3960 8ed32d9a0fe79a Hao Xu 2022-01-24 3961 if (zc->reserved) 8ed32d9a0fe79a Hao Xu 2022-01-24 3962 return -EINVAL; 8ed32d9a0fe79a Hao Xu 2022-01-24 3963 if (zc->msg_flags & ~(TCP_VALID_ZC_MSG_FLAGS)) 8ed32d9a0fe79a Hao Xu 2022-01-24 3964 return -EINVAL; 8ed32d9a0fe79a Hao Xu 2022-01-24 3965 8ed32d9a0fe79a Hao Xu 2022-01-24 3966 *lenp = len; 8ed32d9a0fe79a Hao Xu 2022-01-24 3967 return 0; 8ed32d9a0fe79a Hao Xu 2022-01-24 3968 } 8ed32d9a0fe79a Hao Xu 2022-01-24 3969 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
