CC: [email protected] CC: [email protected] CC: [email protected] TO: Thomas Gleixner <[email protected]> CC: Ingo Molnar <[email protected]> CC: "Peter Zijlstra (Intel)" <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8 commit: 531ae4b06a737ed5539cd75dc6f6b9a28f900bba locking/rtmutex: Split API from implementation date: 5 months ago :::::: branch date: 34 hours ago :::::: commit date: 5 months ago config: riscv-randconfig-c006-20220121 (https://download.01.org/0day-ci/archive/20220127/[email protected]/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d4baf3b1322b84816aa623d8e8cb45a49cb68b84) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=531ae4b06a737ed5539cd75dc6f6b9a28f900bba git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 531ae4b06a737ed5539cd75dc6f6b9a28f900bba # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> clang-analyzer warnings: (new ones prefixed by >>) ^~~~~~ fs/orangefs/orangefs-debugfs.c:752:5: note: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat(kernel_debug_string, ","); ^~~~~~ fs/orangefs/orangefs-debugfs.c:777:5: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy] strcat(client_debug_string, ^~~~~~ fs/orangefs/orangefs-debugfs.c:777:5: note: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat(client_debug_string, ^~~~~~ fs/orangefs/orangefs-debugfs.c:779:5: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy] strcat(client_debug_string, ","); ^~~~~~ fs/orangefs/orangefs-debugfs.c:779:5: note: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat(client_debug_string, ","); ^~~~~~ Suppressed 14 warnings (7 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. lib/glob.c:48:32: warning: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign] char const *back_pat = NULL, *back_str = back_str; ^ ~~~~~~~~ lib/glob.c:48:32: note: Assigned value is garbage or undefined char const *back_pat = NULL, *back_str = back_str; ^ ~~~~~~~~ Suppressed 5 warnings (5 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 5 warnings generated. Suppressed 5 warnings (5 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 14 warnings generated. lib/mpi/ec.c:396:2: warning: Value stored to 'cy' is never read [clang-analyzer-deadcode.DeadStores] cy += mpihelp_add_n(b0, b0, a3, LIMB_SIZE_HALF_448); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/mpi/ec.c:396:2: note: Value stored to 'cy' is never read cy += mpihelp_add_n(b0, b0, a3, LIMB_SIZE_HALF_448); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/mpi/ec.c:410:2: warning: Value stored to 'cy' is never read [clang-analyzer-deadcode.DeadStores] cy += mpihelp_add_n(b1, b1, a3, LIMB_SIZE_HALF_448); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/mpi/ec.c:410:2: note: Value stored to 'cy' is never read cy += mpihelp_add_n(b1, b1, a3, LIMB_SIZE_HALF_448); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 19 warnings generated. Suppressed 19 warnings (12 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 19 warnings generated. Suppressed 19 warnings (12 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 19 warnings generated. Suppressed 19 warnings (12 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 11 warnings generated. Suppressed 11 warnings (4 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 12 warnings generated. Suppressed 12 warnings (5 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. Suppressed 6 warnings (4 in non-user code, 2 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 4 warnings generated. Suppressed 4 warnings (4 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 11 warnings generated. Suppressed 11 warnings (4 in non-user code, 7 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 2 warnings generated. Suppressed 2 warnings (2 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 6 warnings generated. >> arch/riscv/include/asm/spinlock.h:24:2: warning: Dereference of null pointer >> [clang-analyzer-core.NullDereference] smp_store_release(&lock->lock, 0); ^ include/asm-generic/barrier.h:138:33: note: expanded from macro 'smp_store_release' #define smp_store_release(p, v) __smp_store_release(p, v) ^ arch/riscv/include/asm/barrier.h:34:2: note: expanded from macro '__smp_store_release' WRITE_ONCE(*p, v); \ ^ include/asm-generic/rwonce.h:61:2: note: expanded from macro 'WRITE_ONCE' __WRITE_ONCE(x, val); \ ^ include/asm-generic/rwonce.h:55:30: note: expanded from macro '__WRITE_ONCE' *(volatile typeof(x) *)&(x) = (val); \ ^ kernel/locking/rtmutex_api.c:419:2: note: Loop condition is false. Exiting loop raw_spin_lock_irqsave(&task->pi_lock, flags); ^ include/linux/spinlock.h:250:2: note: expanded from macro 'raw_spin_lock_irqsave' do { \ ^ kernel/locking/rtmutex_api.c:422:6: note: Assuming 'waiter' is non-null if (!waiter || rt_mutex_waiter_equal(waiter, task_to_waiter(task))) { ^~~~~~~ kernel/locking/rtmutex_api.c:422:6: note: Left side of '||' is false kernel/locking/rtmutex_api.c:422:2: note: Taking false branch if (!waiter || rt_mutex_waiter_equal(waiter, task_to_waiter(task))) { ^ kernel/locking/rtmutex_api.c:427:2: note: Loop condition is false. Exiting loop raw_spin_unlock_irqrestore(&task->pi_lock, flags); ^ include/linux/spinlock.h:288:2: note: expanded from macro 'raw_spin_unlock_irqrestore' do { \ ^ kernel/locking/rtmutex_api.c:432:2: note: Calling 'rt_mutex_adjust_prio_chain' rt_mutex_adjust_prio_chain(task, RT_MUTEX_MIN_CHAINWALK, NULL, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:466:6: note: Assuming the condition is false if (++depth > max_lock_depth) { ^~~~~~~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:466:2: note: Taking false branch if (++depth > max_lock_depth) { ^ kernel/locking/rtmutex.c:510:6: note: Assuming 'waiter' is non-null if (!waiter) ^~~~~~~ kernel/locking/rtmutex.c:510:2: note: Taking false branch if (!waiter) ^ kernel/locking/rtmutex.c:517:6: note: 'orig_waiter' is null if (orig_waiter && !rt_mutex_owner(orig_lock)) ^~~~~~~~~~~ kernel/locking/rtmutex.c:517:18: note: Left side of '&&' is false if (orig_waiter && !rt_mutex_owner(orig_lock)) ^ kernel/locking/rtmutex.c:529:6: note: Assuming 'next_lock' is equal to field 'lock' if (next_lock != waiter->lock) ^~~~~~~~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:529:2: note: Taking false branch if (next_lock != waiter->lock) ^ kernel/locking/rtmutex.c:537:6: note: 'top_waiter' is null if (top_waiter) { ^~~~~~~~~~ kernel/locking/rtmutex.c:537:2: note: Taking false branch if (top_waiter) { ^ kernel/locking/rtmutex.c:561:6: note: Calling 'rt_mutex_waiter_equal' if (rt_mutex_waiter_equal(waiter, task_to_waiter(task))) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:274:6: note: Assuming 'left->prio' is not equal to 'right->prio' if (left->prio != right->prio) ^~~~~~~~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:274:2: note: Taking true branch if (left->prio != right->prio) ^ kernel/locking/rtmutex.c:275:3: note: Returning without writing to 'left->lock' return 0; ^ kernel/locking/rtmutex.c:275:3: note: Returning zero, which participates in a condition later return 0; ^~~~~~~~ kernel/locking/rtmutex.c:561:6: note: Returning from 'rt_mutex_waiter_equal' if (rt_mutex_waiter_equal(waiter, task_to_waiter(task))) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:561:2: note: Taking false branch if (rt_mutex_waiter_equal(waiter, task_to_waiter(task))) { ^ kernel/locking/rtmutex.c:571:2: note: Value assigned to 'lock' lock = waiter->lock; ^~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:577:6: note: Assuming the condition is false if (!raw_spin_trylock(&lock->wait_lock)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:577:2: note: Taking false branch if (!raw_spin_trylock(&lock->wait_lock)) { ^ kernel/locking/rtmutex.c:592:6: note: Assuming 'lock' is equal to 'orig_lock' if (lock == orig_lock || rt_mutex_owner(lock) == top_task) { ^~~~~~~~~~~~~~~~~ kernel/locking/rtmutex.c:592:24: note: Left side of '||' is true vim +24 arch/riscv/include/asm/spinlock.h fab957c11efe2f4 Palmer Dabbelt 2017-07-10 21 fab957c11efe2f4 Palmer Dabbelt 2017-07-10 22 static inline void arch_spin_unlock(arch_spinlock_t *lock) fab957c11efe2f4 Palmer Dabbelt 2017-07-10 23 { 0123f4d76ca63b7 Andrea Parri 2018-03-09 @24 smp_store_release(&lock->lock, 0); fab957c11efe2f4 Palmer Dabbelt 2017-07-10 25 } fab957c11efe2f4 Palmer Dabbelt 2017-07-10 26 :::::: The code at line 24 was first introduced by commit :::::: 0123f4d76ca63b7b895f40089be0ce4809e392d8 riscv/spinlock: Strengthen implementations with fences :::::: TO: Andrea Parri <[email protected]> :::::: CC: Palmer Dabbelt <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
