CC: [email protected] CC: [email protected] CC: [email protected] TO: James Morse <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/snapshot/v5.16 head: 364c1c42b229912132e1615c2ce15be7154e2156 commit: d1a658d708e01bea1213624ee4c5dba135b3cb4d [63/137] x86/resctrl: Move resctrl to live in /fs/ :::::: branch date: 2 days ago :::::: commit date: 2 days ago config: x86_64-randconfig-c007-20220124 (https://download.01.org/0day-ci/archive/20220127/[email protected]/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 2a1b7aa016c0f4b5598806205bdfbab1ea2d92c4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?id=d1a658d708e01bea1213624ee4c5dba135b3cb4d git remote add morse https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git git fetch --no-tags morse mpam/snapshot/v5.16 git checkout d1a658d708e01bea1213624ee4c5dba135b3cb4d # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> clang-analyzer warnings: (new ones prefixed by >>) drivers/acpi/acpica/nsnames.c:226:2: note: Loop condition is true. Entering loop body while (next_node && next_node != acpi_gbl_root_node) { ^ drivers/acpi/acpica/nsnames.c:227:7: note: 'next_node' is equal to 'node' if (next_node != node) { ^~~~~~~~~ drivers/acpi/acpica/nsnames.c:227:3: note: Taking false branch if (next_node != node) { ^ drivers/acpi/acpica/nsnames.c:234:3: note: Loop condition is true. Entering loop body for (i = 0; i < 4; i++) { ^ drivers/acpi/acpica/nsnames.c:235:6: note: Assigned value is garbage or undefined c = name[4 - i - 1]; ^ ~~~~~~~~~~~~~~~ drivers/acpi/acpica/nsnames.c:376:3: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy] strcat(full_path, prefix_path); ^~~~~~ drivers/acpi/acpica/nsnames.c:376:3: note: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat(full_path, prefix_path); ^~~~~~ drivers/acpi/acpica/nsnames.c:378:4: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy] strcat(full_path, "."); ^~~~~~ drivers/acpi/acpica/nsnames.c:378:4: note: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat(full_path, "."); ^~~~~~ drivers/acpi/acpica/nsnames.c:383:2: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy] strcat(full_path, external_path); ^~~~~~ drivers/acpi/acpica/nsnames.c:383:2: note: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat(full_path, external_path); ^~~~~~ drivers/acpi/acpica/nsnames.c:464:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy] strcpy(original_path, new_path_buffer); ^~~~~~ drivers/acpi/acpica/nsnames.c:464:2: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 strcpy(original_path, new_path_buffer); ^~~~~~ 3 warnings generated. Suppressed 3 warnings (2 in non-user code, 1 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 1 warning generated. Suppressed 1 warnings (1 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 5 warnings generated. >> fs/resctrl/rdtgroup.c:2611:12: warning: Assigned value is garbage or >> undefined [clang-analyzer-core.uninitialized.Assign] *dest_kn = kn; ^ fs/resctrl/rdtgroup.c:2160:6: note: Assuming 'resctrl_mounted' is false if (resctrl_mounted) { ^~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2160:2: note: Taking false branch if (resctrl_mounted) { ^ fs/resctrl/rdtgroup.c:2166:6: note: 'ret' is >= 0 if (ret < 0) ^~~ fs/resctrl/rdtgroup.c:2166:2: note: Taking false branch if (ret < 0) ^ fs/resctrl/rdtgroup.c:2169:8: note: Calling 'schemata_list_create' ret = schemata_list_create(); ^~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2116:2: note: Loop condition is true. Entering loop body for (i = 0; i < RDT_NUM_RESOURCES; i++) { ^ fs/resctrl/rdtgroup.c:2118:7: note: Assuming field 'alloc_capable' is false if (!r->alloc_capable) ^~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2118:3: note: Taking true branch if (!r->alloc_capable) ^ fs/resctrl/rdtgroup.c:2119:4: note: Execution continues on line 2116 continue; ^ fs/resctrl/rdtgroup.c:2116:2: note: Loop condition is true. Entering loop body for (i = 0; i < RDT_NUM_RESOURCES; i++) { ^ fs/resctrl/rdtgroup.c:2118:7: note: Assuming field 'alloc_capable' is false if (!r->alloc_capable) ^~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2118:3: note: Taking true branch if (!r->alloc_capable) ^ fs/resctrl/rdtgroup.c:2119:4: note: Execution continues on line 2116 continue; ^ fs/resctrl/rdtgroup.c:2116:2: note: Loop condition is true. Entering loop body for (i = 0; i < RDT_NUM_RESOURCES; i++) { ^ fs/resctrl/rdtgroup.c:2118:7: note: Assuming field 'alloc_capable' is false if (!r->alloc_capable) ^~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2118:3: note: Taking true branch if (!r->alloc_capable) ^ fs/resctrl/rdtgroup.c:2119:4: note: Execution continues on line 2116 continue; ^ fs/resctrl/rdtgroup.c:2116:2: note: Loop condition is false. Execution continues on line 2135 for (i = 0; i < RDT_NUM_RESOURCES; i++) { ^ fs/resctrl/rdtgroup.c:2135:2: note: Returning zero (loaded from 'ret'), which participates in a condition later return ret; ^~~~~~~~~~ fs/resctrl/rdtgroup.c:2169:8: note: Returning from 'schemata_list_create' ret = schemata_list_create(); ^~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2170:6: note: 'ret' is 0 if (ret) { ^~~ fs/resctrl/rdtgroup.c:2170:2: note: Taking false branch if (ret) { ^ fs/resctrl/rdtgroup.c:2178:6: note: Assuming 'ret' is >= 0 if (ret < 0) ^~~~~~~ fs/resctrl/rdtgroup.c:2178:2: note: Taking false branch if (ret < 0) ^ fs/resctrl/rdtgroup.c:2181:6: note: Assuming the condition is true if (resctrl_arch_mon_capable()) { ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2181:2: note: Taking true branch if (resctrl_arch_mon_capable()) { ^ fs/resctrl/rdtgroup.c:2182:9: note: Calling 'mongroup_create_dir' ret = mongroup_create_dir(rdtgroup_default.kn, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:1839:7: note: Calling 'kernfs_create_dir' kn = kernfs_create_dir(parent_kn, name, parent_kn->mode, prgrp); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernfs.h:562:9: note: Value assigned to 'kn_mondata', which participates in a condition later return kernfs_create_dir_ns(parent, name, mode, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:1839:7: note: Returning from 'kernfs_create_dir' kn = kernfs_create_dir(parent_kn, name, parent_kn->mode, prgrp); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:1840:2: note: Taking true branch if (IS_ERR(kn)) ^ fs/resctrl/rdtgroup.c:2182:9: note: Returning from 'mongroup_create_dir' ret = mongroup_create_dir(rdtgroup_default.kn, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2185:7: note: Assuming 'ret' is >= 0 if (ret < 0) ^~~~~~~ fs/resctrl/rdtgroup.c:2185:3: note: Taking false branch if (ret < 0) ^ fs/resctrl/rdtgroup.c:2188:9: note: Calling 'mkdir_mondata_all' ret = mkdir_mondata_all(rdtgroup_default.kn, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2600:2: note: 'kn' declared without an initial value struct kernfs_node *kn; ^~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2606:8: note: Calling 'mongroup_create_dir' ret = mongroup_create_dir(parent_kn, prgrp, "mon_data", &kn); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:1840:6: note: Calling 'IS_ERR' if (IS_ERR(kn)) ^~~~~~~~~~ include/linux/err.h:36:9: note: Assuming the condition is true return IS_ERR_VALUE((unsigned long)ptr); ^ include/linux/err.h:22:34: note: expanded from macro 'IS_ERR_VALUE' #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:78:42: note: expanded from macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ include/linux/err.h:36:2: note: Returning the value 1, which participates in a condition later return IS_ERR_VALUE((unsigned long)ptr); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:1840:6: note: Returning from 'IS_ERR' if (IS_ERR(kn)) ^~~~~~~~~~ fs/resctrl/rdtgroup.c:1840:2: note: Taking true branch if (IS_ERR(kn)) ^ fs/resctrl/rdtgroup.c:1841:3: note: Returning without writing to '*dest_kn' return PTR_ERR(kn); ^ fs/resctrl/rdtgroup.c:1841:3: note: Returning value, which participates in a condition later return PTR_ERR(kn); ^~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2606:8: note: Returning from 'mongroup_create_dir' ret = mongroup_create_dir(parent_kn, prgrp, "mon_data", &kn); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2607:6: note: Assuming 'ret' is 0 if (ret) ^~~ fs/resctrl/rdtgroup.c:2607:2: note: Taking false branch if (ret) ^ fs/resctrl/rdtgroup.c:2610:6: note: 'dest_kn' is non-null if (dest_kn) ^~~~~~~ fs/resctrl/rdtgroup.c:2610:2: note: Taking true branch if (dest_kn) ^ fs/resctrl/rdtgroup.c:2611:12: note: Assigned value is garbage or undefined *dest_kn = kn; ^ ~~ >> fs/resctrl/rdtgroup.c:2919:10: warning: Use of memory after it is freed >> [clang-analyzer-unix.Malloc] prgrp = rdtgrp->mon.parent; ^ fs/resctrl/rdtgroup.c:3047:6: note: Assuming the condition is false if (strchr(name, '\n')) ^~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:3047:2: note: Taking false branch if (strchr(name, '\n')) ^ fs/resctrl/rdtgroup.c:3055:6: note: Assuming the condition is false if (resctrl_arch_alloc_capable() && parent_kn == rdtgroup_default.kn) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:3055:35: note: Left side of '&&' is false if (resctrl_arch_alloc_capable() && parent_kn == rdtgroup_default.kn) ^ fs/resctrl/rdtgroup.c:3062:6: note: Assuming the condition is true if (resctrl_arch_mon_capable() && is_mon_groups(parent_kn, name)) ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:3062:6: note: Left side of '&&' is true fs/resctrl/rdtgroup.c:3062:36: note: Assuming the condition is true if (resctrl_arch_mon_capable() && is_mon_groups(parent_kn, name)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:3062:2: note: Taking true branch if (resctrl_arch_mon_capable() && is_mon_groups(parent_kn, name)) ^ fs/resctrl/rdtgroup.c:3063:10: note: Calling 'rdtgroup_mkdir_mon' return rdtgroup_mkdir_mon(parent_kn, name, mode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2915:8: note: Calling 'mkdir_rdt_prepare' ret = mkdir_rdt_prepare(parent_kn, name, mode, RDTMON_GROUP, &rdtgrp); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2831:7: note: 'prdtgrp' is non-null if (!prdtgrp) { ^~~~~~~ fs/resctrl/rdtgroup.c:2831:2: note: Taking false branch if (!prdtgrp) { ^ fs/resctrl/rdtgroup.c:2836:6: note: 'rtype' is equal to RDTMON_GROUP if (rtype == RDTMON_GROUP && ^~~~~ fs/resctrl/rdtgroup.c:2836:6: note: Left side of '&&' is true fs/resctrl/rdtgroup.c:2837:7: note: Assuming field 'mode' is not equal to RDT_MODE_PSEUDO_LOCKSETUP (prdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP || ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2837:7: note: Left side of '||' is false fs/resctrl/rdtgroup.c:2838:7: note: Assuming field 'mode' is not equal to RDT_MODE_PSEUDO_LOCKED prdtgrp->mode == RDT_MODE_PSEUDO_LOCKED)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2836:2: note: Taking false branch if (rtype == RDTMON_GROUP && ^ fs/resctrl/rdtgroup.c:2846:6: note: Assuming 'rdtgrp' is non-null if (!rdtgrp) { ^~~~~~~ fs/resctrl/rdtgroup.c:2846:2: note: Taking false branch if (!rdtgrp) { ^ fs/resctrl/rdtgroup.c:2858:2: note: Taking true branch if (IS_ERR(kn)) { ^ fs/resctrl/rdtgroup.c:2861:3: note: Control jumps to line 2897 goto out_free_rgrp; ^ fs/resctrl/rdtgroup.c:2897:2: note: Memory is released kfree(rdtgrp); ^~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2915:8: note: Returning; memory was released via 5th parameter ret = mkdir_rdt_prepare(parent_kn, name, mode, RDTMON_GROUP, &rdtgrp); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2916:6: note: Assuming 'ret' is 0 if (ret) ^~~ fs/resctrl/rdtgroup.c:2916:2: note: Taking false branch if (ret) ^ fs/resctrl/rdtgroup.c:2919:10: note: Use of memory after it is freed prgrp = rdtgrp->mon.parent; ^~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2971:7: warning: Use of memory after it is freed [clang-analyzer-unix.Malloc] kn = rdtgrp->kn; ^ fs/resctrl/rdtgroup.c:3047:6: note: Assuming the condition is false if (strchr(name, '\n')) ^~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:3047:2: note: Taking false branch if (strchr(name, '\n')) ^ fs/resctrl/rdtgroup.c:3055:6: note: Assuming the condition is true if (resctrl_arch_alloc_capable() && parent_kn == rdtgroup_default.kn) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:3055:6: note: Left side of '&&' is true fs/resctrl/rdtgroup.c:3055:38: note: Assuming 'parent_kn' is equal to field 'kn' if (resctrl_arch_alloc_capable() && parent_kn == rdtgroup_default.kn) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:3055:2: note: Taking true branch if (resctrl_arch_alloc_capable() && parent_kn == rdtgroup_default.kn) ^ fs/resctrl/rdtgroup.c:3056:10: note: Calling 'rdtgroup_mkdir_ctrl_mon' return rdtgroup_mkdir_ctrl_mon(parent_kn, name, mode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/resctrl/rdtgroup.c:2967:8: note: Calling 'mkdir_rdt_prepare' vim +2611 fs/resctrl/rdtgroup.c d1a658d708e01b James Morse 2021-09-06 2576 d1a658d708e01b James Morse 2021-09-06 2577 /* d1a658d708e01b James Morse 2021-09-06 2578 * This creates a directory mon_data which contains the monitored data. d1a658d708e01b James Morse 2021-09-06 2579 * d1a658d708e01b James Morse 2021-09-06 2580 * mon_data has one directory for each domain which are named d1a658d708e01b James Morse 2021-09-06 2581 * in the format mon_<domain_name>_<domain_id>. For ex: A mon_data d1a658d708e01b James Morse 2021-09-06 2582 * with L3 domain looks as below: d1a658d708e01b James Morse 2021-09-06 2583 * ./mon_data: d1a658d708e01b James Morse 2021-09-06 2584 * mon_L3_00 d1a658d708e01b James Morse 2021-09-06 2585 * mon_L3_01 d1a658d708e01b James Morse 2021-09-06 2586 * mon_L3_02 d1a658d708e01b James Morse 2021-09-06 2587 * ... d1a658d708e01b James Morse 2021-09-06 2588 * d1a658d708e01b James Morse 2021-09-06 2589 * Each domain directory has one file per event: d1a658d708e01b James Morse 2021-09-06 2590 * ./mon_L3_00/: d1a658d708e01b James Morse 2021-09-06 2591 * llc_occupancy d1a658d708e01b James Morse 2021-09-06 2592 * d1a658d708e01b James Morse 2021-09-06 2593 */ d1a658d708e01b James Morse 2021-09-06 2594 static int mkdir_mondata_all(struct kernfs_node *parent_kn, d1a658d708e01b James Morse 2021-09-06 2595 struct rdtgroup *prgrp, d1a658d708e01b James Morse 2021-09-06 2596 struct kernfs_node **dest_kn) d1a658d708e01b James Morse 2021-09-06 2597 { d1a658d708e01b James Morse 2021-09-06 2598 enum resctrl_res_level i; d1a658d708e01b James Morse 2021-09-06 2599 struct rdt_resource *r; d1a658d708e01b James Morse 2021-09-06 2600 struct kernfs_node *kn; d1a658d708e01b James Morse 2021-09-06 2601 int ret; d1a658d708e01b James Morse 2021-09-06 2602 d1a658d708e01b James Morse 2021-09-06 2603 /* d1a658d708e01b James Morse 2021-09-06 2604 * Create the mon_data directory first. d1a658d708e01b James Morse 2021-09-06 2605 */ d1a658d708e01b James Morse 2021-09-06 2606 ret = mongroup_create_dir(parent_kn, prgrp, "mon_data", &kn); d1a658d708e01b James Morse 2021-09-06 2607 if (ret) d1a658d708e01b James Morse 2021-09-06 2608 return ret; d1a658d708e01b James Morse 2021-09-06 2609 d1a658d708e01b James Morse 2021-09-06 2610 if (dest_kn) d1a658d708e01b James Morse 2021-09-06 @2611 *dest_kn = kn; d1a658d708e01b James Morse 2021-09-06 2612 d1a658d708e01b James Morse 2021-09-06 2613 /* d1a658d708e01b James Morse 2021-09-06 2614 * Create the subdirectories for each domain. Note that all events d1a658d708e01b James Morse 2021-09-06 2615 * in a domain like L3 are grouped into a resource whose domain is L3 d1a658d708e01b James Morse 2021-09-06 2616 */ d1a658d708e01b James Morse 2021-09-06 2617 for (i = 0; i < RDT_NUM_RESOURCES; i++) { d1a658d708e01b James Morse 2021-09-06 2618 r = resctrl_arch_get_resource(i); d1a658d708e01b James Morse 2021-09-06 2619 if (!r->mon_capable) d1a658d708e01b James Morse 2021-09-06 2620 continue; d1a658d708e01b James Morse 2021-09-06 2621 d1a658d708e01b James Morse 2021-09-06 2622 ret = mkdir_mondata_subdir_alldom(kn, r, prgrp); d1a658d708e01b James Morse 2021-09-06 2623 if (ret) d1a658d708e01b James Morse 2021-09-06 2624 goto out_destroy; d1a658d708e01b James Morse 2021-09-06 2625 } d1a658d708e01b James Morse 2021-09-06 2626 d1a658d708e01b James Morse 2021-09-06 2627 return 0; d1a658d708e01b James Morse 2021-09-06 2628 d1a658d708e01b James Morse 2021-09-06 2629 out_destroy: d1a658d708e01b James Morse 2021-09-06 2630 kernfs_remove(kn); d1a658d708e01b James Morse 2021-09-06 2631 return ret; d1a658d708e01b James Morse 2021-09-06 2632 } d1a658d708e01b James Morse 2021-09-06 2633 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
