CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Michael Walle <[email protected]>
Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on soc/for-next] [also build test WARNING on next-20220127] [cannot apply to linux/master linus/master v5.17-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Walle/soc-fsl-guts-cleanups-and-serial_number-support/20220128-004223 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next :::::: branch date: 12 hours ago :::::: commit date: 12 hours ago config: openrisc-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220128/[email protected]/config) compiler: or1k-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/soc/fsl/guts.c:169 fsl_guts_init() warn: possible memory leak of 'soc_dev_attr' Old smatch warnings: drivers/soc/fsl/guts.c:182 fsl_guts_init() warn: possible memory leak of 'soc_dev_attr' vim +/soc_dev_attr +169 drivers/soc/fsl/guts.c a83b17321e29c5 Michael Walle 2022-01-27 144 a83b17321e29c5 Michael Walle 2022-01-27 145 static int __init fsl_guts_init(void) a6fc3b69813023 yangbo lu 2016-11-09 146 { c93df5b7c92a04 Michael Walle 2022-01-27 147 struct soc_device_attribute *soc_dev_attr; c09e0eeea0bce0 Michael Walle 2022-01-27 148 static struct soc_device *soc_dev; a6fc3b69813023 yangbo lu 2016-11-09 149 const struct fsl_soc_die_attr *soc_die; 01e929af81c348 Michael Walle 2022-01-27 150 struct ccsr_guts __iomem *regs; 794557e9a91a9b Michael Walle 2022-01-27 151 const char *machine = NULL; a83b17321e29c5 Michael Walle 2022-01-27 152 struct device_node *np; 01e929af81c348 Michael Walle 2022-01-27 153 bool little_endian; a6fc3b69813023 yangbo lu 2016-11-09 154 u32 svr; a83b17321e29c5 Michael Walle 2022-01-27 155 int ret; a83b17321e29c5 Michael Walle 2022-01-27 156 a83b17321e29c5 Michael Walle 2022-01-27 157 np = of_find_matching_node_and_match(NULL, fsl_guts_of_match, NULL); a83b17321e29c5 Michael Walle 2022-01-27 158 if (!np) a83b17321e29c5 Michael Walle 2022-01-27 159 return 0; a6fc3b69813023 yangbo lu 2016-11-09 160 a83b17321e29c5 Michael Walle 2022-01-27 161 soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); c93df5b7c92a04 Michael Walle 2022-01-27 162 if (!soc_dev_attr) c93df5b7c92a04 Michael Walle 2022-01-27 163 return -ENOMEM; c93df5b7c92a04 Michael Walle 2022-01-27 164 01e929af81c348 Michael Walle 2022-01-27 165 little_endian = of_property_read_bool(np, "little-endian"); a6fc3b69813023 yangbo lu 2016-11-09 166 01e929af81c348 Michael Walle 2022-01-27 167 regs = of_iomap(np, 0); 01e929af81c348 Michael Walle 2022-01-27 168 if (IS_ERR(regs)) 01e929af81c348 Michael Walle 2022-01-27 @169 return PTR_ERR(regs); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
