CC: [email protected]
CC: [email protected]
TO: Kan Liang <[email protected]>
CC: Peter Zijlstra <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   cb323ee75d24e7acc2f188d123ba6df46159cf09
commit: d9977c43bff895ed49a9d25e1f382b0a98bb271f perf/x86: Register hybrid PMUs
date:   10 months ago
:::::: branch date: 7 hours ago
:::::: commit date: 10 months ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>


cppcheck warnings: (new ones prefixed by >>)
>> arch/x86/kernel/e820.c:1198:2: warning: int result is returned as long 
>> value. If the return value is long to avoid loss of information, then you 
>> have loss of information. [truncLongCastReturn]
    return 64*1024*1024;
    ^

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> arch/x86/mm/pat/set_memory.c:391:52: warning: Same expression on both sides 
>> of '||' because 'r1_start<=r2_end&&r1_end>=r2_start' and 
>> 'r2_start<=r1_end&&r2_end>=r1_start' represent the same value. 
>> [knownConditionTrueFalse]
    return (r1_start <= r2_end && r1_end >= r2_start) ||
                                                      ^
>> arch/x86/events/perf_event.h:88:2: warning: Non-boolean value returned from 
>> function returning bool [returnNonBoolInBooleanFunction]
    return event->hw.flags & PERF_X86_EVENT_TOPDOWN;
    ^
   arch/x86/events/perf_event.h:1064:2: warning: Non-boolean value returned 
from function returning bool [returnNonBoolInBooleanFunction]
    return hwc->flags & PERF_X86_EVENT_PAIR;
    ^
>> arch/x86/events/intel/uncore.c:859:4: warning: %u in format string (no. 1) 
>> requires 'unsigned int' but the argument type is 'signed int'. 
>> [invalidPrintfArgType_uint]
      sprintf(pmu->name, "uncore_type_%u", type->type_id);
      ^
   arch/x86/events/intel/uncore.c:861:4: warning: %u in format string (no. 1) 
requires 'unsigned int' but the argument type is 'signed int'. 
[invalidPrintfArgType_uint]
      sprintf(pmu->name, "uncore_type_%u_%d",
      ^
>> arch/x86/events/intel/uncore.c:861:4: warning: %d in format string (no. 2) 
>> requires 'int' but the argument type is 'unsigned int'. 
>> [invalidPrintfArgType_sint]
      sprintf(pmu->name, "uncore_type_%u_%d",
      ^
>> arch/x86/events/perf_event.h:88:2: warning: Non-boolean value returned from 
>> function returning bool [returnNonBoolInBooleanFunction]
    return event->hw.flags & PERF_X86_EVENT_TOPDOWN;
    ^
   arch/x86/events/perf_event.h:1064:2: warning: Non-boolean value returned 
from function returning bool [returnNonBoolInBooleanFunction]
    return hwc->flags & PERF_X86_EVENT_PAIR;
    ^
>> arch/x86/events/core.c:2120:26: warning: Local variable hybrid_pmu shadows 
>> outer function [shadowFunction]
     struct x86_hybrid_pmu *hybrid_pmu;
                            ^
   arch/x86/events/perf_event.h:660:47: note: Shadowed declaration
   static __always_inline struct x86_hybrid_pmu *hybrid_pmu(struct pmu *pmu)
                                                 ^
   arch/x86/events/core.c:2120:26: note: Shadow variable
     struct x86_hybrid_pmu *hybrid_pmu;
                            ^
>> arch/x86/kernel/apic/io_apic.c:1047:44: warning: Uninitialized variable: irq 
>> [uninitvar]
      irq = alloc_isa_irq_from_domain(domain, irq,
                                              ^
   arch/x86/kernel/apic/io_apic.c:1060:9: warning: Uninitialized variable: irq 
[uninitvar]
    return irq;
           ^

vim +88 arch/x86/events/perf_event.h

7b2c05a15d29d0 Kan Liang 2020-07-23  85  
7b2c05a15d29d0 Kan Liang 2020-07-23  86  static inline bool 
is_topdown_count(struct perf_event *event)
7b2c05a15d29d0 Kan Liang 2020-07-23  87  {
7b2c05a15d29d0 Kan Liang 2020-07-23 @88         return event->hw.flags & 
PERF_X86_EVENT_TOPDOWN;
7b2c05a15d29d0 Kan Liang 2020-07-23  89  }
7b2c05a15d29d0 Kan Liang 2020-07-23  90  

:::::: The code at line 88 was first introduced by commit
:::::: 7b2c05a15d29d0570a0d21da1e4fd5cbc85cbf13 perf/x86/intel: Generic support 
for hardware TopDown metrics

:::::: TO: Kan Liang <[email protected]>
:::::: CC: Peter Zijlstra <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to