CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Daniel Scally <[email protected]> TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on v5.17-rc2 next-20220128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Scally/Introduce-ancillary-links/20220131-080041 base: git://linuxtv.org/media_tree.git master :::::: branch date: 5 hours ago :::::: commit date: 5 hours ago config: powerpc-randconfig-c003-20220131 (https://download.01.org/0day-ci/archive/20220131/[email protected]/config) compiler: powerpc-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> cocci warnings: (new ones prefixed by >>) >> drivers/media/v4l2-core/v4l2-async.c:294:23-30: ERROR: PTR_ERR applied after >> initialization to constant on line 282 vim +294 drivers/media/v4l2-core/v4l2-async.c 2cab00bb076b9f Sakari Ailus 2017-09-24 277 8dc719a0ecab0c Daniel Scally 2022-01-30 278 static int 8dc719a0ecab0c Daniel Scally 2022-01-30 279 __v4l2_async_create_ancillary_link(struct v4l2_async_notifier *notifier, 8dc719a0ecab0c Daniel Scally 2022-01-30 280 struct v4l2_subdev *sd) 8dc719a0ecab0c Daniel Scally 2022-01-30 281 { 8dc719a0ecab0c Daniel Scally 2022-01-30 @282 struct media_link *link = NULL; 8dc719a0ecab0c Daniel Scally 2022-01-30 283 8dc719a0ecab0c Daniel Scally 2022-01-30 284 #if IS_ENABLED(CONFIG_MEDIA_CONTROLLER) 8dc719a0ecab0c Daniel Scally 2022-01-30 285 8dc719a0ecab0c Daniel Scally 2022-01-30 286 if (sd->entity.function != MEDIA_ENT_F_LENS && 8dc719a0ecab0c Daniel Scally 2022-01-30 287 sd->entity.function != MEDIA_ENT_F_FLASH) 8dc719a0ecab0c Daniel Scally 2022-01-30 288 return -EINVAL; 8dc719a0ecab0c Daniel Scally 2022-01-30 289 8dc719a0ecab0c Daniel Scally 2022-01-30 290 link = media_create_ancillary_link(¬ifier->sd->entity, &sd->entity); 8dc719a0ecab0c Daniel Scally 2022-01-30 291 8dc719a0ecab0c Daniel Scally 2022-01-30 292 #endif 8dc719a0ecab0c Daniel Scally 2022-01-30 293 8dc719a0ecab0c Daniel Scally 2022-01-30 @294 return IS_ERR(link) ? PTR_ERR(link) : 0; 8dc719a0ecab0c Daniel Scally 2022-01-30 295 } 8dc719a0ecab0c Daniel Scally 2022-01-30 296 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
