CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Casey Schaufler <[email protected]>

Hi Casey,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pcmoore-audit/next]
[also build test WARNING on nf-next/master nf/master linus/master v5.17-rc2 
next-20220204]
[cannot apply to jmorris-security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220203-085302
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: i386-randconfig-m021-20220131 
(https://download.01.org/0day-ci/archive/20220204/[email protected]/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
include/linux/security.h:215 lsmblob_value() warn: we never enter this loop

vim +215 include/linux/security.h

7a3a34d2277c60 Casey Schaufler 2022-02-02  200  
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  201  /**
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  202   * lsmblob_value - find the 
first non-zero value in an lsmblob structure.
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  203   * @blob: Pointer to the data
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  204   *
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  205   * This needs to be used with 
extreme caution, as the cases where
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  206   * it is appropriate are rare.
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  207   *
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  208   * Return the first secid value 
set in the lsmblob.
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  209   * There should only be one.
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  210   */
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  211  static inline u32 
lsmblob_value(const struct lsmblob *blob)
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  212  {
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  213          int i;
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  214  
d7dd3b5434a8d2 Casey Schaufler 2022-02-02 @215          for (i = 0; i < 
LSMBLOB_ENTRIES; i++)
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  216                  if 
(blob->secid[i])
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  217                          return 
blob->secid[i];
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  218  
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  219          return 0;
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  220  }
d7dd3b5434a8d2 Casey Schaufler 2022-02-02  221  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to