CC: [email protected] CC: [email protected] TO: Amit Kumar Mahapatra <[email protected]> CC: Michal Simek <[email protected]> CC: Naga Sureshkumar Relli <[email protected]> CC: Mark Brown <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/spi/spi-zynqmp-gqspi.c:1393:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1398. drivers/spi/spi-zynqmp-gqspi.c:1405:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1410. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume") CC: Amit Kumar Mahapatra <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15 head: 1183ce490adb103e5e569b8ebd74c50c885ddc05 commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume :::::: branch date: 3 days ago :::::: commit date: 3 days ago Please take the patch only if it's a positive warning. Thanks! spi-zynqmp-gqspi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat &rx_bus_width); if (!ret) { xqspi->rx_bus_width = rx_bus_width; + of_node_put(nc); break; } } @@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat &tx_bus_width); if (!ret) { xqspi->tx_bus_width = tx_bus_width; + of_node_put(nc); break; } } _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
