CC: [email protected] CC: [email protected] TO: Vladimir Oltean <[email protected]> CC: Florian Fainelli <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f1baf68e1383f6ed93eb9cff2866d46562607a43 commit: bef0746cf4cce238b1943df5d5b8f3103da92ead net: dsa: sja1105: make sure untagged packets are dropped on ingress ports with no pvid date: 7 months ago :::::: branch date: 17 hours ago :::::: commit date: 7 months ago config: m68k-randconfig-m031-20220211 (https://download.01.org/0day-ci/archive/20220212/[email protected]/config) compiler: m68k-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/net/dsa/sja1105/sja1105_main.c:129 sja1105_commit_pvid() warn: should '((((1))) << port)' be a 64 bit type? Old smatch warnings: drivers/net/dsa/sja1105/sja1105_main.c:49 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:57 sja1105_can_forward() warn: should '((((1))) << to)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:248 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:260 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:269 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:278 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:284 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:291 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:518 sja1105_init_l2_forwarding() warn: should '(((1))) << upstream' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:519 sja1105_init_l2_forwarding() warn: should '(((1))) << upstream' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:604 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:777 sja1105_init_general_params() warn: is 'table->entries' large enough for 'struct sja1105_general_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:805 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 0 drivers/net/dsa/sja1105/sja1105_main.c:1272 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1390 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1392 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1400 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1486 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1494 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1499 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1549 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1618 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1670 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1672 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:2165 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:2166 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:2170 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:2479 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:2797 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type? vim +129 drivers/net/dsa/sja1105/sja1105_main.c cde8078e83e320 Vladimir Oltean 2021-07-29 106 cde8078e83e320 Vladimir Oltean 2021-07-29 107 static int sja1105_commit_pvid(struct dsa_switch *ds, int port) cde8078e83e320 Vladimir Oltean 2021-07-29 108 { cde8078e83e320 Vladimir Oltean 2021-07-29 109 struct dsa_port *dp = dsa_to_port(ds, port); cde8078e83e320 Vladimir Oltean 2021-07-29 110 struct sja1105_private *priv = ds->priv; bef0746cf4cce2 Vladimir Oltean 2021-07-29 111 struct sja1105_vlan_lookup_entry *vlan; bef0746cf4cce2 Vladimir Oltean 2021-07-29 112 bool drop_untagged = false; bef0746cf4cce2 Vladimir Oltean 2021-07-29 113 int match, rc; cde8078e83e320 Vladimir Oltean 2021-07-29 114 u16 pvid; cde8078e83e320 Vladimir Oltean 2021-07-29 115 cde8078e83e320 Vladimir Oltean 2021-07-29 116 if (dp->bridge_dev && br_vlan_enabled(dp->bridge_dev)) cde8078e83e320 Vladimir Oltean 2021-07-29 117 pvid = priv->bridge_pvid[port]; cde8078e83e320 Vladimir Oltean 2021-07-29 118 else cde8078e83e320 Vladimir Oltean 2021-07-29 119 pvid = priv->tag_8021q_pvid[port]; cde8078e83e320 Vladimir Oltean 2021-07-29 120 bef0746cf4cce2 Vladimir Oltean 2021-07-29 121 rc = sja1105_pvid_apply(priv, port, pvid); bef0746cf4cce2 Vladimir Oltean 2021-07-29 122 if (rc) bef0746cf4cce2 Vladimir Oltean 2021-07-29 123 return rc; bef0746cf4cce2 Vladimir Oltean 2021-07-29 124 bef0746cf4cce2 Vladimir Oltean 2021-07-29 125 vlan = priv->static_config.tables[BLK_IDX_VLAN_LOOKUP].entries; bef0746cf4cce2 Vladimir Oltean 2021-07-29 126 bef0746cf4cce2 Vladimir Oltean 2021-07-29 127 match = sja1105_is_vlan_configured(priv, pvid); bef0746cf4cce2 Vladimir Oltean 2021-07-29 128 bef0746cf4cce2 Vladimir Oltean 2021-07-29 @129 if (match < 0 || !(vlan[match].vmemb_port & BIT(port))) bef0746cf4cce2 Vladimir Oltean 2021-07-29 130 drop_untagged = true; bef0746cf4cce2 Vladimir Oltean 2021-07-29 131 bef0746cf4cce2 Vladimir Oltean 2021-07-29 132 return sja1105_drop_untagged(ds, port, drop_untagged); cde8078e83e320 Vladimir Oltean 2021-07-29 133 } cde8078e83e320 Vladimir Oltean 2021-07-29 134 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
