CC: [email protected] CC: [email protected] CC: [email protected] TO: Mirela Rabulea <[email protected]> CC: Mauro Carvalho Chehab <[email protected]> CC: [email protected] CC: Hans Verkuil <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 754e0b0e35608ed5206d6a67a791563c631cec07 commit: 2db16c6ed72ce644d5639b3ed15e5817442db4ba media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder date: 11 months ago :::::: branch date: 12 hours ago :::::: commit date: 11 months ago config: riscv-randconfig-c006-20220213 (https://download.01.org/0day-ci/archive/20220214/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c7eb84634519e6497be42f5fe323f9a04ed67127) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2db16c6ed72ce644d5639b3ed15e5817442db4ba git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 2db16c6ed72ce644d5639b3ed15e5817442db4ba # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> clang-analyzer warnings: (new ones prefixed by >>) drivers/media/platform/imx-jpeg/mxc-jpeg.c:880:5: warning: The result of the left shift is undefined because the left operand is negative [clang-analyzer-core.UndefinedBinaryOperatorResult] STM_CTRL_IMAGE_FORMAT(img_fmt); ^ drivers/media/platform/imx-jpeg/mxc-jpeg-hw.h:84:52: note: expanded from macro 'STM_CTRL_IMAGE_FORMAT' #define STM_CTRL_IMAGE_FORMAT(img_fmt) ((img_fmt) << 3) ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:904:2: note: Loop condition is false. Exiting loop spin_lock_irqsave(&ctx->mxc_jpeg->hw_lock, flags); ^ include/linux/spinlock.h:384:2: note: expanded from macro 'spin_lock_irqsave' raw_spin_lock_irqsave(spinlock_check(lock), flags); \ ^ include/linux/spinlock.h:250:2: note: expanded from macro 'raw_spin_lock_irqsave' do { \ ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:904:2: note: Loop condition is false. Exiting loop spin_lock_irqsave(&ctx->mxc_jpeg->hw_lock, flags); ^ include/linux/spinlock.h:382:43: note: expanded from macro 'spin_lock_irqsave' #define spin_lock_irqsave(lock, flags) \ ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:907:6: note: Assuming 'src_buf' is non-null if (!src_buf || !dst_buf) { ^~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:907:6: note: Left side of '||' is false drivers/media/platform/imx-jpeg/mxc-jpeg.c:907:18: note: Assuming 'dst_buf' is non-null if (!src_buf || !dst_buf) { ^~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:907:2: note: Taking false branch if (!src_buf || !dst_buf) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:913:7: note: 'q_data_cap' is non-null if (!q_data_cap) ^~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:913:2: note: Taking false branch if (!q_data_cap) ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:916:7: note: 'q_data_out' is non-null if (!q_data_out) ^~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:916:2: note: Taking false branch if (!q_data_out) ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:924:6: note: Assuming field 'jpeg_parse_error' is false if (jpeg_src_buf->jpeg_parse_error) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:924:2: note: Taking false branch if (jpeg_src_buf->jpeg_parse_error) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:945:11: note: Field 'slot' is < MXC_MAX_SLOTS if (ctx->slot >= MXC_MAX_SLOTS) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:945:2: note: Taking false branch if (ctx->slot >= MXC_MAX_SLOTS) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:949:2: note: Taking false branch if (!mxc_jpeg_alloc_slot_data(jpeg, ctx->slot)) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:957:6: note: Assuming field 'mode' is equal to MXC_JPEG_ENCODE if (jpeg->mode == MXC_JPEG_ENCODE) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:957:2: note: Taking true branch if (jpeg->mode == MXC_JPEG_ENCODE) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:958:3: note: Taking false branch dev_dbg(dev, "Encoding on slot %d\n", ctx->slot); ^ include/linux/dev_printk.h:130:2: note: expanded from macro 'dev_dbg' if (0) \ ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:960:3: note: Calling 'mxc_jpeg_config_enc_desc' mxc_jpeg_config_enc_desc(&dst_buf->vb2_buf, ctx, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:876:12: note: Calling 'mxc_jpeg_fourcc_to_imgfmt' img_fmt = mxc_jpeg_fourcc_to_imgfmt(q_data->fmt->fourcc); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:387:2: note: Control jumps to the 'default' case at line 400 switch (fourcc) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:401:3: note: Returning the value -1 return MXC_JPEG_INVALID; ^~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:876:12: note: Returning from 'mxc_jpeg_fourcc_to_imgfmt' img_fmt = mxc_jpeg_fourcc_to_imgfmt(q_data->fmt->fourcc); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:876:2: note: The value -1 is assigned to 'img_fmt' img_fmt = mxc_jpeg_fourcc_to_imgfmt(q_data->fmt->fourcc); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:877:6: note: 'img_fmt' is equal to MXC_JPEG_INVALID if (img_fmt == MXC_JPEG_INVALID) ^~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:877:2: note: Taking true branch if (img_fmt == MXC_JPEG_INVALID) ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:880:5: note: The result of the left shift is undefined because the left operand is negative STM_CTRL_IMAGE_FORMAT(img_fmt); ^ drivers/media/platform/imx-jpeg/mxc-jpeg-hw.h:84:52: note: expanded from macro 'STM_CTRL_IMAGE_FORMAT' #define STM_CTRL_IMAGE_FORMAT(img_fmt) ((img_fmt) << 3) ~~~~~~~~~ ^ >> drivers/media/platform/imx-jpeg/mxc-jpeg.c:979:17: warning: Value stored to >> 'dev' during its initialization is never read >> [clang-analyzer-deadcode.DeadStores] struct device *dev = ctx->mxc_jpeg->dev; ^~~ ~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:979:17: note: Value stored to 'dev' during its initialization is never read struct device *dev = ctx->mxc_jpeg->dev; ^~~ ~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1005:17: warning: Value stored to 'dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] struct device *dev = ctx->mxc_jpeg->dev; ^~~ ~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1005:17: note: Value stored to 'dev' during its initialization is never read struct device *dev = ctx->mxc_jpeg->dev; ^~~ ~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1177:7: warning: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch] if (!q->sizeimage[0]) ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1752:8: note: Calling 'mxc_jpeg_try_fmt_vid_out' ret = mxc_jpeg_try_fmt_vid_out(file, priv, f); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1649:16: note: Assuming field 'mode' is not equal to MXC_JPEG_ENCODE int q_type = (jpeg->mode == MXC_JPEG_ENCODE) ? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1649:15: note: '?' condition is false int q_type = (jpeg->mode == MXC_JPEG_ENCODE) ? ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1652:7: note: Assuming field 'type' is not equal to V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) { ^ include/uapi/linux/videodev2.h:161:3: note: expanded from macro 'V4L2_TYPE_IS_MULTIPLANAR' ((type) == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1652:7: note: Left side of '||' is false if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) { ^ include/uapi/linux/videodev2.h:161:3: note: expanded from macro 'V4L2_TYPE_IS_MULTIPLANAR' ((type) == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE \ ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1652:7: note: Assuming field 'type' is equal to V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) { ^ include/uapi/linux/videodev2.h:162:6: note: expanded from macro 'V4L2_TYPE_IS_MULTIPLANAR' || (type) == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1652:2: note: Taking false branch if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1658:7: note: 'fmt' is non-null if (!fmt || fmt->flags != q_type) { ^~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1658:6: note: Left side of '||' is false if (!fmt || fmt->flags != q_type) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1658:14: note: Assuming 'q_type' is equal to field 'flags' if (!fmt || fmt->flags != q_type) { ^~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1658:2: note: Taking false branch if (!fmt || fmt->flags != q_type) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1668:9: note: Calling 'mxc_jpeg_try_fmt' return mxc_jpeg_try_fmt(f, fmt, ctx, q_type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1544:11: note: Assuming field 'width' is >= MXC_JPEG_MAX_WIDTH u32 w = (pix_mp->width < MXC_JPEG_MAX_WIDTH) ? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1544:10: note: '?' condition is false u32 w = (pix_mp->width < MXC_JPEG_MAX_WIDTH) ? ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1546:11: note: Assuming field 'height' is >= MXC_JPEG_MAX_HEIGHT u32 h = (pix_mp->height < MXC_JPEG_MAX_HEIGHT) ? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1546:10: note: '?' condition is false u32 h = (pix_mp->height < MXC_JPEG_MAX_HEIGHT) ? ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1577:14: note: Assuming 'i' is >= field 'num_planes' for (i = 0; i < pix_mp->num_planes; i++) { ^~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1577:2: note: Loop condition is false. Execution continues on line 1584 for (i = 0; i < pix_mp->num_planes; i++) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1584:2: note: Calling 'mxc_jpeg_bytesperline' mxc_jpeg_bytesperline(&tmp_q, 8); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1153:6: note: Assuming the condition is true if (q->fmt->fourcc == V4L2_PIX_FMT_JPEG) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1153:2: note: Taking true branch if (q->fmt->fourcc == V4L2_PIX_FMT_JPEG) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1584:2: note: Returning from 'mxc_jpeg_bytesperline' mxc_jpeg_bytesperline(&tmp_q, 8); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1585:2: note: Calling 'mxc_jpeg_sizeimage' mxc_jpeg_sizeimage(&tmp_q); ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1175:2: note: Taking true branch if (q->fmt->fourcc == V4L2_PIX_FMT_JPEG) { ^ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1177:7: note: Branch condition evaluates to a garbage value if (!q->sizeimage[0]) ^~~~~~~~~~~~~~~~ drivers/media/platform/imx-jpeg/mxc-jpeg.c:1451:17: warning: Value stored to 'dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores] struct device *dev = mxc_jpeg->dev; vim +/dev +979 drivers/media/platform/imx-jpeg/mxc-jpeg.c 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 973 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 974 static int mxc_jpeg_decoder_cmd(struct file *file, void *priv, 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 975 struct v4l2_decoder_cmd *cmd) 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 976 { 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 977 struct v4l2_fh *fh = file->private_data; 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 978 struct mxc_jpeg_ctx *ctx = mxc_jpeg_fh_to_ctx(fh); 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 @979 struct device *dev = ctx->mxc_jpeg->dev; 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 980 int ret; 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 981 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 982 ret = v4l2_m2m_ioctl_try_decoder_cmd(file, fh, cmd); 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 983 if (ret < 0) 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 984 return ret; 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 985 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 986 if (cmd->cmd == V4L2_DEC_CMD_STOP) { 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 987 dev_dbg(dev, "Received V4L2_DEC_CMD_STOP"); 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 988 if (v4l2_m2m_num_src_bufs_ready(fh->m2m_ctx) == 0) { 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 989 /* No more src bufs, notify app EOS */ 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 990 notify_eos(ctx); 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 991 } else { 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 992 /* will send EOS later*/ 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 993 ctx->stopping = 1; 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 994 } 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 995 } 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 996 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 997 return 0; 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 998 } 2db16c6ed72ce6 Mirela Rabulea 2021-03-11 999 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
