CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Srinivasa Rao Mandadapu <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] CC: Srinivasa Rao Mandadapu <[email protected]> CC: Venkata Prasad Potturu <[email protected]>
Hi Srinivasa, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on broonie-sound/for-next] [also build test WARNING on v5.17-rc4 next-20220214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Srinivasa-Rao-Mandadapu/Add-support-for-audio-on-SC7280-based-targets/20220214-230256 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next :::::: branch date: 11 hours ago :::::: commit date: 11 hours ago config: m68k-randconfig-m031-20220214 (https://download.01.org/0day-ci/archive/20220215/[email protected]/config) compiler: m68k-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: sound/soc/qcom/lpass-platform.c:1233 lpass_platform_copy() warn: maybe return -EFAULT instead of the bytes remaining? vim +1233 sound/soc/qcom/lpass-platform.c 8d1bfc04c97407 Srinivasa Rao Mandadapu 2020-12-17 1209 e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1210 static int lpass_platform_copy(struct snd_soc_component *component, e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1211 struct snd_pcm_substream *substream, int channel, e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1212 unsigned long pos, void __user *buf, unsigned long bytes) e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1213 { e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1214 struct snd_pcm_runtime *rt = substream->runtime; e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1215 unsigned int dai_id = component->id; e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1216 int ret = 0; e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1217 e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1218 void __iomem *dma_buf = rt->dma_area + pos + e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1219 channel * (rt->dma_bytes / rt->channels); e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1220 e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1221 if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1222 if (is_cdc_dma_port(dai_id)) e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1223 ret = copy_from_user_toio(dma_buf, buf, bytes); e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1224 else e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1225 ret = copy_from_user((void __force *)dma_buf, buf, bytes); e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1226 } else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) { e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1227 if (is_cdc_dma_port(dai_id)) e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1228 ret = copy_to_user_fromio(buf, dma_buf, bytes); e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1229 else e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1230 ret = copy_to_user(buf, (void __force *)dma_buf, bytes); e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1231 } e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1232 e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 @1233 return ret; e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 1234 } 8d1bfc04c97407 Srinivasa Rao Mandadapu 2020-12-17 1235 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
