CC: [email protected] BCC: [email protected] CC: Linux Memory Management List <[email protected]> TO: James Smart <[email protected]> CC: "Martin K. Petersen" <[email protected]> CC: Justin Tee <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 6705cd745adbbeac6b13002c7a30060f7b2568a5 commit: dfef7e6b4ae0ff773fbb16b0c9741d277d905580 [9116/9295] scsi: lpfc: SLI path split: Refactor base ELS paths and the FLOGI path :::::: branch date: 12 hours ago :::::: commit date: 24 hours ago config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220301/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=dfef7e6b4ae0ff773fbb16b0c9741d277d905580 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout dfef7e6b4ae0ff773fbb16b0c9741d277d905580 # save the config file to linux build tree mkdir build_dir make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/scsi/lpfc/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> sparse warnings: (new ones prefixed by >>) drivers/scsi/lpfc/lpfc_els.c:6521:39: sparse: expected unsigned int [usertype] function_flags drivers/scsi/lpfc/lpfc_els.c:6521:39: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6522:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6522:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6522:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6533:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6533:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6533:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6550:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] function_flags @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6550:39: sparse: expected unsigned int [usertype] function_flags drivers/scsi/lpfc/lpfc_els.c:6550:39: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6551:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6551:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6551:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6562:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6562:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6562:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6579:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] function_flags @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6579:39: sparse: expected unsigned int [usertype] function_flags drivers/scsi/lpfc/lpfc_els.c:6579:39: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6580:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6580:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6580:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6592:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6592:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6592:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6609:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] function_flags @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6609:39: sparse: expected unsigned int [usertype] function_flags drivers/scsi/lpfc/lpfc_els.c:6609:39: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6610:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6610:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6610:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6618:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6618:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6618:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6624:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6624:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6624:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6633:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6633:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6633:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6635:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] CorrectedBlocks @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6635:36: sparse: expected unsigned int [usertype] CorrectedBlocks drivers/scsi/lpfc/lpfc_els.c:6635:36: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6637:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] UncorrectableBlocks @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6637:40: sparse: expected unsigned int [usertype] UncorrectableBlocks drivers/scsi/lpfc/lpfc_els.c:6637:40: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6640:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6640:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6640:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6651:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6651:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6651:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6689:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] speed @@ got restricted __be16 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6689:37: sparse: expected unsigned short [usertype] speed drivers/scsi/lpfc/lpfc_els.c:6689:37: sparse: got restricted __be16 [usertype] drivers/scsi/lpfc/lpfc_els.c:6717:44: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] capabilities @@ got restricted __be16 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6717:44: sparse: expected unsigned short [usertype] capabilities drivers/scsi/lpfc/lpfc_els.c:6717:44: sparse: got restricted __be16 [usertype] drivers/scsi/lpfc/lpfc_els.c:6718:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6718:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6718:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6727:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6727:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6727:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6735:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6735:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6735:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6744:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tag @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6744:19: sparse: expected unsigned int [usertype] tag drivers/scsi/lpfc/lpfc_els.c:6744:19: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6759:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6759:22: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6759:22: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6850:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:6850:25: sparse: expected unsigned int [usertype] length drivers/scsi/lpfc/lpfc_els.c:6850:25: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:6858:22: sparse: sparse: cast to restricted __le32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:6993:9: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7002:25: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7004:36: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7007:25: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7212:17: sparse: sparse: cast to restricted __be16 drivers/scsi/lpfc/lpfc_els.c:7217:21: sparse: sparse: cast to restricted __be16 drivers/scsi/lpfc/lpfc_els.c:7227:17: sparse: sparse: cast to restricted __be16 drivers/scsi/lpfc/lpfc_els.c:7272:9: sparse: sparse: cast to restricted __be16 drivers/scsi/lpfc/lpfc_els.c:7272:9: sparse: sparse: cast to restricted __be16 drivers/scsi/lpfc/lpfc_els.c:7416:31: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7419:44: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7516:23: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7577:23: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7630:37: sparse: sparse: cast to restricted __be32 drivers/scsi/lpfc/lpfc_els.c:7691:42: sparse: sparse: cast to restricted __be32 >> drivers/scsi/lpfc/lpfc_els.c:7696:38: sparse: sparse: invalid assignment: |= >> drivers/scsi/lpfc/lpfc_els.c:7696:38: sparse: left side has type unsigned >> int >> drivers/scsi/lpfc/lpfc_els.c:7696:38: sparse: right side has type >> restricted __be32 >> drivers/scsi/lpfc/lpfc_els.c:8207:33: sparse: sparse: incorrect type in >> assignment (different base types) @@ expected unsigned int [usertype] >> linkFailureCnt @@ got restricted __be32 [usertype] @@ drivers/scsi/lpfc/lpfc_els.c:8207:33: sparse: expected unsigned int [usertype] linkFailureCnt drivers/scsi/lpfc/lpfc_els.c:8207:33: sparse: got restricted __be32 [usertype] drivers/scsi/lpfc/lpfc_els.c:8208:30: sparse: sparse: too many warnings vim +7696 drivers/scsi/lpfc/lpfc_els.c ddcc50f0f3538e4 James Smart 2008-12-04 7538 e59058c44025d71 James Smart 2008-08-24 7539 /** 3621a710a7dbb2d James Smart 2009-04-06 7540 * lpfc_els_rcv_rscn - Process an unsolicited rscn iocb e59058c44025d71 James Smart 2008-08-24 7541 * @vport: pointer to a host virtual N_Port data structure. e59058c44025d71 James Smart 2008-08-24 7542 * @cmdiocb: pointer to lpfc command iocb data structure. e59058c44025d71 James Smart 2008-08-24 7543 * @ndlp: pointer to a node-list data structure. e59058c44025d71 James Smart 2008-08-24 7544 * e59058c44025d71 James Smart 2008-08-24 7545 * This routine processes an unsolicited RSCN (Registration State Change e59058c44025d71 James Smart 2008-08-24 7546 * Notification) IOCB. First, the payload of the unsolicited RSCN is walked e59058c44025d71 James Smart 2008-08-24 7547 * to invoke fc_host_post_event() routine to the FC transport layer. If the e59058c44025d71 James Smart 2008-08-24 7548 * discover state machine is about to begin discovery, it just accepts the e59058c44025d71 James Smart 2008-08-24 7549 * RSCN and the discovery process will satisfy the RSCN. If this RSCN only e59058c44025d71 James Smart 2008-08-24 7550 * contains N_Port IDs for other vports on this HBA, it just accepts the e59058c44025d71 James Smart 2008-08-24 7551 * RSCN and ignore processing it. If the state machine is in the recovery e59058c44025d71 James Smart 2008-08-24 7552 * state, the fc_rscn_id_list of this @vport is walked and the e59058c44025d71 James Smart 2008-08-24 7553 * lpfc_rscn_recovery_check() routine is invoked to send recovery event for e59058c44025d71 James Smart 2008-08-24 7554 * all nodes that match RSCN payload. Otherwise, the lpfc_els_handle_rscn() e59058c44025d71 James Smart 2008-08-24 7555 * routine is invoked to handle the RSCN event. e59058c44025d71 James Smart 2008-08-24 7556 * e59058c44025d71 James Smart 2008-08-24 7557 * Return code e59058c44025d71 James Smart 2008-08-24 7558 * 0 - Just sent the acc response e59058c44025d71 James Smart 2008-08-24 7559 * 1 - Sent the acc response and waited for name server completion e59058c44025d71 James Smart 2008-08-24 7560 **/ dea3101e0a5c897 James Bottomley 2005-04-17 7561 static int 2e0fef85e098f67 James Smart 2007-06-17 7562 lpfc_els_rcv_rscn(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, 51ef4c26891a734 James Smart 2007-08-02 7563 struct lpfc_nodelist *ndlp) dea3101e0a5c897 James Bottomley 2005-04-17 7564 { 2e0fef85e098f67 James Smart 2007-06-17 7565 struct Scsi_Host *shost = lpfc_shost_from_vport(vport); 2e0fef85e098f67 James Smart 2007-06-17 7566 struct lpfc_hba *phba = vport->phba; dea3101e0a5c897 James Bottomley 2005-04-17 7567 struct lpfc_dmabuf *pcmd; 92d7f7b0cde3ad2 James Smart 2007-06-17 7568 uint32_t *lp, *datap; 92d7f7b0cde3ad2 James Smart 2007-06-17 7569 uint32_t payload_len, length, nportid, *cmd; 7f5f3d0d02aa2f1 James Smart 2008-02-08 7570 int rscn_cnt; 92d7f7b0cde3ad2 James Smart 2007-06-17 7571 int rscn_id = 0, hba_id = 0; 2332e6e475b016e James Smart 2019-11-04 7572 int i, tmo; dea3101e0a5c897 James Bottomley 2005-04-17 7573 dea3101e0a5c897 James Bottomley 2005-04-17 7574 pcmd = (struct lpfc_dmabuf *) cmdiocb->context2; dea3101e0a5c897 James Bottomley 2005-04-17 7575 lp = (uint32_t *) pcmd->virt; dea3101e0a5c897 James Bottomley 2005-04-17 7576 92d7f7b0cde3ad2 James Smart 2007-06-17 7577 payload_len = be32_to_cpu(*lp++ & ~ELS_CMD_MASK); dea3101e0a5c897 James Bottomley 2005-04-17 7578 payload_len -= sizeof(uint32_t); /* take off word 0 */ dea3101e0a5c897 James Bottomley 2005-04-17 7579 /* RSCN received */ e8b62011d88d6fd James Smart 2007-08-02 7580 lpfc_printf_vlog(vport, KERN_INFO, LOG_DISCOVERY, e8b62011d88d6fd James Smart 2007-08-02 7581 "0214 RSCN received Data: x%x x%x x%x x%x\n", 7f5f3d0d02aa2f1 James Smart 2008-02-08 7582 vport->fc_flag, payload_len, *lp, 7f5f3d0d02aa2f1 James Smart 2008-02-08 7583 vport->fc_rscn_id_cnt); ddcc50f0f3538e4 James Smart 2008-12-04 7584 ddcc50f0f3538e4 James Smart 2008-12-04 7585 /* Send an RSCN event to the management application */ ddcc50f0f3538e4 James Smart 2008-12-04 7586 lpfc_send_rscn_event(vport, cmdiocb); ddcc50f0f3538e4 James Smart 2008-12-04 7587 d2873e4c1ef293e James Smart 2006-08-18 7588 for (i = 0; i < payload_len/sizeof(uint32_t); i++) 2e0fef85e098f67 James Smart 2007-06-17 7589 fc_host_post_event(shost, fc_get_event_number(), d2873e4c1ef293e James Smart 2006-08-18 7590 FCH_EVT_RSCN, lp[i]); d2873e4c1ef293e James Smart 2006-08-18 7591 f60cb93bbfecf1a James Smart 2019-05-14 7592 /* Check if RSCN is coming from a direct-connected remote NPort */ f60cb93bbfecf1a James Smart 2019-05-14 7593 if (vport->fc_flag & FC_PT2PT) { f60cb93bbfecf1a James Smart 2019-05-14 7594 /* If so, just ACC it, no other action needed for now */ f60cb93bbfecf1a James Smart 2019-05-14 7595 lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, f60cb93bbfecf1a James Smart 2019-05-14 7596 "2024 pt2pt RSCN %08x Data: x%x x%x\n", f60cb93bbfecf1a James Smart 2019-05-14 7597 *lp, vport->fc_flag, payload_len); f60cb93bbfecf1a James Smart 2019-05-14 7598 lpfc_els_rsp_acc(vport, ELS_CMD_ACC, cmdiocb, ndlp, NULL); 6f2589f478795c4 James Smart 2019-05-14 7599 a6d10f24a04d658 James Smart 2019-08-14 7600 /* Check to see if we need to NVME rescan this target a6d10f24a04d658 James Smart 2019-08-14 7601 * remoteport. a6d10f24a04d658 James Smart 2019-08-14 7602 */ a6d10f24a04d658 James Smart 2019-08-14 7603 if (ndlp->nlp_fc4_type & NLP_FC4_NVME && a6d10f24a04d658 James Smart 2019-08-14 7604 ndlp->nlp_type & (NLP_NVME_TARGET | NLP_NVME_DISCOVERY)) 6f2589f478795c4 James Smart 2019-05-14 7605 lpfc_nvme_rescan_port(vport, ndlp); f60cb93bbfecf1a James Smart 2019-05-14 7606 return 0; f60cb93bbfecf1a James Smart 2019-05-14 7607 } f60cb93bbfecf1a James Smart 2019-05-14 7608 dea3101e0a5c897 James Bottomley 2005-04-17 7609 /* If we are about to begin discovery, just ACC the RSCN. dea3101e0a5c897 James Bottomley 2005-04-17 7610 * Discovery processing will satisfy it. dea3101e0a5c897 James Bottomley 2005-04-17 7611 */ 2e0fef85e098f67 James Smart 2007-06-17 7612 if (vport->port_state <= LPFC_NS_QRY) { 858c9f6c19c6f9b James Smart 2007-06-17 7613 lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_UNSOL, 858c9f6c19c6f9b James Smart 2007-06-17 7614 "RCV RSCN ignore: did:x%x/ste:x%x flg:x%x", 858c9f6c19c6f9b James Smart 2007-06-17 7615 ndlp->nlp_DID, vport->port_state, ndlp->nlp_flag); 858c9f6c19c6f9b James Smart 2007-06-17 7616 51ef4c26891a734 James Smart 2007-08-02 7617 lpfc_els_rsp_acc(vport, ELS_CMD_ACC, cmdiocb, ndlp, NULL); c9f8735beadfba4 Jamie Wellnitz 2006-02-28 7618 return 0; dea3101e0a5c897 James Bottomley 2005-04-17 7619 } dea3101e0a5c897 James Bottomley 2005-04-17 7620 92d7f7b0cde3ad2 James Smart 2007-06-17 7621 /* If this RSCN just contains NPortIDs for other vports on this HBA, 92d7f7b0cde3ad2 James Smart 2007-06-17 7622 * just ACC and ignore it. 92d7f7b0cde3ad2 James Smart 2007-06-17 7623 */ 92d7f7b0cde3ad2 James Smart 2007-06-17 7624 if ((phba->sli3_options & LPFC_SLI3_NPIV_ENABLED) && 3de2a653a127c46 James Smart 2007-08-02 7625 !(vport->cfg_peer_port_login)) { 92d7f7b0cde3ad2 James Smart 2007-06-17 7626 i = payload_len; 92d7f7b0cde3ad2 James Smart 2007-06-17 7627 datap = lp; 92d7f7b0cde3ad2 James Smart 2007-06-17 7628 while (i > 0) { 92d7f7b0cde3ad2 James Smart 2007-06-17 7629 nportid = *datap++; 92d7f7b0cde3ad2 James Smart 2007-06-17 7630 nportid = ((be32_to_cpu(nportid)) & Mask_DID); 92d7f7b0cde3ad2 James Smart 2007-06-17 7631 i -= sizeof(uint32_t); 92d7f7b0cde3ad2 James Smart 2007-06-17 7632 rscn_id++; 549e55cd2a1b83e James Smart 2007-08-02 7633 if (lpfc_find_vport_by_did(phba, nportid)) 92d7f7b0cde3ad2 James Smart 2007-06-17 7634 hba_id++; 92d7f7b0cde3ad2 James Smart 2007-06-17 7635 } 92d7f7b0cde3ad2 James Smart 2007-06-17 7636 if (rscn_id == hba_id) { 92d7f7b0cde3ad2 James Smart 2007-06-17 7637 /* ALL NPortIDs in RSCN are on HBA */ e8b62011d88d6fd James Smart 2007-08-02 7638 lpfc_printf_vlog(vport, KERN_INFO, LOG_DISCOVERY, d7c255b26d8e3f1 James Smart 2008-08-24 7639 "0219 Ignore RSCN " e8b62011d88d6fd James Smart 2007-08-02 7640 "Data: x%x x%x x%x x%x\n", e8b62011d88d6fd James Smart 2007-08-02 7641 vport->fc_flag, payload_len, 7f5f3d0d02aa2f1 James Smart 2008-02-08 7642 *lp, vport->fc_rscn_id_cnt); 858c9f6c19c6f9b James Smart 2007-06-17 7643 lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_UNSOL, 858c9f6c19c6f9b James Smart 2007-06-17 7644 "RCV RSCN vport: did:x%x/ste:x%x flg:x%x", 858c9f6c19c6f9b James Smart 2007-06-17 7645 ndlp->nlp_DID, vport->port_state, 858c9f6c19c6f9b James Smart 2007-06-17 7646 ndlp->nlp_flag); 858c9f6c19c6f9b James Smart 2007-06-17 7647 92d7f7b0cde3ad2 James Smart 2007-06-17 7648 lpfc_els_rsp_acc(vport, ELS_CMD_ACC, cmdiocb, 51ef4c26891a734 James Smart 2007-08-02 7649 ndlp, NULL); 92d7f7b0cde3ad2 James Smart 2007-06-17 7650 return 0; 92d7f7b0cde3ad2 James Smart 2007-06-17 7651 } 92d7f7b0cde3ad2 James Smart 2007-06-17 7652 } 92d7f7b0cde3ad2 James Smart 2007-06-17 7653 7f5f3d0d02aa2f1 James Smart 2008-02-08 7654 spin_lock_irq(shost->host_lock); 7f5f3d0d02aa2f1 James Smart 2008-02-08 7655 if (vport->fc_rscn_flush) { 7f5f3d0d02aa2f1 James Smart 2008-02-08 7656 /* Another thread is walking fc_rscn_id_list on this vport */ 7f5f3d0d02aa2f1 James Smart 2008-02-08 7657 vport->fc_flag |= FC_RSCN_DISCOVERY; 979572447686006 James Smart 2009-12-21 7658 spin_unlock_irq(shost->host_lock); 58da1ffb2b1234e James Smart 2008-04-07 7659 /* Send back ACC */ 58da1ffb2b1234e James Smart 2008-04-07 7660 lpfc_els_rsp_acc(vport, ELS_CMD_ACC, cmdiocb, ndlp, NULL); 7f5f3d0d02aa2f1 James Smart 2008-02-08 7661 return 0; 7f5f3d0d02aa2f1 James Smart 2008-02-08 7662 } 7f5f3d0d02aa2f1 James Smart 2008-02-08 7663 /* Indicate we are walking fc_rscn_id_list on this vport */ 7f5f3d0d02aa2f1 James Smart 2008-02-08 7664 vport->fc_rscn_flush = 1; 7f5f3d0d02aa2f1 James Smart 2008-02-08 7665 spin_unlock_irq(shost->host_lock); af901ca181d92aa André Goddard Rosa 2009-11-14 7666 /* Get the array count after successfully have the token */ 7f5f3d0d02aa2f1 James Smart 2008-02-08 7667 rscn_cnt = vport->fc_rscn_id_cnt; dea3101e0a5c897 James Bottomley 2005-04-17 7668 /* If we are already processing an RSCN, save the received dea3101e0a5c897 James Bottomley 2005-04-17 7669 * RSCN payload buffer, cmdiocb->context2 to process later. dea3101e0a5c897 James Bottomley 2005-04-17 7670 */ 2e0fef85e098f67 James Smart 2007-06-17 7671 if (vport->fc_flag & (FC_RSCN_MODE | FC_NDISC_ACTIVE)) { 858c9f6c19c6f9b James Smart 2007-06-17 7672 lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_UNSOL, 858c9f6c19c6f9b James Smart 2007-06-17 7673 "RCV RSCN defer: did:x%x/ste:x%x flg:x%x", 858c9f6c19c6f9b James Smart 2007-06-17 7674 ndlp->nlp_DID, vport->port_state, ndlp->nlp_flag); 858c9f6c19c6f9b James Smart 2007-06-17 7675 0937282036d9ae7 James Smart 2008-01-11 7676 spin_lock_irq(shost->host_lock); 92d7f7b0cde3ad2 James Smart 2007-06-17 7677 vport->fc_flag |= FC_RSCN_DEFERRED; 2332e6e475b016e James Smart 2019-11-04 7678 2332e6e475b016e James Smart 2019-11-04 7679 /* Restart disctmo if its already running */ 2332e6e475b016e James Smart 2019-11-04 7680 if (vport->fc_flag & FC_DISC_TMO) { 2332e6e475b016e James Smart 2019-11-04 7681 tmo = ((phba->fc_ratov * 3) + 3); 2332e6e475b016e James Smart 2019-11-04 7682 mod_timer(&vport->fc_disctmo, 2332e6e475b016e James Smart 2019-11-04 7683 jiffies + msecs_to_jiffies(1000 * tmo)); 2332e6e475b016e James Smart 2019-11-04 7684 } 92d7f7b0cde3ad2 James Smart 2007-06-17 7685 if ((rscn_cnt < FC_MAX_HOLD_RSCN) && 2e0fef85e098f67 James Smart 2007-06-17 7686 !(vport->fc_flag & FC_RSCN_DISCOVERY)) { 2e0fef85e098f67 James Smart 2007-06-17 7687 vport->fc_flag |= FC_RSCN_MODE; 2e0fef85e098f67 James Smart 2007-06-17 7688 spin_unlock_irq(shost->host_lock); 92d7f7b0cde3ad2 James Smart 2007-06-17 7689 if (rscn_cnt) { 92d7f7b0cde3ad2 James Smart 2007-06-17 7690 cmd = vport->fc_rscn_id_list[rscn_cnt-1]->virt; 92d7f7b0cde3ad2 James Smart 2007-06-17 7691 length = be32_to_cpu(*cmd & ~ELS_CMD_MASK); 92d7f7b0cde3ad2 James Smart 2007-06-17 7692 } 92d7f7b0cde3ad2 James Smart 2007-06-17 7693 if ((rscn_cnt) && 92d7f7b0cde3ad2 James Smart 2007-06-17 7694 (payload_len + length <= LPFC_BPL_SIZE)) { 92d7f7b0cde3ad2 James Smart 2007-06-17 7695 *cmd &= ELS_CMD_MASK; 7f5f3d0d02aa2f1 James Smart 2008-02-08 @7696 *cmd |= cpu_to_be32(payload_len + length); 92d7f7b0cde3ad2 James Smart 2007-06-17 7697 memcpy(((uint8_t *)cmd) + length, lp, 92d7f7b0cde3ad2 James Smart 2007-06-17 7698 payload_len); 92d7f7b0cde3ad2 James Smart 2007-06-17 7699 } else { 92d7f7b0cde3ad2 James Smart 2007-06-17 7700 vport->fc_rscn_id_list[rscn_cnt] = pcmd; 92d7f7b0cde3ad2 James Smart 2007-06-17 7701 vport->fc_rscn_id_cnt++; dea3101e0a5c897 James Bottomley 2005-04-17 7702 /* If we zero, cmdiocb->context2, the calling dea3101e0a5c897 James Bottomley 2005-04-17 7703 * routine will not try to free it. dea3101e0a5c897 James Bottomley 2005-04-17 7704 */ dea3101e0a5c897 James Bottomley 2005-04-17 7705 cmdiocb->context2 = NULL; 92d7f7b0cde3ad2 James Smart 2007-06-17 7706 } dea3101e0a5c897 James Bottomley 2005-04-17 7707 /* Deferred RSCN */ e8b62011d88d6fd James Smart 2007-08-02 7708 lpfc_printf_vlog(vport, KERN_INFO, LOG_DISCOVERY, e8b62011d88d6fd James Smart 2007-08-02 7709 "0235 Deferred RSCN " dea3101e0a5c897 James Bottomley 2005-04-17 7710 "Data: x%x x%x x%x\n", 92d7f7b0cde3ad2 James Smart 2007-06-17 7711 vport->fc_rscn_id_cnt, vport->fc_flag, 2e0fef85e098f67 James Smart 2007-06-17 7712 vport->port_state); dea3101e0a5c897 James Bottomley 2005-04-17 7713 } else { 2e0fef85e098f67 James Smart 2007-06-17 7714 vport->fc_flag |= FC_RSCN_DISCOVERY; 2e0fef85e098f67 James Smart 2007-06-17 7715 spin_unlock_irq(shost->host_lock); dea3101e0a5c897 James Bottomley 2005-04-17 7716 /* ReDiscovery RSCN */ e8b62011d88d6fd James Smart 2007-08-02 7717 lpfc_printf_vlog(vport, KERN_INFO, LOG_DISCOVERY, e8b62011d88d6fd James Smart 2007-08-02 7718 "0234 ReDiscovery RSCN " dea3101e0a5c897 James Bottomley 2005-04-17 7719 "Data: x%x x%x x%x\n", 92d7f7b0cde3ad2 James Smart 2007-06-17 7720 vport->fc_rscn_id_cnt, vport->fc_flag, 2e0fef85e098f67 James Smart 2007-06-17 7721 vport->port_state); dea3101e0a5c897 James Bottomley 2005-04-17 7722 } 7f5f3d0d02aa2f1 James Smart 2008-02-08 7723 /* Indicate we are done walking fc_rscn_id_list on this vport */ 7f5f3d0d02aa2f1 James Smart 2008-02-08 7724 vport->fc_rscn_flush = 0; dea3101e0a5c897 James Bottomley 2005-04-17 7725 /* Send back ACC */ 51ef4c26891a734 James Smart 2007-08-02 7726 lpfc_els_rsp_acc(vport, ELS_CMD_ACC, cmdiocb, ndlp, NULL); dea3101e0a5c897 James Bottomley 2005-04-17 7727 /* send RECOVERY event for ALL nodes that match RSCN payload */ 2e0fef85e098f67 James Smart 2007-06-17 7728 lpfc_rscn_recovery_check(vport); c9f8735beadfba4 Jamie Wellnitz 2006-02-28 7729 return 0; dea3101e0a5c897 James Bottomley 2005-04-17 7730 } 858c9f6c19c6f9b James Smart 2007-06-17 7731 lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_UNSOL, 858c9f6c19c6f9b James Smart 2007-06-17 7732 "RCV RSCN: did:x%x/ste:x%x flg:x%x", 858c9f6c19c6f9b James Smart 2007-06-17 7733 ndlp->nlp_DID, vport->port_state, ndlp->nlp_flag); 858c9f6c19c6f9b James Smart 2007-06-17 7734 2e0fef85e098f67 James Smart 2007-06-17 7735 spin_lock_irq(shost->host_lock); 2e0fef85e098f67 James Smart 2007-06-17 7736 vport->fc_flag |= FC_RSCN_MODE; 2e0fef85e098f67 James Smart 2007-06-17 7737 spin_unlock_irq(shost->host_lock); 2e0fef85e098f67 James Smart 2007-06-17 7738 vport->fc_rscn_id_list[vport->fc_rscn_id_cnt++] = pcmd; 7f5f3d0d02aa2f1 James Smart 2008-02-08 7739 /* Indicate we are done walking fc_rscn_id_list on this vport */ 7f5f3d0d02aa2f1 James Smart 2008-02-08 7740 vport->fc_rscn_flush = 0; dea3101e0a5c897 James Bottomley 2005-04-17 7741 /* dea3101e0a5c897 James Bottomley 2005-04-17 7742 * If we zero, cmdiocb->context2, the calling routine will dea3101e0a5c897 James Bottomley 2005-04-17 7743 * not try to free it. dea3101e0a5c897 James Bottomley 2005-04-17 7744 */ dea3101e0a5c897 James Bottomley 2005-04-17 7745 cmdiocb->context2 = NULL; 2e0fef85e098f67 James Smart 2007-06-17 7746 lpfc_set_disctmo(vport); dea3101e0a5c897 James Bottomley 2005-04-17 7747 /* Send back ACC */ 51ef4c26891a734 James Smart 2007-08-02 7748 lpfc_els_rsp_acc(vport, ELS_CMD_ACC, cmdiocb, ndlp, NULL); dea3101e0a5c897 James Bottomley 2005-04-17 7749 /* send RECOVERY event for ALL nodes that match RSCN payload */ 2e0fef85e098f67 James Smart 2007-06-17 7750 lpfc_rscn_recovery_check(vport); 2e0fef85e098f67 James Smart 2007-06-17 7751 return lpfc_els_handle_rscn(vport); dea3101e0a5c897 James Bottomley 2005-04-17 7752 } dea3101e0a5c897 James Bottomley 2005-04-17 7753 :::::: The code at line 7696 was first introduced by commit :::::: 7f5f3d0d02aa2f124e764aee5c775589ce72fd42 [SCSI] lpfc 8.2.5 : Miscellaneous discovery Fixes :::::: TO: James Smart <[email protected]> :::::: CC: James Bottomley <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
