CC: [email protected] BCC: [email protected] CC: "GNU/Weeb Mailing List" <[email protected]> CC: [email protected] TO: David Howells <[email protected]>
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/fscache-next head: 78e12b114b9c804d4b1eef16b6df1112cde6a960 commit: ad9e5adb388f358027a51032b3944913d98f7866 [36/39] netfs: Rename rename read_helper.c to io.c :::::: branch date: 9 hours ago :::::: commit date: 9 hours ago config: arm-randconfig-m031-20220302 (https://download.01.org/0day-ci/archive/20220303/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: fs/netfs/io.c:655 netfs_begin_read() error: uninitialized symbol 'ret'. vim +/ret +655 fs/netfs/io.c 3d3c95046742e4 fs/netfs/read_helper.c David Howells 2020-05-13 595 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 596 /* c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 597 * Begin the process of reading in a chunk of data, where that data may be c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 598 * stitched together from multiple sources, including multiple servers and the c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 599 * local cache. c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 600 */ c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 601 int netfs_begin_read(struct netfs_io_request *rreq, bool sync) c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 602 { c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 603 unsigned int debug_index = 0; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 604 int ret; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 605 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 606 _enter("R=%x %llx-%llx", c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 607 rreq->debug_id, rreq->start, rreq->start + rreq->len - 1); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 608 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 609 if (rreq->len == 0) { c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 610 pr_err("Zero-sized read [R=%x]\n", rreq->debug_id); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 611 netfs_put_request(rreq, false, netfs_rreq_trace_put_zero_len); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 612 return -EIO; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 613 } c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 614 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 615 rreq->work.func = netfs_rreq_work; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 616 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 617 if (sync) c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 618 netfs_get_request(rreq, netfs_rreq_trace_get_hold); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 619 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 620 /* Chop the read into slices according to what the cache and the netfs c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 621 * want and submit each one. c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 622 */ c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 623 atomic_set(&rreq->nr_outstanding, 1); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 624 do { c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 625 if (!netfs_rreq_submit_slice(rreq, &debug_index)) c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 626 break; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 627 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 628 } while (rreq->submitted < rreq->len); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 629 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 630 if (sync) { c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 631 /* Keep nr_outstanding incremented so that the ref always belongs to c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 632 * us, and the service code isn't punted off to a random thread pool to c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 633 * process. c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 634 */ c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 635 for (;;) { c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 636 wait_var_event(&rreq->nr_outstanding, c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 637 atomic_read(&rreq->nr_outstanding) == 1); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 638 netfs_rreq_assess(rreq, false); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 639 if (!test_bit(NETFS_RREQ_IN_PROGRESS, &rreq->flags)) c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 640 break; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 641 cond_resched(); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 642 } c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 643 c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 644 ret = rreq->error; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 645 if (ret == 0 && rreq->submitted < rreq->len) { c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 646 trace_netfs_failure(rreq, NULL, ret, netfs_fail_short_read); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 647 ret = -EIO; c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 648 } c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 649 netfs_put_request(rreq, false, netfs_rreq_trace_put_hold); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 650 } else { c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 651 /* If we decrement nr_outstanding to 0, the ref belongs to us. */ c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 652 if (atomic_dec_and_test(&rreq->nr_outstanding)) c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 653 netfs_rreq_assess(rreq, false); c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 654 } c19a5d31b470e0 fs/netfs/read_helper.c David Howells 2022-03-02 @655 return ret; :::::: The code at line 655 was first introduced by commit :::::: c19a5d31b470e0a7dea07a71bb7b98a916b449e9 netfs: Add a function to consolidate beginning a read :::::: TO: David Howells <[email protected]> :::::: CC: David Howells <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
