CC: [email protected] BCC: [email protected] CC: [email protected] TO: NeilBrown <[email protected]> CC: Trond Myklebust <[email protected]> CC: Anna Schumaker <[email protected]> CC: Chuck Lever <[email protected]> CC: Jakub Kicinski <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> net/sunrpc/xprt.c:1690:18-28: ERROR: function xprt_dynamic_alloc_slot called on line 1728 inside lock on line 1722 but uses GFP_KERNEL Find functions that refer to GFP_KERNEL but are called with locks held. Semantic patch information: The proposed change of converting the GFP_KERNEL is not necessarily the correct one. It may be desired to unlock the lock, or to not call the function under the lock in the first place. Generated by: scripts/coccinelle/locks/call_kern.cocci Fixes: a721035477fb ("SUNRPC/xprt: async tasks mustn't block waiting for memory") CC: NeilBrown <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git linux-next head: 693486d5f8951780a9bb31f7fe935171a80010e4 commit: a721035477fb5fb8abc738fbe410b07c12af3dc5 [59/66] SUNRPC/xprt: async tasks mustn't block waiting for memory :::::: branch date: 11 hours ago :::::: commit date: 11 hours ago Please take the patch only if it's a positive warning. Thanks! net/sunrpc/xprt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c @@ -1687,7 +1687,7 @@ out: static struct rpc_rqst *xprt_dynamic_alloc_slot(struct rpc_xprt *xprt) { struct rpc_rqst *req = ERR_PTR(-EAGAIN); - gfp_t gfp_mask = GFP_KERNEL; + gfp_t gfp_mask = GFP_ATOMIC; if (xprt->num_reqs >= xprt->max_reqs) goto out; _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
