CC: [email protected]
BCC: [email protected]
CC: [email protected]
TO: Eli Cohen <[email protected]>
CC: "Michael S. Tsirkin" <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   09688c0166e76ce2fb85e86b9d99be8b0084cdf9
commit: 71ab6a7cfbae27f86a3901daab10bfe13b3a1e3a vdpa/mlx5: Fix possible 
failure in umem size calculation
date:   9 months ago
:::::: branch date: 29 hours ago
:::::: commit date: 9 months ago
config: riscv-randconfig-m031-20220313 
(https://download.01.org/0day-ci/archive/20220315/[email protected]/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 set_umem_size() error: uninitialized 
symbol 'p_a'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 set_umem_size() error: uninitialized 
symbol 'p_b'.

Old smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:715 umem_destroy() error: potentially 
dereferencing uninitialized 'umem'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:2058 mlx5_vdpa_dev_add() error: uninitialized 
symbol 'pfmdev'.

vim +/p_a +638 drivers/vdpa/mlx5/net/mlx5_vnet.c

1a86b377aa2147a Eli Cohen 2020-08-04  613  
71ab6a7cfbae27f Eli Cohen 2021-05-30  614  static void set_umem_size(struct 
mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *mvq, int num,
1a86b377aa2147a Eli Cohen 2020-08-04  615                         struct 
mlx5_vdpa_umem **umemp)
1a86b377aa2147a Eli Cohen 2020-08-04  616  {
1a86b377aa2147a Eli Cohen 2020-08-04  617       struct mlx5_core_dev *mdev = 
ndev->mvdev.mdev;
1a86b377aa2147a Eli Cohen 2020-08-04  618       int p_a;
1a86b377aa2147a Eli Cohen 2020-08-04  619       int p_b;
1a86b377aa2147a Eli Cohen 2020-08-04  620  
1a86b377aa2147a Eli Cohen 2020-08-04  621       switch (num) {
1a86b377aa2147a Eli Cohen 2020-08-04  622       case 1:
1a86b377aa2147a Eli Cohen 2020-08-04  623               p_a = 
MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_1_buffer_param_a);
1a86b377aa2147a Eli Cohen 2020-08-04  624               p_b = 
MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_1_buffer_param_b);
1a86b377aa2147a Eli Cohen 2020-08-04  625               *umemp = &mvq->umem1;
1a86b377aa2147a Eli Cohen 2020-08-04  626               break;
1a86b377aa2147a Eli Cohen 2020-08-04  627       case 2:
1a86b377aa2147a Eli Cohen 2020-08-04  628               p_a = 
MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_2_buffer_param_a);
1a86b377aa2147a Eli Cohen 2020-08-04  629               p_b = 
MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_2_buffer_param_b);
1a86b377aa2147a Eli Cohen 2020-08-04  630               *umemp = &mvq->umem2;
1a86b377aa2147a Eli Cohen 2020-08-04  631               break;
1a86b377aa2147a Eli Cohen 2020-08-04  632       case 3:
1a86b377aa2147a Eli Cohen 2020-08-04  633               p_a = 
MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_3_buffer_param_a);
1a86b377aa2147a Eli Cohen 2020-08-04  634               p_b = 
MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_3_buffer_param_b);
1a86b377aa2147a Eli Cohen 2020-08-04  635               *umemp = &mvq->umem3;
1a86b377aa2147a Eli Cohen 2020-08-04  636               break;
1a86b377aa2147a Eli Cohen 2020-08-04  637       }
71ab6a7cfbae27f Eli Cohen 2021-05-30 @638       (*umemp)->size = p_a * 
mvq->num_ent + p_b;
1a86b377aa2147a Eli Cohen 2020-08-04  639  }
1a86b377aa2147a Eli Cohen 2020-08-04  640  

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/[email protected]
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to