CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Krzysztof Kozlowski <k...@kernel.org>
CC: Julia Lawall <julia.law...@inria.fr>
CC: Russell King <li...@armlinux.org.uk>
CC: David Airlie <airl...@linux.ie>
CC: Daniel Vetter <dan...@ffwll.ch>
CC: dri-de...@lists.freedesktop.org
CC: linux-ker...@vger.kernel.org
From: kernel test robot <l...@intel.com>
drivers/gpu/drm/i2c/tda998x_drv.c:1916:8-28: WARNING: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Krzysztof Kozlowski <krzysztof.kozlow...@canonical.com>
Reported-by: kernel test robot <l...@intel.com>
Signed-off-by: kernel test robot <l...@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 09688c0166e76ce2fb85e86b9d99be8b0084cdf9
commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot:
reduce the severity due to false positives
:::::: branch date: 32 hours ago
:::::: commit date: 11 months ago
Please take the patch only if it's a positive warning. Thanks!
drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1914,7 +1914,8 @@ static int tda998x_create(struct device
irq_flags |= IRQF_SHARED | IRQF_ONESHOT;
ret = request_threaded_irq(client->irq, NULL,
- tda998x_irq_thread, irq_flags,
+ tda998x_irq_thread,
+ irq_flags | IRQF_ONESHOT,
"tda998x", priv);
if (ret) {
dev_err(dev, "failed to request IRQ#%u: %d\n",
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org
