CC: [email protected] BCC: [email protected] CC: [email protected] TO: Bart Van Assche <[email protected]>
tree: https://github.com/bvanassche/linux ufs-for-next head: a05da846ebd6cdac01b4c4fded4bada67bec84f0 commit: a05da846ebd6cdac01b4c4fded4bada67bec84f0 [319/319] scsi: ufs: Split struct ufs_hba :::::: branch date: 9 hours ago :::::: commit date: 9 hours ago config: powerpc-randconfig-m031-20220321 (https://download.01.org/0day-ci/archive/20220321/[email protected]/config) compiler: powerpc-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/scsi/ufs/ufshcd.c:5371 ufshcd_uic_cmd_compl() error: we previously assumed 'priv->active_uic_cmd' could be null (see line 5359) vim +5371 drivers/scsi/ufs/ufshcd.c a45f937110fa6b Can Guo 2021-05-24 5340 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5341 /** 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5342 * ufshcd_uic_cmd_compl - handle completion of uic command 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5343 * @hba: per adapter instance 53b3d9c3fdda94 Seungwon Jeon 2013-08-31 5344 * @intr_status: interrupt status generated by the controller 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5345 * 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5346 * Returns 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5347 * IRQ_HANDLED - If interrupt is valid 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5348 * IRQ_NONE - If invalid interrupt 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5349 */ 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5350 static irqreturn_t ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status) 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5351 { a05da846ebd6cd Bart Van Assche 2022-03-19 5352 struct ufs_hba_priv *priv = container_of(hba, typeof(*priv), hba); 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5353 irqreturn_t retval = IRQ_NONE; 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5354 a05da846ebd6cd Bart Van Assche 2022-03-19 5355 spin_lock(priv->host->host_lock); a45f937110fa6b Can Guo 2021-05-24 5356 if (ufshcd_is_auto_hibern8_error(hba, intr_status)) a05da846ebd6cd Bart Van Assche 2022-03-19 5357 priv->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status); a45f937110fa6b Can Guo 2021-05-24 5358 a05da846ebd6cd Bart Van Assche 2022-03-19 @5359 if ((intr_status & UIC_COMMAND_COMPL) && priv->active_uic_cmd) { a05da846ebd6cd Bart Van Assche 2022-03-19 5360 priv->active_uic_cmd->argument2 |= 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5361 ufshcd_get_uic_cmd_result(hba); a05da846ebd6cd Bart Van Assche 2022-03-19 5362 priv->active_uic_cmd->argument3 = 12b4fdb4f6bccb Seungwon Jeon 2013-08-31 5363 ufshcd_get_dme_attr_val(hba); a05da846ebd6cd Bart Van Assche 2022-03-19 5364 if (!priv->uic_async_done) a05da846ebd6cd Bart Van Assche 2022-03-19 5365 priv->active_uic_cmd->cmd_active = 0; a05da846ebd6cd Bart Van Assche 2022-03-19 5366 complete(&priv->active_uic_cmd->done); 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5367 retval = IRQ_HANDLED; 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5368 } 53b3d9c3fdda94 Seungwon Jeon 2013-08-31 5369 a05da846ebd6cd Bart Van Assche 2022-03-19 5370 if ((intr_status & UFSHCD_UIC_PWR_MASK) && priv->uic_async_done) { a05da846ebd6cd Bart Van Assche 2022-03-19 @5371 priv->active_uic_cmd->cmd_active = 0; a05da846ebd6cd Bart Van Assche 2022-03-19 5372 complete(priv->uic_async_done); 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5373 retval = IRQ_HANDLED; 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5374 } aa5c697988b4c7 Stanley Chu 2020-06-15 5375 aa5c697988b4c7 Stanley Chu 2020-06-15 5376 if (retval == IRQ_HANDLED) a05da846ebd6cd Bart Van Assche 2022-03-19 5377 ufshcd_add_uic_command_trace(hba, priv->active_uic_cmd, 28fa68fc557a7e Bean Huo 2021-01-05 5378 UFS_CMD_COMP); a05da846ebd6cd Bart Van Assche 2022-03-19 5379 spin_unlock(priv->host->host_lock); 9333d77573485c Venkat Gopalakrishnan 2019-11-14 5380 return retval; 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5381 } 6ccf44fe4cd7c4 Seungwon Jeon 2013-06-26 5382 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
