CC: [email protected] BCC: [email protected] CC: [email protected] TO: Piyush Mehta <[email protected]> CC: Michal Simek <[email protected]> CC: Manish Narani <[email protected]>
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS head: 1870e0fa79a9d58c6748c34550f3ccea0b515933 commit: 0839809852bc5822dc1cf4446cb6c89d7f221659 [334/1029] usb: host: xhci: plat: add support for otg_set_host() call :::::: branch date: 2 days ago :::::: commit date: 8 weeks ago config: nios2-randconfig-m031-20220324 (https://download.01.org/0day-ci/archive/20220326/[email protected]/config) compiler: nios2-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/usb/host/xhci-plat.c:197 usb_otg_set_host() warn: missing error code 'ret' vim +/ret +197 drivers/usb/host/xhci-plat.c 4efb2f69411456d Yoshihiro Shimoda 2015-11-24 187 0839809852bc582 Piyush Mehta 2022-01-26 188 static int usb_otg_set_host(struct device *dev, struct usb_hcd *hcd, bool yes) 0839809852bc582 Piyush Mehta 2022-01-26 189 { 0839809852bc582 Piyush Mehta 2022-01-26 190 int ret = 0; 0839809852bc582 Piyush Mehta 2022-01-26 191 0839809852bc582 Piyush Mehta 2022-01-26 192 hcd->usb_phy = usb_get_phy(USB_PHY_TYPE_USB3); 0839809852bc582 Piyush Mehta 2022-01-26 193 if (!IS_ERR_OR_NULL(hcd->usb_phy) && hcd->usb_phy->otg) { 0839809852bc582 Piyush Mehta 2022-01-26 194 if (yes) { 0839809852bc582 Piyush Mehta 2022-01-26 195 if (otg_set_host(hcd->usb_phy->otg, &hcd->self)) { 0839809852bc582 Piyush Mehta 2022-01-26 196 usb_put_phy(hcd->usb_phy); 0839809852bc582 Piyush Mehta 2022-01-26 @197 goto disable_phy; 0839809852bc582 Piyush Mehta 2022-01-26 198 } 0839809852bc582 Piyush Mehta 2022-01-26 199 } else { 0839809852bc582 Piyush Mehta 2022-01-26 200 ret = otg_set_host(hcd->usb_phy->otg, NULL); 0839809852bc582 Piyush Mehta 2022-01-26 201 usb_put_phy(hcd->usb_phy); 0839809852bc582 Piyush Mehta 2022-01-26 202 goto disable_phy; 0839809852bc582 Piyush Mehta 2022-01-26 203 } 0839809852bc582 Piyush Mehta 2022-01-26 204 0839809852bc582 Piyush Mehta 2022-01-26 205 } else { 0839809852bc582 Piyush Mehta 2022-01-26 206 goto disable_phy; 0839809852bc582 Piyush Mehta 2022-01-26 207 } 0839809852bc582 Piyush Mehta 2022-01-26 208 0839809852bc582 Piyush Mehta 2022-01-26 209 return 0; 0839809852bc582 Piyush Mehta 2022-01-26 210 0839809852bc582 Piyush Mehta 2022-01-26 211 disable_phy: 0839809852bc582 Piyush Mehta 2022-01-26 212 hcd->usb_phy = NULL; 0839809852bc582 Piyush Mehta 2022-01-26 213 0839809852bc582 Piyush Mehta 2022-01-26 214 return ret; 0839809852bc582 Piyush Mehta 2022-01-26 215 } 0839809852bc582 Piyush Mehta 2022-01-26 216 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
