CC: [email protected]
BCC: [email protected]
CC: [email protected]
TO: SeongJae Park <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   787af64d05cd528aac9ad16752d11bb1c6061bb9
commit: 90bebce9fcd6488ba6b010af3a16a0a0d7e44cb6 mm/damon/dbgfs: allow users to 
set initial monitoring target regions
date:   5 months ago
:::::: branch date: 15 hours ago
:::::: commit date: 5 months ago
config: arc-randconfig-m031-20220331 
(https://download.01.org/0day-ci/archive/20220331/[email protected]/config)
compiler: arceb-elf-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
mm/damon/dbgfs.c:525 dbgfs_init_regions_write() warn: passing a valid pointer 
to 'PTR_ERR'

vim +/PTR_ERR +525 mm/damon/dbgfs.c

90bebce9fcd648 SeongJae Park 2021-11-05  513  
90bebce9fcd648 SeongJae Park 2021-11-05  514  static ssize_t 
dbgfs_init_regions_write(struct file *file,
90bebce9fcd648 SeongJae Park 2021-11-05  515                                    
  const char __user *buf, size_t count,
90bebce9fcd648 SeongJae Park 2021-11-05  516                                    
  loff_t *ppos)
90bebce9fcd648 SeongJae Park 2021-11-05  517  {
90bebce9fcd648 SeongJae Park 2021-11-05  518    struct damon_ctx *ctx = 
file->private_data;
90bebce9fcd648 SeongJae Park 2021-11-05  519    char *kbuf;
90bebce9fcd648 SeongJae Park 2021-11-05  520    ssize_t ret = count;
90bebce9fcd648 SeongJae Park 2021-11-05  521    int err;
90bebce9fcd648 SeongJae Park 2021-11-05  522  
90bebce9fcd648 SeongJae Park 2021-11-05  523    kbuf = user_input_str(buf, 
count, ppos);
90bebce9fcd648 SeongJae Park 2021-11-05  524    if (IS_ERR(kbuf))
90bebce9fcd648 SeongJae Park 2021-11-05 @525            return PTR_ERR(kbuf);
90bebce9fcd648 SeongJae Park 2021-11-05  526  
90bebce9fcd648 SeongJae Park 2021-11-05  527    mutex_lock(&ctx->kdamond_lock);
90bebce9fcd648 SeongJae Park 2021-11-05  528    if (ctx->kdamond) {
90bebce9fcd648 SeongJae Park 2021-11-05  529            ret = -EBUSY;
90bebce9fcd648 SeongJae Park 2021-11-05  530            goto unlock_out;
90bebce9fcd648 SeongJae Park 2021-11-05  531    }
90bebce9fcd648 SeongJae Park 2021-11-05  532  
90bebce9fcd648 SeongJae Park 2021-11-05  533    err = set_init_regions(ctx, 
kbuf, ret);
90bebce9fcd648 SeongJae Park 2021-11-05  534    if (err)
90bebce9fcd648 SeongJae Park 2021-11-05  535            ret = err;
90bebce9fcd648 SeongJae Park 2021-11-05  536  
90bebce9fcd648 SeongJae Park 2021-11-05  537  unlock_out:
90bebce9fcd648 SeongJae Park 2021-11-05  538    
mutex_unlock(&ctx->kdamond_lock);
90bebce9fcd648 SeongJae Park 2021-11-05  539    kfree(kbuf);
90bebce9fcd648 SeongJae Park 2021-11-05  540    return ret;
90bebce9fcd648 SeongJae Park 2021-11-05  541  }
90bebce9fcd648 SeongJae Park 2021-11-05  542  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to