CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Nava kishore Manne <[email protected]>
Hi Nava, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.17 next-20220401] [cannot apply to xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Nava-kishore-Manne/fpga-zynq-Fix-incorrect-variable-type/20220403-141639 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git be2d3ecedd9911fbfd7e55cc9ceac5f8b79ae4cf :::::: branch date: 7 hours ago :::::: commit date: 7 hours ago config: csky-randconfig-m031-20220403 (https://download.01.org/0day-ci/archive/20220403/[email protected]/config) compiler: csky-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/fpga/zynq-fpga.c:245 zynq_fpga_has_sync() warn: impossible condition '(buf[2] == 153) => ((-128)-127 == 153)' Old smatch warnings: drivers/fpga/zynq-fpga.c:246 zynq_fpga_has_sync() warn: impossible condition '(buf[3] == 170) => ((-128)-127 == 170)' vim +245 drivers/fpga/zynq-fpga.c 37784706bf9e3b Moritz Fischer 2015-10-16 237 0269b45231586f Nava kishore Manne 2022-04-03 238 /* Sanity check the proposed bitstream. The sync word must be found in the 0269b45231586f Nava kishore Manne 2022-04-03 239 * correct byte order and it should be dword aligned. The input is a 0269b45231586f Nava kishore Manne 2022-04-03 240 * Xilinx.bin file with every 32 bit quantity swapped. b496df86ac1bbe Jason Gunthorpe 2017-02-01 241 */ 0269b45231586f Nava kishore Manne 2022-04-03 242 static bool zynq_fpga_has_sync(const char *buf, size_t count) b496df86ac1bbe Jason Gunthorpe 2017-02-01 243 { b496df86ac1bbe Jason Gunthorpe 2017-02-01 244 for (; count >= 4; buf += 4, count -= 4) b496df86ac1bbe Jason Gunthorpe 2017-02-01 @245 if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && b496df86ac1bbe Jason Gunthorpe 2017-02-01 246 buf[3] == 0xaa) b496df86ac1bbe Jason Gunthorpe 2017-02-01 247 return true; b496df86ac1bbe Jason Gunthorpe 2017-02-01 248 return false; b496df86ac1bbe Jason Gunthorpe 2017-02-01 249 } b496df86ac1bbe Jason Gunthorpe 2017-02-01 250 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
