CC: [email protected] BCC: [email protected] CC: Alison Schofield <[email protected]> CC: Vishal Verma <[email protected]> CC: Ira Weiny <[email protected]> CC: Ben Widawsky <[email protected]> CC: Dan Williams <[email protected]> CC: [email protected] TO: Alison Schofield <[email protected]> CC: Dan Williams <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git pending head: 7dc1d11d7abae52aada5340fb98885f0ddbb7c37 commit: be0d0ce77aa3b93c40e2f72bbcab5df883bc0cb6 [3/13] cxl/mbox: Move build of user mailbox cmd to a helper functions :::::: branch date: 2 days ago :::::: commit date: 2 days ago config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220406/[email protected]/config) compiler: gcc-11 (Debian 11.2.0-19) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/cxl/core/mbox.c:223 cxl_mbox_cmd_ctor() warn: passing zero to 'PTR_ERR' drivers/cxl/core/mbox.c:227 cxl_mbox_cmd_ctor() warn: unsigned 'out_size' is never less than zero. vim +/PTR_ERR +223 drivers/cxl/core/mbox.c 4faf31b43468c58 Dan Williams 2021-09-08 209 be0d0ce77aa3b93 Alison Schofield 2022-03-30 210 static int cxl_mbox_cmd_ctor(struct cxl_mbox_cmd *mbox, be0d0ce77aa3b93 Alison Schofield 2022-03-30 211 struct cxl_dev_state *cxlds, u16 opcode, be0d0ce77aa3b93 Alison Schofield 2022-03-30 212 size_t in_size, size_t out_size, u64 in_payload) be0d0ce77aa3b93 Alison Schofield 2022-03-30 213 { be0d0ce77aa3b93 Alison Schofield 2022-03-30 214 *mbox = (struct cxl_mbox_cmd) { be0d0ce77aa3b93 Alison Schofield 2022-03-30 215 .opcode = opcode, be0d0ce77aa3b93 Alison Schofield 2022-03-30 216 .size_in = in_size, be0d0ce77aa3b93 Alison Schofield 2022-03-30 217 }; be0d0ce77aa3b93 Alison Schofield 2022-03-30 218 be0d0ce77aa3b93 Alison Schofield 2022-03-30 219 if (in_size) { be0d0ce77aa3b93 Alison Schofield 2022-03-30 220 mbox->payload_in = vmemdup_user(u64_to_user_ptr(in_payload), be0d0ce77aa3b93 Alison Schofield 2022-03-30 221 in_size); be0d0ce77aa3b93 Alison Schofield 2022-03-30 222 if (!mbox->payload_in) be0d0ce77aa3b93 Alison Schofield 2022-03-30 @223 return PTR_ERR(mbox->payload_in); be0d0ce77aa3b93 Alison Schofield 2022-03-30 224 } be0d0ce77aa3b93 Alison Schofield 2022-03-30 225 be0d0ce77aa3b93 Alison Schofield 2022-03-30 226 /* Prepare to handle a full payload for variable sized output */ be0d0ce77aa3b93 Alison Schofield 2022-03-30 @227 if (out_size < 0) be0d0ce77aa3b93 Alison Schofield 2022-03-30 228 mbox->size_out = cxlds->payload_size; be0d0ce77aa3b93 Alison Schofield 2022-03-30 229 else be0d0ce77aa3b93 Alison Schofield 2022-03-30 230 mbox->size_out = out_size; be0d0ce77aa3b93 Alison Schofield 2022-03-30 231 be0d0ce77aa3b93 Alison Schofield 2022-03-30 232 if (mbox->size_out) { be0d0ce77aa3b93 Alison Schofield 2022-03-30 233 mbox->payload_out = kvzalloc(mbox->size_out, GFP_KERNEL); be0d0ce77aa3b93 Alison Schofield 2022-03-30 234 if (!mbox->payload_out) { be0d0ce77aa3b93 Alison Schofield 2022-03-30 235 kvfree(mbox->payload_in); be0d0ce77aa3b93 Alison Schofield 2022-03-30 236 return -ENOMEM; be0d0ce77aa3b93 Alison Schofield 2022-03-30 237 } be0d0ce77aa3b93 Alison Schofield 2022-03-30 238 } be0d0ce77aa3b93 Alison Schofield 2022-03-30 239 return 0; be0d0ce77aa3b93 Alison Schofield 2022-03-30 240 } be0d0ce77aa3b93 Alison Schofield 2022-03-30 241 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
