CC: [email protected] BCC: [email protected] CC: [email protected] TO: Eric Dumazet <[email protected]> CC: Jakub Kicinski <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3e732ebf7316ac83e8562db7e64cc68aec390a18 commit: e93abb840a2c356ed2809c31fcedb058601ac2e4 net/tcp_fastopen: remove tcp_fastopen_ctx_lock date: 9 months ago :::::: branch date: 6 hours ago :::::: commit date: 9 months ago config: ia64-randconfig-m031-20220405 (https://download.01.org/0day-ci/archive/20220406/[email protected]/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: net/ipv4/tcp_fastopen.c:97 tcp_fastopen_reset_cipher() warn: possible memory leak of 'ctx' vim +/ctx +97 net/ipv4/tcp_fastopen.c 437138485656c41 Haishuang Yan 2017-09-27 63 9092a76d3cf8638 Jason Baron 2019-05-29 64 int tcp_fastopen_reset_cipher(struct net *net, struct sock *sk, 438ac88009bcb10 Ard Biesheuvel 2019-06-19 65 void *primary_key, void *backup_key) 9092a76d3cf8638 Jason Baron 2019-05-29 66 { 9092a76d3cf8638 Jason Baron 2019-05-29 67 struct tcp_fastopen_context *ctx, *octx; 9092a76d3cf8638 Jason Baron 2019-05-29 68 struct fastopen_queue *q; 9092a76d3cf8638 Jason Baron 2019-05-29 69 int err = 0; 1046716368979de Jerry Chu 2012-08-31 70 c681edae33e86ff Ard Biesheuvel 2019-06-17 71 ctx = kmalloc(sizeof(*ctx), GFP_KERNEL); c681edae33e86ff Ard Biesheuvel 2019-06-17 72 if (!ctx) { c681edae33e86ff Ard Biesheuvel 2019-06-17 73 err = -ENOMEM; 9092a76d3cf8638 Jason Baron 2019-05-29 74 goto out; 9092a76d3cf8638 Jason Baron 2019-05-29 75 } c681edae33e86ff Ard Biesheuvel 2019-06-17 76 438ac88009bcb10 Ard Biesheuvel 2019-06-19 77 ctx->key[0].key[0] = get_unaligned_le64(primary_key); 438ac88009bcb10 Ard Biesheuvel 2019-06-19 78 ctx->key[0].key[1] = get_unaligned_le64(primary_key + 8); c681edae33e86ff Ard Biesheuvel 2019-06-17 79 if (backup_key) { 438ac88009bcb10 Ard Biesheuvel 2019-06-19 80 ctx->key[1].key[0] = get_unaligned_le64(backup_key); 438ac88009bcb10 Ard Biesheuvel 2019-06-19 81 ctx->key[1].key[1] = get_unaligned_le64(backup_key + 8); c681edae33e86ff Ard Biesheuvel 2019-06-17 82 ctx->num = 2; c681edae33e86ff Ard Biesheuvel 2019-06-17 83 } else { c681edae33e86ff Ard Biesheuvel 2019-06-17 84 ctx->num = 1; c681edae33e86ff Ard Biesheuvel 2019-06-17 85 } c681edae33e86ff Ard Biesheuvel 2019-06-17 86 1fba70e5b6bed53 Yuchung Cheng 2017-10-18 87 if (sk) { 1fba70e5b6bed53 Yuchung Cheng 2017-10-18 88 q = &inet_csk(sk)->icsk_accept_queue.fastopenq; e93abb840a2c356 Eric Dumazet 2021-07-19 89 octx = xchg((__force struct tcp_fastopen_context **)&q->ctx, ctx); 1fba70e5b6bed53 Yuchung Cheng 2017-10-18 90 } else { e93abb840a2c356 Eric Dumazet 2021-07-19 91 octx = xchg((__force struct tcp_fastopen_context **)&net->ipv4.tcp_fastopen_ctx, ctx); 1fba70e5b6bed53 Yuchung Cheng 2017-10-18 92 } 1046716368979de Jerry Chu 2012-08-31 93 1046716368979de Jerry Chu 2012-08-31 94 if (octx) 1046716368979de Jerry Chu 2012-08-31 95 call_rcu(&octx->rcu, tcp_fastopen_ctx_free); 9092a76d3cf8638 Jason Baron 2019-05-29 96 out: 1046716368979de Jerry Chu 2012-08-31 @97 return err; 1046716368979de Jerry Chu 2012-08-31 98 } 1046716368979de Jerry Chu 2012-08-31 99 :::::: The code at line 97 was first introduced by commit :::::: 1046716368979dee857a2b8a91c4a8833f21b9cb tcp: TCP Fast Open Server - header & support functions :::::: TO: Jerry Chu <[email protected]> :::::: CC: David S. Miller <[email protected]> -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
