CC: [email protected] BCC: [email protected] CC: [email protected] TO: Russell King <[email protected]> CC: Andrew Lunn <[email protected]> CC: Heiner Kallweit <[email protected]> CC: Jakub Kicinski <[email protected]> CC: Paolo Abeni <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/net/phy/qsfp.c:1750:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Russell King <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: git://git.armlinux.org.uk/~rmk/linux-arm.git cex7 head: d4b5e6687e034b7408f75fcbeccda90fd424b853 commit: 15b70689e8853e6983ab01bad883aca045d7b4ae [143/148] net: add qsfp support [*experimental*] :::::: branch date: 12 hours ago :::::: commit date: 12 hours ago Please take the patch only if it's a positive warning. Thanks! drivers/net/phy/qsfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/phy/qsfp.c +++ b/drivers/net/phy/qsfp.c @@ -1748,7 +1748,8 @@ static int qsfp_probe(struct platform_de } err = devm_request_threaded_irq(qsfp->dev, qsfp->gpio_irq[i], - NULL, irq_handler, irq_flags, + NULL, irq_handler, + irq_flags | IRQF_ONESHOT, dev_name(qsfp->dev), qsfp); if (err) { qsfp->gpio_irq[i] = 0; _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
